Skip to content

Conversation

@Abyssknight
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
    • adding/removing APIs.
    • adding/removing properties.
    • adding/removing API-version.
    • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 12, 2020

[Staging] Swagger Validation Report

  • ️✔️~[Staging] BreakingChange [Detail]

  • Posted by Swagger Pipeline

    @ghost
    Copy link

    ghost commented Jun 12, 2020

    CLA assistant check
    All CLA requirements met.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 12, 2020

    azure-sdk-for-go - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 12, 2020

    Azure CLI Extension Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 12, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 12, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 6c7deff with merge commit 91e1643. SDK Automation 13.0.17.20200605.3
    • ️✔️@azure/arm-vmware [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/azureVMwareSolutionAPI.js → ./dist/arm-vmware.js...
      [npmPack] created ./dist/arm-vmware.js in 306ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/arm-vmware@0.1.0
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 65.5kB  dist/arm-vmware.js                        
      [npmPack] npm notice 21.0kB  dist/arm-vmware.min.js                    
      [npmPack] npm notice 1.7kB   esm/azureVMwareSolutionAPI.js             
      [npmPack] npm notice 2.6kB   esm/azureVMwareSolutionAPIContext.js      
      [npmPack] npm notice 10.7kB  esm/operations/clusters.js                
      [npmPack] npm notice 629B    esm/models/clustersMappers.js             
      [npmPack] npm notice 345B    esm/models/index.js                       
      [npmPack] npm notice 471B    esm/operations/index.js                   
      [npmPack] npm notice 2.6kB   esm/operations/locations.js               
      [npmPack] npm notice 430B    esm/models/locationsMappers.js            
      [npmPack] npm notice 19.8kB  esm/models/mappers.js                     
      [npmPack] npm notice 2.2kB   esm/operations/operations.js              
      [npmPack] npm notice 461B    esm/models/operationsMappers.js           
      [npmPack] npm notice 2.0kB   esm/models/parameters.js                  
      [npmPack] npm notice 12.4kB  esm/operations/privateClouds.js           
      [npmPack] npm notice 657B    esm/models/privateCloudsMappers.js        
      [npmPack] npm notice 980B    rollup.config.js                          
      [npmPack] npm notice 1.6kB   package.json                              
      [npmPack] npm notice 457B    tsconfig.json                             
      [npmPack] npm notice 133.7kB dist/arm-vmware.js.map                    
      [npmPack] npm notice 19.8kB  dist/arm-vmware.min.js.map                
      [npmPack] npm notice 726B    esm/azureVMwareSolutionAPI.d.ts.map       
      [npmPack] npm notice 880B    esm/azureVMwareSolutionAPI.js.map         
      [npmPack] npm notice 510B    esm/azureVMwareSolutionAPIContext.d.ts.map
      [npmPack] npm notice 1.4kB   esm/azureVMwareSolutionAPIContext.js.map  
      [npmPack] npm notice 2.7kB   esm/operations/clusters.d.ts.map          
      [npmPack] npm notice 5.3kB   esm/operations/clusters.js.map            
      [npmPack] npm notice 338B    esm/models/clustersMappers.d.ts.map       
      [npmPack] npm notice 351B    esm/models/clustersMappers.js.map         
      [npmPack] npm notice 9.5kB   esm/models/index.d.ts.map                 
      [npmPack] npm notice 202B    esm/operations/index.d.ts.map             
      [npmPack] npm notice 126B    esm/models/index.js.map                   
      [npmPack] npm notice 217B    esm/operations/index.js.map               
      [npmPack] npm notice 1.1kB   esm/operations/locations.d.ts.map         
      [npmPack] npm notice 1.5kB   esm/operations/locations.js.map           
      [npmPack] npm notice 207B    esm/models/locationsMappers.d.ts.map      
      [npmPack] npm notice 220B    esm/models/locationsMappers.js.map        
      [npmPack] npm notice 1.3kB   esm/models/mappers.d.ts.map               
      [npmPack] npm notice 11.5kB  esm/models/mappers.js.map                 
      [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map        
      [npmPack] npm notice 1.4kB   esm/operations/operations.js.map          
      [npmPack] npm notice 222B    esm/models/operationsMappers.d.ts.map     
      [npmPack] npm notice 235B    esm/models/operationsMappers.js.map       
      [npmPack] npm notice 541B    esm/models/parameters.d.ts.map            
      [npmPack] npm notice 1.5kB   esm/models/parameters.js.map              
      [npmPack] npm notice 3.7kB   esm/operations/privateClouds.d.ts.map     
      [npmPack] npm notice 6.6kB   esm/operations/privateClouds.js.map       
      [npmPack] npm notice 364B    esm/models/privateCloudsMappers.d.ts.map  
      [npmPack] npm notice 377B    esm/models/privateCloudsMappers.js.map    
      [npmPack] npm notice 3.1kB   README.md                                 
      [npmPack] npm notice 1.1kB   esm/azureVMwareSolutionAPI.d.ts           
      [npmPack] npm notice 1.7kB   src/azureVMwareSolutionAPI.ts             
      [npmPack] npm notice 816B    esm/azureVMwareSolutionAPIContext.d.ts    
      [npmPack] npm notice 2.3kB   src/azureVMwareSolutionAPIContext.ts      
      [npmPack] npm notice 7.5kB   esm/operations/clusters.d.ts              
      [npmPack] npm notice 14.3kB  src/operations/clusters.ts                
      [npmPack] npm notice 319B    esm/models/clustersMappers.d.ts           
      [npmPack] npm notice 619B    src/models/clustersMappers.ts             
      [npmPack] npm notice 24.6kB  esm/models/index.d.ts                     
      [npmPack] npm notice 155B    esm/operations/index.d.ts                 
      [npmPack] npm notice 23.6kB  src/models/index.ts                       
      [npmPack] npm notice 439B    src/operations/index.ts                   
      [npmPack] npm notice 2.1kB   esm/operations/locations.d.ts             
      [npmPack] npm notice 4.5kB   src/operations/locations.ts               
      [npmPack] npm notice 120B    esm/models/locationsMappers.d.ts          
      [npmPack] npm notice 395B    src/models/locationsMappers.ts            
      [npmPack] npm notice 1.5kB   esm/models/mappers.d.ts                   
      [npmPack] npm notice 15.7kB  src/models/mappers.ts                     
      [npmPack] npm notice 2.0kB   esm/operations/operations.d.ts            
      [npmPack] npm notice 4.0kB   src/operations/operations.ts              
      [npmPack] npm notice 151B    esm/models/operationsMappers.d.ts         
      [npmPack] npm notice 427B    src/models/operationsMappers.ts           
      [npmPack] npm notice 610B    esm/models/parameters.d.ts                
      [npmPack] npm notice 2.1kB   src/models/parameters.ts                  
      [npmPack] npm notice 9.7kB   esm/operations/privateClouds.d.ts         
      [npmPack] npm notice 19.0kB  src/operations/privateClouds.ts           
      [npmPack] npm notice 347B    esm/models/privateCloudsMappers.d.ts      
      [npmPack] npm notice 644B    src/models/privateCloudsMappers.ts        
      [npmPack] npm notice 1.1kB   LICENSE.txt                               
      [npmPack] npm notice === Tarball Details === 
      [npmPack] npm notice name:          @azure/arm-vmware                       
      [npmPack] npm notice version:       0.1.0                                   
      [npmPack] npm notice filename:      azure-arm-vmware-0.1.0.tgz              
      [npmPack] npm notice package size:  55.6 kB                                 
      [npmPack] npm notice unpacked size: 498.9 kB                                
      [npmPack] npm notice shasum:        38e43ceda0aa4ccacabaa3dfb083d20084165585
      [npmPack] npm notice integrity:     sha512-/Ivh9u4cAVh+j[...]N78UXYOKci8Cg==

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 12, 2020

    azure-sdk-for-net - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 6c7deff with merge commit 91e1643. SDK Automation 13.0.17.20200605.3
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      Failed to find any changed packages. Please check the changed file list.
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/AzureVMwareSolutionAPIClient.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/ClustersOperations.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/ClustersOperationsExtensions.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/IAzureVMwareSolutionAPIClient.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/IClustersOperations.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/ILocationsOperations.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/IOperations.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/IPrivateCloudsOperations.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/LocationsOperations.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/LocationsOperationsExtensions.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/AdminCredentials.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/ApiError.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/ApiErrorBase.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/ApiErrorException.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/Circuit.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/Cluster.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/ClusterProperties.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/ClusterProvisioningState.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/DefaultClusterProperties.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/Endpoints.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/ExpressRouteAuthorization.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/IdentitySource.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/InternetEnum.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/Operation.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/OperationDisplay.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/Page.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/PrivateCloud.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/PrivateCloudProperties.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/PrivateCloudProvisioningState.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/Quota.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/QuotaEnabled.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/Resource.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/Sku.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/SslEnum.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/TrackedResource.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Models/Trial.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/Operations.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/OperationsExtensions.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/PrivateCloudsOperations.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/PrivateCloudsOperationsExtensions.cs
      /z/work/azure-sdk-for-net/sdk/VMware/Management.VMware/Generated/SdkInfo_AzureVMwareSolutionAPI.cs

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 12, 2020

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 12, 2020

    azure-sdk-for-python - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 6c7deff with merge commit 91e1643. SDK Automation 13.0.17.20200605.3
      [azure-mgmt-vmware][ChangeLog] WARNING: Failed to generate ChangeLog.
    • ⚠️azure-mgmt-vmware [View full logs]  [Release SDK Changes]
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-vmware
      [build_conf] INFO:packaging_tools.conf:Build default conf for azure-mgmt-vmware
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-vmware
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      Not exact 2 reports found:
      code_reports/latest/report.json
      Not generating changelog.
      [ChangeLog] WARNING: Failed to generate ChangeLog.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jun 12, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @azuresdkci
    Copy link
    Contributor

    Can one of the admins verify this patch?

    @qiaozha qiaozha merged commit 91e1643 into master Jun 12, 2020
    @qiaozha qiaozha deleted the vmware-package-version branch June 12, 2020 01:54
    @ctaggart
    Copy link
    Contributor

    Hey @Abyssknight & @qiaozha, I'm going to remove the version for C# in #9773, since it is not necessary and not used when producing the nuget package.

    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    Co-authored-by: Shixun Guan <v-shigua@microsoft.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    6 participants