Sync from master

.azure-pipelines-preproduction/package.json

@@ -10,8 +10,8 @@
   "description": "Tests for Azure REST API Specifications",
   "license": "MIT",
   "devDependencies": {
-    "@azure/avocado": "^0.6.2",
-    "@azure/rest-api-specs-scripts": "^0.6.7",
+    "@azure/avocado": "^0.6.3",
+    "@azure/rest-api-specs-scripts": "^0.9.0",
     "@ts-common/commonmark-to-markdown": "^1.2.0",
     "@ts-common/fs": "0.2.0",
     "@ts-common/iterator": "^0.3.6",

.azure-pipelines/Avocado.yml

@@ -9,3 +9,4 @@ jobs:
       verbose: false
   - script: './node_modules/.bin/avocado'
     displayName: 'Avocado'
+    condition: ne(variables['Build.SourceBranch'], 'refs/heads/master')

.azure-pipelines/SDKAutomation.yml

@@ -7,14 +7,15 @@ trigger:
 pr:
   autoCancel: false
 
+variables:
+  IMAGE: azopenapi.azurecr.io/openapi/sdk-automation:prod
+  REGISTRY_ENDPOINT: azopenapi-registry
+
 jobs:
 - job: "SDKAutomation"
   displayName: SDK
   pool:
     vmImage: 'Ubuntu 18.04'
-  container:
-    image: azopenapi.azurecr.io/openapi/sdk-automation:prod
-    endpoint: azopenapi-registry
   timeoutInMinutes: 180
 
   variables:
@@ -32,27 +33,47 @@ jobs:
         SDK_REPO_NAME: azure-sdk-for-js
       Python:
         SDK_REPO_NAME: azure-sdk-for-python
+      Cliextension:
+        SDK_REPO_NAME: azure-cli-extensions
       Go:
         SDK_REPO_NAME: azure-sdk-for-go
+      Trenton:
+        SDK_REPO_NAME: azure-sdk-for-trenton
   steps:
   - checkout: none
-  - script: printenv
-    displayName: Display ENV
-  - script: git config --global user.email "sdkautomation@microsoft.com" && git config --global user.name "SDK Automation"
-    displayName: Configure Git
   - script: |
       curl \
         -s https://api.github.com/repos/$(Build.Repository.Name)/commits/$(Build.SourceVersion)/pulls \
         -H "Accept: application/vnd.github.groot-preview+json" \
       | python3 -c "import sys,json; a=json.load(sys.stdin); print(f'##vso[task.setvariable variable=PR_NUMBER]{a[0][\"number\"]}' if len(a)>0 and a[0][\"base\"][\"ref\"]=='master' else '##vso[task.logissue type=error]Last commit $(Build.SourceVersion) doesnot have a related PR')"
     displayName: Get PR_NUMBER
     condition: in(variables['Build.Reason'], 'IndividualCI', 'Manual')
-  - script: sudo chown `id -ng`:`id -ng` . && npm start
+  - task: Docker@2
+    displayName: Login into ACR
+    inputs:
+      command: login
+      containerRegistry: $(REGISTRY_ENDPOINT)
+  - script: |
+      docker pull $IMAGE
+      docker tag $IMAGE sdk-automation:latest
+    displayName: Pull SDK Automation Image
+  - script: |
+      docker run \
+        -e BLOB_STORAGE_NAME \
+        -e BLOB_STORAGE_KEY \
+        -e GITHUB_COMMENT_AUTHOR_NAME \
+        -e GITHUBAPP_ID \
+        -e GITHUBAPP_PRIVATE_KEY \
+        -e NODE_OPTIONS \
+        -e BLOB_STORAGE_PREFIX \
+        -e SPEC_REPO \
+        -e PR_NUMBER \
+        -e SDK_REPO_NAME \
+        sdk-automation:latest npm start
     env:
       BLOB_STORAGE_NAME: $(blob-storage-name)
       BLOB_STORAGE_KEY: $(blob-storage-key)
       GITHUB_COMMENT_AUTHOR_NAME: $(github-comment-author-name)
       GITHUBAPP_ID: $(githubapp-id)
       GITHUBAPP_PRIVATE_KEY: $(githubapp-private-key)
     displayName: SDK Automation
-    workingDirectory: /z

.azure-pipelines/SwaggerToSDK.yml

@@ -12,6 +12,12 @@ jobs:
       python:
         AZURE_SDK_REPO: azure-sdk-for-python
         AZURE_SDK_PARAMS: ''
+      cliextension:
+        AZURE_SDK_REPO: azure-cli-extensions
+        AZURE_SDK_PARAMS: ''
+      trenton:
+        AZURE_SDK_REPO: azure-sdk-for-trenton
+        AZURE_SDK_PARAMS: ''
       go:
         AZURE_SDK_REPO: azure-sdk-for-go
         AZURE_SDK_PARAMS: '-o latest'

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,17 +1,20 @@
-### Latest improvements:
 <i>MSFT employees can try out our new experience at <b>[OpenAPI Hub](https://aka.ms/openapiportal) </b> - one location for using our validation tools and finding your workflow. 
-</i><br>
+</i>
+
 ### Contribution checklist:
-- [ ] I have reviewed the [documentation](https://github.com/Azure/adx-documentation-pr/wiki/Overall-basic-flow) for the workflow.
-- [ ] [Validation tools](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/swagger-checklist.md#validation-tools-for-swagger-checklist) were run on swagger spec(s) and have all been fixed in this PR.
-- [ ] The [OpenAPI Hub](https://aka.ms/openapiportal) was used for checking validation status and next steps.
+- [ ] I have reviewed the [documentation](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/202/Overall-Process-of-AME-Onboarding) for the workflow.
+- [ ] [Validation tools](https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/84/Swagger-Validation-tools) were run on swagger spec(s) and have all been fixed in this PR. [How to fix?](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md)
+
+If any further question about AME onboarding or validation tools, please view the [FAQ](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/FAQ.md).
+
 ### ARM API Review Checklist
-- [ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories. 
-- adding/removing APIs.
-- adding/removing properties.
-- adding/removing API-version. 
-- adding a new service in Azure.
+- [ ] Service team MUST add the "**WaitForARMFeedback**" label if the management plane API changes fall into one of the below categories. 
+  - adding/removing APIs.
+  - adding/removing properties.
+  - adding/removing API-version. 
+  - adding a new service in Azure.
+
+<i>Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.</i>
 
-Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
 - [ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them. 
-Please follow the link to find more details on [API review process](https://armwiki.azurewebsites.net/rp_onboarding/ResourceProviderOnboardingAPIRevieworkflow.html).
+Please follow the link to find more details on [API review process]( https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/212/Swagger-PR-Review).

.github/assignment.yml

@@ -0,0 +1,154 @@
+---
+- rule:
+    # data-plane PR
+    paths:
+      - "specification/**/data-plane/**"
+    reviewers:
+      - anuchandy
+      - jhendrixMSFT
+      - lmazuel
+      - tjprescott
+
+- rule:
+    paths:
+      - "specification/network/**"
+    reviewers:
+      - lirenhe
+      - MyronFanQiu
+
+- rule:
+    paths:
+      - "specification/@(applicationinsights|operationalinsights)/**"
+    reviewers:
+      - MyronFanQiu
+
+- rule:
+    paths: "specification/compute/**"
+    reviewers:
+      - ArcturusZhang
+      - fengzhou-msft
+      - yungezz
+
+- rule:
+    paths: "specification/resources/**"
+    reviewers:
+      - raych1
+
+- rule:
+    paths:
+      - "specification/machinelearningservices/**"
+    reviewers:
+      - ArcturusZhang
+
+- rule:
+    paths:
+      - "specification/@(azureactivedirectory|appplatform)/**"
+    reviewers:
+      - njuCZ
+
+- rule:
+    paths:
+      - "specification/authorization/**"
+    reviewers:
+      - qianwens
+      - yungezz
+
+- rule:
+    paths:
+      - "specification/datafactory/**"
+    reviewers:
+      - qianwens
+
+- rule:
+    paths:
+      - "specification/monitor/**"
+    reviewers:
+      - weidongxu-microsoft
+      - MyronFanQiu
+
+- rule:
+    paths:
+      - "specification/storage/**"
+    reviewers:
+      - qianwens
+      - Juliehzl
+
+- rule:
+    paths: "specification/mediaservices/**"
+    reviewers:
+      - allenjzhang
+
+- rule:
+    paths:
+      - "specification/@(keyvault|notificationhubs)/**"
+      - "specification/@(databricks|containerregistry)/**"
+    reviewers:
+      - fengzhou-msft
+
+- rule:
+    paths:
+      - "specification/@(containerservice|containerinstance)/**"
+    reviewers:
+      - NullMDR
+      - fengzhou-msft
+      - yungezz
+
+- rule:
+    paths:
+      - "specification/mixedreality/**"
+    reviewers:
+      - leni-msft
+
+- rule:
+    paths:
+      - "specification/portal/**"
+    reviewers:
+      - NullMDR
+
+- rule:
+    paths:
+      - "specification/web/**"
+    reviewers:
+      - weidongxu-microsoft
+
+- rule:
+    paths:
+      - "documentation/**"
+    reviewers:
+      - josefree
+      - akning-ms
+
+- rule:
+    paths:
+      - "**/package.json"
+      - ".github/**"
+      - "**/azure-pipelines.yml"
+      - ".azure-pipelines/**"
+      - ".azure-pipelines-preproduction/**"
+    reviewers:
+      - akning-ms
+      - NullMDR
+      - raych1
+
+- rule:
+    # manager-plane PR
+    paths:
+      - "**"
+    reviewers:
+      - yungezz
+      - zikalino
+      - erich-wang
+      - NullMDR
+      - raych1
+      - lirenhe
+      - weidongxu-microsoft
+      - ArcturusZhang
+      - xccc-msft
+      - ChenTanyi
+      - fengzhou-msft
+      - njuCZ
+      - akning-ms
+      - markcowl
+      - leni-msft
+      - qianwens
+      - ruowan