EventGrid: New preview API version with support for IPFiltering in Domains & Topics. #8100

grandhiramesh · 2020-01-09T01:28:08Z

EventGrid: New preview API version with support for IPFiltering in Domains & Topics.

oTopicProperties: Following new properties are introduced:
allowTrafficFromAllIPs
inboundIpRules
oDomainProperties: Following new properties are introduced:
allowTrafficFromAllIPs
inboundIpRules
oMinor change in the description fields:
oInboundIpRule: Following new model with the following properties are introduced:
IpMask
Action

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…rt in Domains & Topics. EventGrid: New preview API version with support for IPFiltering support in Domains & Topics. oTopicProperties: Following new properties are introduced: allowTrafficFromAllIPs inboundIpRules o DomainProperties: Following new properties are introduced:  allowTrafficFromAllIPs  inboundIpRules o Minor change in the description fields: o InboundIpRule: Following new model with the following properties are introduced:  IpMask  Action

Update Examples for Domain/Topics

azure-pipelines · 2020-01-09T01:28:26Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-09T01:28:43Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-01-09T01:30:20Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4bc9f1d with merge commit 9c19e84. SDK Automation 13.0.17.20191226.1
️✔️sdk/eventgrid/mgmt-v2018_01_01 [Logs] [Release SDK Changes]
️✔️sdk/eventgrid/mgmt-v2018_05_01_preview [Logs] [Release SDK Changes]
️✔️sdk/eventgrid/mgmt-v2018_09_15_preview [Logs] [Release SDK Changes]
️✔️sdk/eventgrid/mgmt-v2019_01_01 [Logs] [Release SDK Changes]
️✔️sdk/eventgrid/mgmt-v2019_02_01_preview [Logs] [Release SDK Changes]
️✔️sdk/eventgrid/mgmt-v2019_06_01 [Logs] [Release SDK Changes]
️✔️sdk/eventgrid/mgmt-v2020_01_01_preview [Logs] [Release SDK Changes]
️✔️sdk/eventgrid/mgmt-v2020_04_01_preview [Logs] [Release SDK Changes]

openapi-sdkautomation · 2020-01-09T01:30:20Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4bc9f1d with merge commit 9c19e84. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-eventgrid [Logs] [Release SDK Changes]

azure-arm-eventgrid-4.2.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/eventGridManagementClient.js → ./dist/arm-eventgrid.js...
[npmPack] created ./dist/arm-eventgrid.js in 420ms

azure-pipelines · 2020-01-09T01:33:23Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-01-09T01:34:40Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4bc9f1d with merge commit 9c19e84. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.EventGrid [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.EventGrid.5.1.0-preview.nupkg
- Microsoft.Azure.Management.EventGrid.5.1.0-preview.snupkg

openapi-sdkautomation · 2020-01-09T01:34:41Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4bc9f1d with merge commit 9c19e84. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-eventgrid [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

openapi-sdkautomation · 2020-01-09T01:34:43Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 4bc9f1d with merge commit 9c19e84. SDK Automation 13.0.17.20191226.1
️✔️eventgrid/mgmt/2018-01-01 [Logs] [Release SDK Changes]
- eventgrid.mgmt.2018-01-01.zip
️✔️eventgrid/mgmt/2019-01-01 [Logs] [Release SDK Changes]
- eventgrid.mgmt.2019-01-01.zip
️✔️eventgrid/mgmt/2019-06-01 [Logs] [Release SDK Changes]
- eventgrid.mgmt.2019-06-01.zip
️✔️preview/eventgrid/mgmt/2017-06-15-preview [Logs] [Release SDK Changes]
- preview.eventgrid.mgmt.2017-06-15-preview.zip
️✔️preview/eventgrid/mgmt/2017-09-15-preview [Logs] [Release SDK Changes]
- preview.eventgrid.mgmt.2017-09-15-preview.zip
️✔️preview/eventgrid/mgmt/2018-05-01-preview [Logs] [Release SDK Changes]
- preview.eventgrid.mgmt.2018-05-01-preview.zip
️✔️preview/eventgrid/mgmt/2018-09-15-preview [Logs] [Release SDK Changes]
- preview.eventgrid.mgmt.2018-09-15-preview.zip
️✔️preview/eventgrid/mgmt/2019-02-01-preview [Logs] [Release SDK Changes]
- preview.eventgrid.mgmt.2019-02-01-preview.zip
️✔️preview/eventgrid/mgmt/2020-01-01-preview [Logs] [Release SDK Changes]
- preview.eventgrid.mgmt.2020-01-01-preview.zip
️✔️preview/eventgrid/mgmt/2020-04-01-preview [Logs] [Release SDK Changes]
- preview.eventgrid.mgmt.2020-04-01-preview.zip

azure-pipelines · 2020-01-09T01:38:45Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-09T01:39:04Z

Azure Pipelines successfully started running 1 pipeline(s).

Correct the misspelled description

azure-pipelines · 2020-01-09T01:53:24Z

Azure Pipelines successfully started running 1 pipeline(s).

Fix Prettier issue

azure-pipelines · 2020-01-09T02:19:22Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-09T03:35:44Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-09T04:03:14Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-09T04:07:59Z

Azure Pipelines successfully started running 1 pipeline(s).

ryansbenson

A few questions, everything else looks good.

ryansbenson · 2020-01-09T18:40:28Z

...ion/eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-04-01-preview/EventGrid.json

+          "200": {
+            "description": "OK",
+            "schema": {
+              "$ref": "#/definitions/TopicsListResult


looks like you removed 'readonly': 'true'.

Was this intentional?

...ion/eventgrid/resource-manager/Microsoft.EventGrid/preview/2020-04-01-preview/EventGrid.json

zikalino

compared with previous 2020-01-01-preview.
minimal changes.
lgtm

grandhiramesh added 2 commits January 8, 2020 16:21

Update Examples for Domain/Topics

d33983e

Update Examples for Domain/Topics

grandhiramesh requested a review from kalyanaj as a code owner January 9, 2020 01:28

openapi-assignment-bot bot assigned akning-ms Jan 9, 2020

openapi-sdkautomation bot mentioned this pull request Jan 9, 2020

[AutoPR @azure/arm-eventgrid] EventGrid: New preview API version with support for IPFiltering in Domains & Topics. AzureSDKAutomation/azure-sdk-for-js#225

Closed

grandhiramesh changed the title ~~EventGrid: New preview API version with support for IPFiltering support in Domains & Topics.~~ EventGrid: New preview API version with support for IPFiltering in Domains & Topics. Jan 9, 2020

Correct the misspelled description

7a8fbc1

Correct the misspelled description

Fix Prettier issue

5fc2482

Fix Prettier issue

add the required property on inputschemamapping

4bc9f1d

ryansbenson reviewed Jan 9, 2020

View reviewed changes

zikalino approved these changes Jan 9, 2020

View reviewed changes

zikalino merged commit 9c19e84 into Azure:master Jan 9, 2020

EventGrid: New preview API version with support for IPFiltering in Domains & Topics. #8100

EventGrid: New preview API version with support for IPFiltering in Domains & Topics. #8100

Uh oh!

Conversation

grandhiramesh commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Jan 9, 2020

Uh oh!

azure-pipelines bot commented Jan 9, 2020

Uh oh!

openapi-sdkautomation bot commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

azure-pipelines bot commented Jan 9, 2020

Uh oh!

openapi-sdkautomation bot commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

azure-pipelines bot commented Jan 9, 2020

Uh oh!

azure-pipelines bot commented Jan 9, 2020

Uh oh!

azure-pipelines bot commented Jan 9, 2020

Uh oh!

azure-pipelines bot commented Jan 9, 2020

Uh oh!

azure-pipelines bot commented Jan 9, 2020

Uh oh!

azure-pipelines bot commented Jan 9, 2020

Uh oh!

azure-pipelines bot commented Jan 9, 2020

Uh oh!

ryansbenson left a comment

Choose a reason for hiding this comment

Uh oh!

ryansbenson Jan 9, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zikalino left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

grandhiramesh commented Jan 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 9, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 9, 2020 •

edited

Loading