Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swagger specification for Service Fabric runtime version 7.0 #7828

Merged
merged 5 commits into from
Dec 2, 2019
Merged

Swagger specification for Service Fabric runtime version 7.0 #7828

merged 5 commits into from
Dec 2, 2019

Conversation

jeffj6123
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@jeffj6123
Copy link
Contributor Author

@amanbha

@AutorestCI AutorestCI mentioned this pull request Nov 22, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 22, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8916

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Nov 22, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 22, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6462

@jeffj6123
Copy link
Contributor Author

These are not ARM APIs. These are Service Fabric runtime apis for 7.0 release

@jeffj6123
Copy link
Contributor Author

@anuchandy All the CI is passing, is there anything left to do to get this merged in?

@anuchandy
Copy link
Member

anuchandy commented Dec 1, 2019 •
edited
Loading

@samedder, @jeffj6123 lgtm, is this version already deployed to at least one prod-region?

@jeffj6123
Copy link
Contributor Author

@samedder, @jeffj6123 lgtm, is this version already deployed to at least one prod-region?

Yes it is

@anuchandy anuchandy merged commit 348ffa4 into Azure:master Dec 2, 2019
TalluriAnusha pushed a commit to AsrOneSdk/azure-rest-api-specs that referenced this pull request Dec 11, 2019
@jeffj6123 @AnuTalluri
Swagger specification for Service Fabric runtime version 7.0 (Azure#7828
9b3964d 
)

* added 7.0

* updated read me s.

* fixed word typos.

* updated propery custom-words.txt

* prettyfied and removed some of the example files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuchandy anuchandy anuchandy approved these changes

@samedder samedder samedder approved these changes

Assignees

@anuchandy anuchandy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeffj6123 @AutorestCI @azuresdkci @anuchandy @samedder