Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json format by prettier #7638

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Conversation

PhoenixHe-NV
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 25, 2019

In Testing, Please Ignore

[Logs] (Generated from 771a3b2, Iteration 2)

Failed Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Oct 25, 2019

Automation for azure-sdk-for-go

This PR contains more than 3 context, SDK generation is not enabled. Contexts found:

  • attestation/resource-manager
  • reservations/resource-manager
  • eventgrid/data-plane
  • cognitiveservices/data-plane/Personalizer
  • consumption/resource-manager
  • cognitiveservices/data-plane/LUIS/Authoring
  • eventgrid/resource-manager
  • iotcentral/data-plane
  • hybridcompute/resource-manager
  • cognitiveservices/resource-manager
  • customproviders/resource-manager
  • cognitiveservices/data-plane/QnAMaker
  • cdn/resource-manager
  • network/resource-manager
  • compute/resource-manager
  • web/resource-manager
  • appplatform/resource-manager
  • datashare/resource-manager
  • resources/resource-manager
  • vmwarecloudsimple/resource-manager
  • cost-management/resource-manager
  • cognitiveservices/data-plane/FormRecognizer

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@PhoenixHe-NV
Copy link
Contributor Author

Initialization for #7637

"displayText": "alaska airlines",
"query": "alaska airlines",
"searchKind": "WebSearch"
},
{
"_type": "SearchAction",
"url": "https:\/\/www.bing.com\/search?q=aol&FORM=USBAPI",
"url": "https://www.bing.com/search?q=aol&FORM=USBAPI",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this will not impact doc generation, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it won't, as the semantic meaning of the string keeps unchanged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But is this what the service is returning, or is it changing what the actual response looks like?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will not change the response as it's the same string after parsing.

@yungezz
Copy link
Member

yungezz commented Oct 29, 2019

hi @NullMDR is this PR ready to merge?

@PhoenixHe-NV
Copy link
Contributor Author

@yungezz I'll generate again from the latest master, then it's ready.

@PhoenixHe-NV
Copy link
Contributor Author

@yungezz It's ready.

@yungezz yungezz merged commit 14543d3 into Azure:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants