-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update databaseVulnerabilityAssessments.json #7560
Conversation
Updated storageContainerSasKey explaining that both read and write access is required in the SAS token.
In Testing, Please Ignore[Logs] (Generated from 25183e5, Iteration 1).NET: test-repo-billy/azure-sdk-for-net [Logs]
Python: test-repo-billy/azure-sdk-for-python [Logs]
Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
|
Can one of the admins verify this patch? |
Automation for azure-sdk-for-goThe initial PR has been merged into your service PR: |
@michaelelleby, can you fix the CI check failures? |
@qiaozha , can you have a look at JS SDK failures and give suggestions for the fix? @michaelelleby , can you look at the CI check failures and fix them? |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@michaelelleby hi, it seems that you have several files defined "storageContainerSasKey", but you've only changed the description of this file specification/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/databaseVulnerabilityAssessments.json which cause inconsistency. you may change the description of other files that have "storageContainerSasKey" definition to the same as this file. |
@michaelelleby, can you please follow the guidelines @qiaozha provided to fix the failures? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelelleby , please follow Qiaoqiao's guidance to fix the check failures, thanks.
Automation for azure-sdk-for-pythonThe initial PR has been merged into your service PR: |
* Update databaseVulnerabilityAssessments.json Updated storageContainerSasKey explaining that both read and write access is required in the SAS token. * Fixed documentation for storageAccountAccessKey parameter in SQL templates
Updated storageContainerSasKey explaining that both read and write access is required in the SAS token.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.