Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update databaseVulnerabilityAssessments.json #7560

Merged
merged 2 commits into from
Nov 11, 2019
Merged

Update databaseVulnerabilityAssessments.json #7560

merged 2 commits into from
Nov 11, 2019

Conversation

michaelelleby
Copy link
Contributor

Updated storageContainerSasKey explaining that both read and write access is required in the SAS token.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • [N/A] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • [N/A] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • [N/A] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@michaelelleby
Update databaseVulnerabilityAssessments.json
25183e5 
Updated storageContainerSasKey explaining that both read and write access is required in the SAS token.
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 21, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from 25183e5, Iteration 1)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs]
  • No packages generated.
Failed Python: test-repo-billy/azure-sdk-for-python [Logs]
  • No packages generated.
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Succeeded Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs]
  • No packages generated.
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Oct 21, 2019
Closed
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Oct 21, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Oct 21, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#6294

@raych1
Copy link
Member

raych1 commented Oct 22, 2019

@michaelelleby, can you fix the CI check failures?

@raych1
Copy link
Member

raych1 commented Oct 24, 2019

@qiaozha , can you have a look at JS SDK failures and give suggestions for the fix? @michaelelleby , can you look at the CI check failures and fix them?

@qiaozha
Copy link
Member

qiaozha commented Oct 25, 2019

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@qiaozha
Copy link
Member

qiaozha commented Oct 28, 2019

@michaelelleby hi, it seems that you have several files defined "storageContainerSasKey", but you've only changed the description of this file specification/sql/resource-manager/Microsoft.Sql/preview/2017-03-01-preview/databaseVulnerabilityAssessments.json which cause inconsistency. you may change the description of other files that have "storageContainerSasKey" definition to the same as this file.
Also, duplicate definitions may cause SDK generation failure.

@raych1
Copy link
Member

raych1 commented Nov 1, 2019

@michaelelleby, can you please follow the guidelines @qiaozha provided to fix the failures?

raych1
raych1 requested changes Nov 6, 2019
View reviewed changes
Copy link
Member

@raych1 raych1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelelleby , please follow Qiaoqiao's guidance to fix the check failures, thanks.

@AutorestCI AutorestCI mentioned this pull request Nov 6, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Nov 6, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#8425

@AutorestCI AutorestCI mentioned this pull request Nov 6, 2019
Merged
@raych1 raych1 self-requested a review November 11, 2019 00:59
@raych1 raych1 merged commit 272b064 into Azure:master Nov 11, 2019
solhaile pushed a commit to solhaile/azure-rest-api-specs that referenced this pull request Nov 13, 2019
@michaelelleby
Update databaseVulnerabilityAssessments.json (Azure#7560)
da53d8f 
* Update databaseVulnerabilityAssessments.json

Updated storageContainerSasKey explaining that both read and write access is required in the SAS token.

* Fixed documentation for storageAccountAccessKey parameter in SQL templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredmoo jaredmoo jaredmoo approved these changes

@raych1 raych1 raych1 approved these changes

Assignees

@raych1 raych1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@michaelelleby @azuresdkci @AutorestCI @raych1 @qiaozha @jaredmoo