Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdministratorName parameter should take value which is defined in enum #7377

Merged
merged 9 commits into from
Nov 7, 2019
Merged

AdministratorName parameter should take value which is defined in enum #7377

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b0dae31
AdministratorName parameter should take constant value defined in enum
SanjaMalesevic Oct 1, 2019
e0829d2
Merge pull request #1 from Azure/master
SanjaMalesevic Oct 1, 2019
7555722
Merge branch 'master' into changeJsonForADAdminoOnMI
SanjaMalesevic Oct 1, 2019
32a1325
Code review fixes
SanjaMalesevic Nov 6, 2019
f20be64
Code review fixes
SanjaMalesevic Nov 6, 2019
d8f256c
Fix tabs and spaces
SanjaMalesevic Nov 6, 2019
31de475
Fix example with get
SanjaMalesevic Nov 6, 2019
57fa02d
revert example with get
SanjaMalesevic Nov 6, 2019
e765474
Fix examples
SanjaMalesevic Nov 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions ...ource-manager/Microsoft.Sql/preview/2017-03-01-preview/managedInstanceAdministrators.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@
"in": "path",
"description": "The administrator name.",
"required": true,
"type": "string"
"type": "string",
"enum": [
SanjaMalesevic marked this conversation as resolved.
Show resolved Hide resolved
"ActiveDirectory"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the change from string to enum result in a breaking change for some SDKs?

Copy link
Contributor Author

@SanjaMalesevic SanjaMalesevic Oct 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, there is a difference in number of parameters for create/modify/delete methods in .NET and Python clients between MI and SQL DB. So, this change is made to aligned MI clients with SQL DB (they need to be auto-generated again based on updated json).
Jared has noticed in PR Azure/azure-cli#10446 that there is parameter AdministratorName in method create_or_update which always takes the same value and that this parameter doesn't exist in clients for sql db.
I am not sure, but I think that this is a breaking change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is a breaking change. However this is a new API and therefore right now is the time that break will have minimal impact. Also this change brings managed instance admin API into sync with server admin API.

]
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -121,7 +124,10 @@
"in": "path",
"description": "The requested administrator name.",
"required": true,
"type": "string"
"type": "string",
"enum": [
"ActiveDirectory"
]
SanjaMalesevic marked this conversation as resolved.
Show resolved Hide resolved
},
{
"name": "parameters",
Expand Down Expand Up @@ -187,7 +193,10 @@
"in": "path",
"description": "The administrator name.",
"required": true,
"type": "string"
"type": "string",
"enum": [
"ActiveDirectory"
]
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down