[Data Factory] data flow + debug session API swagger #7088

jackmagic313 · 2019-08-30T19:32:31Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-08-30T19:32:34Z

In Testing, Please Ignore

[Logs] (Generated from 3ff8cd5, Iteration 16)

.NET: test-repo-billy/azure-sdk-for-net [Logs]

Package generation in progress.

Python: test-repo-billy/azure-sdk-for-python [Logs]

Package generation in progress.

Java: test-repo-billy/azure-sdk-for-java [Logs]

Package generation in progress.

Go: test-repo-billy/azure-sdk-for-go [Logs]

Package generation in progress.

JavaScript: test-repo-billy/azure-sdk-for-js [Logs]

Package generation in progress.

AutorestCI · 2019-08-30T19:35:35Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7315

azuresdkci · 2019-08-30T19:37:21Z

Can one of the admins verify this patch?

jackmagic313 · 2019-08-30T19:41:08Z

Will have an API review with ARM team first

AutorestCI · 2019-08-30T20:02:18Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5865

majastrz · 2019-09-17T21:31:40Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+          },
+          "304": {
+            "description": "Not modified."
+          },


As per the RPC, GETs should always return 200 (unless there's a failure)

Got it, it's actually the same pattern as all other sub resources we have. I will remove it here and change our RP at the same time

Sounds good.

In reply to: 325400189 [](ancestors = 325400189)

@majastrz 304 is for "If-None-Match" header.

{

| "name": "If-None-Match",
| "in": "header",
| "required": false,
| "type": "string",
| "description": "ETag of the dataset entity. Should only be specified for get. If the ETag matches the existing entity tag, or if * was provided, then no content will be returned."
| }

majastrz · 2019-09-17T21:34:48Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+        }
+      }
+    },
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataFactory/factories/{factoryName}/createDataFlowDebugSession": {


createDataFlowDebugSession [](start = 128, length = 26)

You have several POST actions that perform various lifecycle operations (create, delete, query) on data flow debug sessions. Heavily relying on POST is generally an anti-pattern in ARM.

Have you considered modeling dataFlowDebugSessions as a proxy resource? If yes, why did you choose the POST approach? #Closed

We don't want to treat dataFlowDebugSession as a proxy resource since it's a just a temporary session which users can perform some debugging actions. "Create", "AddDataFlow" and "Execute" needs to be POST actions though I can modify query to be get if ARM prefers that way. #Closed

It seems that the sessionId is assigned by the backend, so it'll have to be POST.

In reply to: 325409815 [](ancestors = 325409815)

yep, reverted to post

majastrz

I added a couple of comments. Can you take a look?

jackmagic313 · 2019-09-17T22:56:25Z

I added a couple of comments. Can you take a look?

Could you help to take a look again? Thanks!

majastrz · 2019-09-18T00:03:48Z

...cation/datafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/datafactory.json

+        },
+        "x-ms-pageable": {
+          "nextLinkName": "nextLink"
+        }


@anuchandy, will this work with the generated SDK? Normally, this is reserved for GETs but this is a POST.

majastrz

I added a comment. Please confirm with SDK reviewer to make sure POST will work with nextLink. Otherwise, it looks good from ARM side.

anuchandy · 2019-09-23T16:05:27Z

@jackmagic313 the codegen exceptions are getting thrown from autorest.common, I'm checking with core owner (you're in the loop).

remove unnecessary description

169679c

azuresdkci assigned anuchandy Aug 30, 2019

azuresdkci requested a review from anuchandy August 30, 2019 19:33

AutorestCI mentioned this pull request Aug 30, 2019

[AutoPR datafactory/resource-manager] [Don't Review for now][Data Factory] data flow + debug session API swagger Azure/azure-sdk-for-python#7022

Closed

fix format

7c36b9f

yungezz added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 2, 2019

jackmagic313 added 6 commits September 5, 2019 13:23

add examples for data flow apis

3d5a79e

Improvment from team review

c6c99d2

fix encoding

bf0a08b

fix wrong reference

a39fe22

fix lint

298a476

remove unnecessary api

102da7d

jackmagic313 added 3 commits September 17, 2019 13:23

fix more for lint

1b8779e

fix more for lint

3c2a579

fix model validation

72e34a8

majastrz reviewed Sep 17, 2019

View reviewed changes

majastrz added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 17, 2019

majastrz reviewed Sep 17, 2019

View reviewed changes

jackmagic313 changed the title ~~[Don't Review for now][Data Factory] data flow + debug session API swagger~~ [Data Factory] data flow + debug session API swagger Sep 17, 2019

address feedback

8487058

fix example

bfd0df8

majastrz reviewed Sep 18, 2019

View reviewed changes

majastrz approved these changes Sep 18, 2019

View reviewed changes

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 18, 2019

address feedback

052024e

remove additional property for data flow enitty

3ff8cd5

anuchandy approved these changes Sep 24, 2019

View reviewed changes

anuchandy merged commit dd5d112 into Azure:master Sep 24, 2019

AutorestCI mentioned this pull request Sep 24, 2019

[AutoPR datafactory/resource-manager] [Data Factory] data flow + debug session API swagger Azure/azure-sdk-for-go#5864

Merged

jackmagic313 mentioned this pull request Sep 26, 2019

[Data Factory]Add support for data flow Azure/azure-sdk-for-net#7765

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Data Factory] data flow + debug session API swagger #7088

[Data Factory] data flow + debug session API swagger #7088

jackmagic313 commented Aug 30, 2019

openapi-sdkautomation bot commented Aug 30, 2019 •

edited

Loading

AutorestCI commented Aug 30, 2019 •

edited

Loading

azuresdkci commented Aug 30, 2019

jackmagic313 commented Aug 30, 2019

AutorestCI commented Aug 30, 2019 •

edited

Loading

majastrz Sep 17, 2019

jackmagic313 Sep 17, 2019

majastrz Sep 17, 2019

hvermis Sep 25, 2019

majastrz Sep 17, 2019 •

edited

Loading

jackmagic313 Sep 17, 2019 •

edited by majastrz

Loading

majastrz Sep 18, 2019

jackmagic313 Sep 18, 2019

majastrz left a comment

jackmagic313 commented Sep 17, 2019

majastrz Sep 18, 2019

majastrz left a comment

anuchandy commented Sep 23, 2019

[Data Factory] data flow + debug session API swagger #7088

[Data Factory] data flow + debug session API swagger #7088

Conversation

jackmagic313 commented Aug 30, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Aug 30, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from 3ff8cd5, Iteration 16)

AutorestCI commented Aug 30, 2019 • edited Loading

Automation for azure-sdk-for-python

azuresdkci commented Aug 30, 2019

jackmagic313 commented Aug 30, 2019

AutorestCI commented Aug 30, 2019 • edited Loading

Automation for azure-sdk-for-go

majastrz Sep 17, 2019

Choose a reason for hiding this comment

jackmagic313 Sep 17, 2019

Choose a reason for hiding this comment

majastrz Sep 17, 2019

Choose a reason for hiding this comment

hvermis Sep 25, 2019

Choose a reason for hiding this comment

{

majastrz Sep 17, 2019 • edited Loading

Choose a reason for hiding this comment

jackmagic313 Sep 17, 2019 • edited by majastrz Loading

Choose a reason for hiding this comment

majastrz Sep 18, 2019

Choose a reason for hiding this comment

jackmagic313 Sep 18, 2019

Choose a reason for hiding this comment

majastrz left a comment

Choose a reason for hiding this comment

jackmagic313 commented Sep 17, 2019

majastrz Sep 18, 2019

Choose a reason for hiding this comment

majastrz left a comment

Choose a reason for hiding this comment

anuchandy commented Sep 23, 2019

openapi-sdkautomation bot commented Aug 30, 2019 •

edited

Loading

AutorestCI commented Aug 30, 2019 •

edited

Loading

AutorestCI commented Aug 30, 2019 •

edited

Loading

majastrz Sep 17, 2019 •

edited

Loading

jackmagic313 Sep 17, 2019 •

edited by majastrz

Loading