Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Readme file order and versioning. #7033

Merged
merged 3 commits into from
Aug 27, 2019

Conversation

rileymckenna
Copy link
Contributor

@rileymckenna rileymckenna commented Aug 23, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 23, 2019

@AutorestCI
Copy link

AutorestCI commented Aug 23, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6923

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Aug 23, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5617

@rileymckenna
Copy link
Contributor Author

Readme file was not properly generating SDK files due the ordering and versioning. I have updated the readme to correct this error on my behalf.

Can this PR be a sprint candidate?

@weidongxu-microsoft
Copy link
Member

weidongxu-microsoft commented Aug 26, 2019

@rileymckenna It appears that there is no meaningful change to the 2 json files. Maybe you can unstage them?

@rileymckenna
Copy link
Contributor Author

@weidongxu-microsoft i removed the white space changes in the json files. Can you merge?

@weidongxu-microsoft weidongxu-microsoft merged commit 92fe629 into Azure:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants