Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API version in VMSS' specs #7008

Merged
merged 2 commits into from
Aug 22, 2019

Conversation

anton-evseev
Copy link
Contributor

Applying changes from #6692 and #6916 to release branch

VMSS specs have their own API version independent from the rest of Network specs. This PR updates it to the latest one.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Aug 21, 2019

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpe8dmcwqd/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpe8dmcwqd/sdk/sdk', '--use=@microsoft.azure/autorest.python@4.0.70', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4390/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4390)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[30446:0x4361cc0]    97217 ms: Mark-sweep 1380.9 (1426.1) -> 1380.9 (1426.6) MB, 2329.5 / 0.0 ms  (average mu = 0.100, current mu = 0.001) allocation failure GC in old space requested
[30446:0x4361cc0]    98911 ms: Mark-sweep 1381.2 (1426.6) -> 1381.2 (1427.1) MB, 1691.6 / 0.0 ms  (average mu = 0.061, current mu = 0.001) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0x46517e5be1d]
Security context: 0x2cbcbcf1e6e9 <JSObject>
    1: newScalar [0x2613727ab421] [/node_modules/yaml-ast-parser/dist/src/yamlAST.js:~38] [pc=0x465184bffd6](this=0x19a29852c739 <Object map = 0x373c9c84c551>,v=0x1595e81026f1 <undefined>)
    2: arguments adaptor frame: 0->1
    3: readDoubleQuotedScalar(aka readDoubleQuotedScalar) [0x2613727ab361] [/node_modules/yaml-ast-parser/dist/src/loader.js:~530] [pc=...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0x46517e5be1d

@AutorestCI
Copy link

AutorestCI commented Aug 21, 2019

Automation for azure-sdk-for-go

A PR has been created for you:
Azure/azure-sdk-for-go#5573

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@yungezz
Copy link
Member

yungezz commented Aug 21, 2019

@number123, network validation failed.

@yungezz yungezz self-assigned this Aug 21, 2019
@anton-evseev
Copy link
Contributor Author

All fixed, CI's green
@yungezz please merge

@yungezz
Copy link
Member

yungezz commented Aug 22, 2019

hi @number123, this is a breaking change. Just to double confirm with you and @MikhailTryakhov

@anton-evseev
Copy link
Contributor Author

@yungezz No SDK has been published based on 2019-07-01, I'm not sure how it would be a breaking change

@yungezz yungezz merged commit 1b8591d into Azure:network-august-release Aug 22, 2019
@yungezz
Copy link
Member

yungezz commented Aug 22, 2019

@yungezz No SDK has been published based on 2019-07-01, I'm not sure how it would be a breaking change

got it. merged.

@anton-evseev anton-evseev deleted the vmss-api-version branch August 22, 2019 16:41
anton-evseev added a commit to anton-evseev/azure-rest-api-specs that referenced this pull request Sep 13, 2019
sarangan12 pushed a commit that referenced this pull request Sep 13, 2019
* Adds base for updating Microsoft.Network from version stable/2019-06-01 to version 2019-07-01

* Updates readme

* Updates API version in new specs and examples

* Update API version in VMSS' specs (#7008)

* Add reference to existing base definition & fix errors in descriptions of Network's provisioningState property (#7026)

* Improve Network's descriptions (#6974)

* New Skus and Generations for VirtualNetworkVpnGateways (#7089)

* New Skus and generations for VirtualNetwork VpnGateways

* Minor Typo fix

* update avocado@0.6.0 (#7054)

* Lock typescript version to fix compile error (#7068)

* Fix description for vpnGatewayGeneration.

* Add VirtualRouter top level resource Identity under Microsoft.Network/ExpressRoutePort and MacSecConfig under Microsoft.Network/ExpressRouteLink (#7005)

* Fixed required properties in TrafficAnalyticsProperties: networkWatcehr.json (#7080)

* Added traffic selector policy definition to virtualNetworkGateway.json (#7066)

* Support for changes in ConnectionMonitor API (#7075)

* Updating Network Config Diagnostics API desc (#7117)

* Added priority field in the request routing rule (#7131)

* Added priority field in the request routing rule

* Added min and max

* Minor

* Added new owner to Azure Networking (#7145)

added number213 to Az NW

* Add Mssql value to Application Rule Type enum (#7169)

* Add privateLinkConnectionProperties to network interface. (#7189)

* Add privateLinkConnectionProperties to network interface on 2019-07-01.

* Small changes for descriptions in the property.

* make the new property to be read-only.

* Brooklyn Gateway Packet Capture feature (#7151)

* PacketCaptureOperationforVPNGateways

* Update virtualNetworkGateway.json

* Update VirtualNetworkGatewayConnectionStopPacketCapture.json

* Update VirtualNetworkGatewayStopPacketCapture.json

* Update VirtualNetworkGatewayStopPacketCapture.json

* Update VirtualNetworkGatewayConnectionStopPacketCapture.json

* Update VirtualNetworkGatewayConnectionStartPacketCapture.json

* Update VirtualNetworkGatewayStartPacketCapture.json

* Update virtualNetworkGateway.json

* fixing examples

* fixing virtualNetworkGateway.json

* fixing params

* fixing path params

* response body

* example errors

* example errors

* example errors

* filterdata

* Update virtualNetworkGateway.json

* fixing Comments

* Fixing ARM Comments

* Remove duplicate definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants