Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding non mandatory fields in ProtectedItem and AzureVmWorkloadProte… #6818

Merged
merged 6 commits into from
Aug 15, 2019
Merged

Adding non mandatory fields in ProtectedItem and AzureVmWorkloadProte… #6818

merged 6 commits into from
Aug 15, 2019

Conversation

SanjayHukumRana
Copy link
Contributor

…ctionPolicy

Adding additional fields for ProtectedItem related to soft delete feature ; description of each field is in the fields.
In AzureVmWorkloadProtectionPolicy adding another field for fixup of policy

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@SanjayHukumRana
Adding non mandatory fields in ProtectedItem and AzureVmWorkloadProte…
142bb9d 
…ctionPolicy

Adding additional fields for ProtectedItem related to soft delete feature ; description of each field is in the fields.
In AzureVmWorkloadProtectionPolicy adding another field for fixup of policy
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 31, 2019 •
edited
Loading

In Testing, Please Ignore

[Logs] (Generated from d0e6593, Iteration 6)

Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Failed JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@msftclas
Copy link

msftclas commented Jul 31, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jul 31, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 31, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6799

@AutorestCI AutorestCI mentioned this pull request Jul 31, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jul 31, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5527

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 31, 2019
Closed
@azuresdkci azuresdkci requested a review from lirenhe July 31, 2019 12:27
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jul 31, 2019
Closed
@SanjayHukumRana
Removing redundant fields from child class MabFileFolderProtectedItem
6a01ab4 
Since these fields are added in base class ProtectedItem , removing them from MabFileFolderProtectedItem
@SanjayHukumRana
Rehydrate removal from description
ad48ba5 
Rehydrated is not in dictionary of swagger valiation  and thus removed from description
@lirenhe lirenhe added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 2, 2019
ravbhatnagar
ravbhatnagar reviewed Aug 7, 2019
View reviewed changes
Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SanjayHukumRana - few comments.

...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2016-12-01/bms.json Show resolved Hide resolved
...ecoveryservicesbackup/resource-manager/Microsoft.RecoveryServices/stable/2017-07-01/bms.json Outdated Show resolved Hide resolved
@ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 7, 2019
@SanjayHukumRana
Updating the Field for deferred deleted Time
bd73c95 
Updating the new field for deleted time in ProtectedItem while keeping the syncTime for MABfileFolderProtectedItem
@SanjayHukumRana
Undo change to AzureVmWorkloadProtectionPolicy
ac50969 
Removed the change to AzureVmWorkloadProtectionPolicy as this requires new api version
@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 12, 2019
@ravbhatnagar
Copy link
Contributor

Signing off from ARM side.

This was referenced Aug 13, 2019
Merged
Closed
@SanjayHukumRana
Fixing camelcasing
d0e6593 
Camelcasing of  isDeferredDeleteScheduleUpcoming field
@adit-t adit-t mentioned this pull request Aug 14, 2019
Closed
@yungezz yungezz merged commit 61552db into Azure:master Aug 15, 2019
@SanjayHukumRana SanjayHukumRana mentioned this pull request Aug 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adit-t adit-t adit-t left review comments

@ravbhatnagar ravbhatnagar ravbhatnagar left review comments

@lirenhe lirenhe lirenhe approved these changes

Assignees

@lirenhe lirenhe

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review potential-sdk-breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SanjayHukumRana @msftclas @azuresdkci @AutorestCI @ravbhatnagar @adit-t @lirenhe @yungezz