Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug fix] Remove read-only constraint for management policy, and change properties types from integer to number #6551

Merged
merged 5 commits into from
Jul 17, 2019
Merged

[Bug fix] Remove read-only constraint for management policy, and change properties types from integer to number #6551

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00d9e1b
[Bug fix] Remove read-only constraint for management policy
zfchen95 Jul 3, 2019
de1ac16
[Bug fix] Change daysAfterCreationGreaterThan and daysAfterModificati…
zfchen95 Jul 5, 2019
0e6f149
change type to number
zfchen95 Jul 11, 2019
870609e
Modify description, remove integer
zfchen95 Jul 11, 2019
ff223c3
Fix existing build errors in Storage swagger
zfchen95 Jul 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions specification/storage/resource-manager/Microsoft.Storage/stable/2019-04-01/storage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2160,7 +2160,6 @@
"properties": {
"$ref": "#/definitions/ManagementPolicyProperties",
"x-ms-client-flatten": true,
"readOnly": true,
"description": "Returns the Storage Account Data Policies Rules."
}
},
Expand Down Expand Up @@ -2317,8 +2316,8 @@
"DateAfterModification": {
"properties": {
"daysAfterModificationGreaterThan": {
"type": "integer",
"minimum": 0,
"type": "float",
zfchen95 marked this conversation as resolved.
Show resolved Hide resolved
"minimum": 0.0,
"description": "Integer value indicating the age in days after last modification"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description is still calling it an integer

Copy link
Contributor Author

@zfchen95 zfchen95 Jul 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the server, the property is defined as float type for testing purpose. But in the real use case, we expect the input to be an integer-like number. I added a constraint in the update 0e6f149, which will only allow number that is the multiple of 1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but since it's no longer an actual int, the docs shouldn't call it that. Maybe just change "Integer value" to "Value"

Copy link
Contributor Author

@zfchen95 zfchen95 Jul 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed "Integer value" to "Value" 870609e

}
},
Expand All @@ -2330,8 +2329,8 @@
"DateAfterCreation": {
"properties": {
"daysAfterCreationGreaterThan": {
"type": "integer",
"minimum": 0,
"type": "float",
"minimum": 0.0,
"description": "Integer value indicating the age in days after creation"
}
},
Expand Down