Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to the JIT API for Firewall Support #6426

Merged
merged 3 commits into from
Jul 1, 2019
Merged

Changes to the JIT API for Firewall Support #6426

merged 3 commits into from
Jul 1, 2019

Conversation

avamitay
Copy link
Contributor

@avamitay avamitay commented Jun 24, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 24, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 77db60c)

Pending Go: Azure/azure-sdk-for-go
  • Package generation pending.
Pending Python: Azure/azure-sdk-for-python
  • Package generation pending.
Pending JavaScript: Azure/azure-sdk-for-js
  • Package generation pending.

@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5709

@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 24, 2019 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#5176

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

This was referenced Jun 24, 2019
Merged
Closed
@NelsonDaniel NelsonDaniel added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 24, 2019
NelsonDaniel
NelsonDaniel approved these changes Jun 28, 2019
View reviewed changes
Copy link

@NelsonDaniel NelsonDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Will wait for ARM feedback to merge

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 1, 2019
@ravbhatnagar
Copy link
Contributor

preview API. signing off from ARM side.

@NelsonDaniel NelsonDaniel merged commit 40049a4 into Azure:master Jul 1, 2019
@AutorestCI AutorestCI mentioned this pull request Jul 1, 2019
Merged
celikcigdem pushed a commit to celikcigdem/azure-rest-api-specs that referenced this pull request Jul 17, 2019
@avamitay @celikcigdem
Changes to the JIT API for Firewall Support (Azure#6426)
0fb776b 
* Changes to the JIT API for Firewall Support

* Update jitNetworkAccessPolicies.json

* Update jitNetworkAccessPolicies.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelsonDaniel NelsonDaniel NelsonDaniel approved these changes

Assignees

@NelsonDaniel NelsonDaniel

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@avamitay @AutorestCI @azuresdkci @ravbhatnagar @NelsonDaniel