Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SRP] Default value change for account property supportsHttpsTrafficOnly #6243

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

zfchen95
Copy link
Contributor

@zfchen95 zfchen95 commented Jun 6, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@zfchen95 zfchen95 requested a review from stankovski as a code owner June 6, 2019 17:30
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jun 6, 2019

SDK Automation [Logs] (Generated from 552816c)

Failed Python: Azure/azure-sdk-for-python [Logs] [Diff]
Succeeded Java: Azure/azure-sdk-for-java [Logs] [Diff]
Succeeded Go: Azure/azure-sdk-for-go [Logs] [Diff]
Succeeded JavaScript: Azure/azure-sdk-for-js [Logs] [Diff]
Failed Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#3519

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmp7ul9_bfw/rest/specification/storage/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmp7dbeo5mv']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4373/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5713

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2556

@AutorestCI
Copy link

AutorestCI commented Jun 6, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4965

@zfchen95
Copy link
Contributor Author

zfchen95 commented Jun 6, 2019

Sign off by ARM in private repo => https://github.com/Azure/azure-rest-api-specs-pr/pull/775

@kpajdzik kpajdzik self-requested a review June 6, 2019 17:42
@kpajdzik kpajdzik added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 6, 2019
@kpajdzik kpajdzik merged commit 2611ed6 into Azure:master Jun 6, 2019
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
* [AutoSync] a5345b5 create a new api version 2022-01-01-preview copy from previous version

* [AutoSync] 8ec3267 update new api version

* [AutoSync] 5deb203 remove required properties from UserAssignedIdentity

* [AutoSync] dd80ae0 add 200 to validateLinker

* [AutoSync] 6a091e0 fix spell error

* [AutoSync] ecf1ae2 format with prettier

* [AutoSync] 8aa635d Add x-ms-identifiers to servicelinker/resource-manager

* [AutoSync] 0466582 Merge branch 'qianwens/apiv2-3' of https://msazure.visualstudio.com/One/_git/ServiceLinker into qianwens/apiv2-3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants