Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec for LineOfCredit API and other corrections #6054

Merged
merged 32 commits into from
May 30, 2019
Merged

Spec for LineOfCredit API and other corrections #6054

merged 32 commits into from
May 30, 2019

Conversation

asarkar84
Copy link
Contributor

@asarkar84 asarkar84 commented May 21, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

asarkar84 and others added 23 commits April 3, 2019 16:40
@asarkar84
Added specs for Agreements API in version 2018-11-01-preview
2a236eb 
Added specs for Agreements API in version 2018-11-01-preview
@asarkar84
Updated as per naming convension
a33bee2 
Updated as per naming convension
@asarkar84
Merge remote-tracking branch 'upstream/master'
d490370
@asarkar84
Merge remote-tracking branch 'upstream/master'
f7a772d
@asarkar84
Corrected specs and examples for BillingRP
04c5304 
Corrected specs and examples for BillingRP
@asarkar84
Fixed the errors
bbf0f75 
Fixed the errors
@asarkar84
Fixing errors in spec
91060fe 
Fixing errors in spec
@asarkar84
Updated examples
a16aba3 
Updated examples
Incorporated review comments
bb7a445 
Incorporated review comments
Incorporated review comments
281784f
Incorporated review comments
9a957ac 
Incorporated review comments
@asarkar84
Merge remote-tracking branch 'upstream/master'
f1a1071
@asarkar84
Updated the operation id for Billing spec
ee0beac 
Updated the operation id for Billing spec
@asarkar84
Merge remote-tracking branch 'upstream/master'
f7a7ff9
@asarkar84
Incorporated review comments
2b94171 
Incorporated review comments
@asarkar84
Incorporated review comments
1b0eb1e 
Incorporated review comments
@asarkar84
Fixed the errors
86c8bcf 
Fixed the errors
@asarkar84
Added multiple inputs
b73f7f6 
Added multiple inputs
@asarkar84
Fixed build errors
276a50f 
Fixed build errors
@asarkar84
Incorporated review comments
9fb11a5 
Incorporated review comments
@asarkar84
Incorporated review comments
861de2b
@asarkar84
Merge remote-tracking branch 'upstream/master'
99d6a72
@asarkar84
Spec for LineOfCredit API and other corrections
7dc3649 
Spec for LineOfCredit API and other corrections
@asarkar84 asarkar84 requested a review from wilcobmsft as a code owner May 21, 2019 22:18
@AutorestCI
Copy link

AutorestCI commented May 21, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#2474

@AutorestCI AutorestCI mentioned this pull request May 21, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented May 21, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5564

@azuresdkci azuresdkci requested a review from shahabhijeet May 21, 2019 22:19
@AutorestCI AutorestCI mentioned this pull request May 21, 2019
Closed
@asarkar84
Copy link
Contributor Author

@shahabhijeet Regarding breaking changes - PUT to PATCH was a swagger mistake, our code support PATCH so I just corrected it. We may still not have any actual API usage since we have not seen any failures due to customer passing the wrong verb.

@ryansbenson ryansbenson added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 24, 2019
@asarkar84
Incorporated review comments
80551f2 
Incorporated review comments
This was referenced May 24, 2019
Closed
Merged
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 24, 2019
@adxsdknet
.NET SDK Resource Provider:'Billing'
f880b77 
REST Spec PR 'Azure/azure-rest-api-specs#6054'
REST Spec PR Author 'asarkar84'
REST Spec PR Last commit
@asarkar84
Incorporated review comments
78b382b 
Incorporated review comments
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 28, 2019
@adxsdknet
.NET SDK Resource Provider:'Billing'
0a1a77d 
REST Spec PR 'Azure/azure-rest-api-specs#6054'
REST Spec PR Author 'asarkar84'
REST Spec PR Last commit
@asarkar84
Updated the increase api
0c5738c 
Updated the increase api
adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request May 28, 2019
@adxsdknet
.NET SDK Resource Provider:'Billing'
580a340 
REST Spec PR 'Azure/azure-rest-api-specs#6054'
REST Spec PR Author 'asarkar84'
REST Spec PR Last commit
@asarkar84
Incorporated review comments
0c6a6c6 
Incorporated review comments
This was referenced May 30, 2019
Closed
Closed
@sanjaiganesh sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 30, 2019
@shahabhijeet
Copy link
Member

Please fix all the error that you see in the required jobs (public.rest-api-specs)

This was referenced May 30, 2019
Merged
Merged
@asarkar84
Copy link
Contributor Author

@shahabhijeet All errors are fixed.

@shahabhijeet shahabhijeet merged commit 1e497e5 into Azure:master May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryansbenson ryansbenson ryansbenson left review comments

@sanjaiganesh sanjaiganesh sanjaiganesh left review comments

@shahabhijeet shahabhijeet shahabhijeet requested changes

@wilcobmsft wilcobmsft wilcobmsft approved these changes

Assignees

@shahabhijeet shahabhijeet

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@asarkar84 @AutorestCI @azuresdkci @adxsdknet @shahabhijeet @sanjaiganesh @wilcobmsft @ryansbenson @msft-adrianma