New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update package.json (Avocado and OAD) #5467

Merged

veronicagg merged 1 commit into master from sergey-shandar-patch-4

Mar 28, 2019

Contributor

sergey-shandar commented Mar 25, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.


          Update package.json

5290bbe

AutorestCI commented Mar 25, 2019 •

edited

Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

AutorestCI commented Mar 25, 2019 •

edited

Loading

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

AutorestCI commented Mar 25, 2019 •

edited

Loading

Automation for azure-sdk-for-js

Unable to detect any generation context from this PR.

AutorestCI commented Mar 25, 2019 •

edited

Loading

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

AutorestCI commented Mar 25, 2019 •

edited

Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

sergey-shandar changed the title ~~Update package.json~~ Update package.json (Avocado and OAD)

azuresdkci assigned veronicagg

azuresdkci requested a review from veronicagg

March 25, 2019 20:34

Contributor

azuresdkci commented Mar 25, 2019

Can one of the admins verify this patch?

veronicagg approved these changes

View reviewed changes

Contributor

veronicagg left a comment

still approving but asked a question inline. thanks!

package.json

@@ @@ -10,8 +10,8 @@ @@
                 "description": "Tests for Azure REST API Specifications",
                 "license": "MIT",
                 "devDependencies": {
-                  "@azure/avocado": "^0.2.0",
-                  "@azure/oad": "^0.2.1",
+                  "@azure/avocado": "^0.2.2",

Contributor

veronicagg Mar 25, 2019

given the update is on the last digit for avocado, shouldn't our CI be picking up the latest published? why is this necessary?

veronicagg merged commit a504178 into master

vladbarosan deleted the sergey-shandar-patch-4 branch

March 28, 2019 22:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet