Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] Add a new return code to Create Container #5434

Merged
merged 1 commit into from
Mar 21, 2019
Merged

[Storage] Add a new return code to Create Container #5434

merged 1 commit into from
Mar 21, 2019

Conversation

blueww
Copy link
Member

@blueww blueww commented Mar 20, 2019 •
edited
Loading

If a container already exist, create it again will get status code 200 from server.
(If container create successfully, return 201)
Add this to swagger

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI AutorestCI mentioned this pull request Mar 20, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1705

@AutorestCI AutorestCI mentioned this pull request Mar 20, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4585

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Mar 20, 2019
Closed
@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#5019

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Mar 20, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 20, 2019
@adxsdknet
.NET SDK Resource Provider:'Storage'
47ee709 
REST Spec PR 'Azure/azure-rest-api-specs#5434'
REST Spec PR Author 'blueww'
REST Spec PR Last commit
@adxsdknet
Copy link

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5523
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@47ee709

veronicagg
veronicagg suggested changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, is this already part of the deployed api? is this just updating/fixing swagger?

@blueww
Copy link
Member Author

blueww commented Mar 21, 2019 •
edited
Loading

@veronicagg
This PR is to fix swagger.
The server already behavior like this. (return 201 with successfully create, return 200 with already created)
With the fix, the next SDK release will have the change naturelly.

@veronicagg veronicagg merged commit a470ddc into Azure:master Mar 21, 2019
This was referenced Mar 21, 2019
Merged
Merged
dsgouda pushed a commit to Azure/azure-sdk-for-net that referenced this pull request Mar 21, 2019
@adxsdknet @dsgouda
.NET SDK Resource Provider:'Storage' (#5523)
d5f5a14 
REST Spec PR 'Azure/azure-rest-api-specs#5434'
REST Spec PR Author 'blueww'
REST Spec PR Last commit
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@adxsdknet @mentat9
.NET SDK Resource Provider:'Storage' (Azure#5523)
612ee9f 
REST Spec PR 'Azure/azure-rest-api-specs#5434'
REST Spec PR Author 'blueww'
REST Spec PR Last commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veronicagg veronicagg veronicagg approved these changes

Assignees

@veronicagg veronicagg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blueww @AutorestCI @azuresdkci @adxsdknet @veronicagg