[AKS Do Not Merge] fix regression in new 2019-02-01 spec #5357

mboersma · 2019-03-11T16:18:52Z

Adds a regex pattern to the 2019-02-01 spec that was missed. See #5324.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-03-11T16:19:45Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout b163c16ca282855258371cb0985173d1dfb1dd43
  stderr: 'fatal: reference is not a tree: b163c16ca282855258371cb0985173d1dfb1dd43'

AutorestCI · 2019-03-11T16:19:55Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout b163c16ca282855258371cb0985173d1dfb1dd43
  stderr: 'fatal: reference is not a tree: b163c16ca282855258371cb0985173d1dfb1dd43'

AutorestCI · 2019-03-11T16:20:29Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout b163c16ca282855258371cb0985173d1dfb1dd43
  stderr: 'fatal: reference is not a tree: b163c16ca282855258371cb0985173d1dfb1dd43'

AutorestCI · 2019-03-11T16:20:30Z

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout b163c16ca282855258371cb0985173d1dfb1dd43
  stderr: 'fatal: reference is not a tree: b163c16ca282855258371cb0985173d1dfb1dd43'

AutorestCI · 2019-03-11T16:20:49Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout b163c16ca282855258371cb0985173d1dfb1dd43
  stderr: 'fatal: reference is not a tree: b163c16ca282855258371cb0985173d1dfb1dd43'

azuresdkci · 2019-03-11T16:21:01Z

Can one of the admins verify this patch?

AutorestCI · 2019-03-11T16:21:52Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout b163c16ca282855258371cb0985173d1dfb1dd43
  stderr: 'fatal: reference is not a tree: b163c16ca282855258371cb0985173d1dfb1dd43'

REST Spec PR 'Azure/azure-rest-api-specs#5357' REST Spec PR Author 'mboersma' REST Spec PR Last commit

xizha162 · 2019-03-11T18:53:33Z

/LGTM

xizha162 · 2019-03-12T00:43:55Z

@jianghaolu,@mboersma , just reopened this PR. I will make future changes in a new 2019-04-01-preview API version. So please merge this fix to 2019-02-01. The same fix to 20180801 api version is already approved.

REST Spec PR 'Azure/azure-rest-api-specs#5357' REST Spec PR Author 'mboersma' REST Spec PR Last commit

dsgouda · 2019-03-18T16:53:51Z

startbuild

REST Spec PR 'Azure/azure-rest-api-specs#5357' REST Spec PR Author 'mboersma' REST Spec PR Last commit

adxsdknet · 2019-03-18T17:00:48Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5492
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@69d37e6

xizha162 · 2019-03-19T17:30:12Z

incuded in a later PR: #5357

[AKS] fix regression in new 2019-02-01 spec

66d644f

This was referenced Mar 11, 2019

[AutoPR containerservice/resource-manager] [AKS] fix regression in new 2019-02-01 spec Azure/azure-sdk-for-js#1508

Closed

[AutoPR containerservice/resource-manager] [AKS] fix regression in new 2019-02-01 spec Azure/azure-sdk-for-python#4527

Closed

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR containerservice/resource-manager] [AKS] fix regression in new 2019-02-01 spec Azure/azure-sdk-for-ruby#2303

Closed

azuresdkci assigned jianghaolu Mar 11, 2019

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR containerservice/resource-manager] [AKS] fix regression in new 2019-02-01 spec Azure/azure-sdk-for-node#4862

Closed

azuresdkci requested a review from jianghaolu March 11, 2019 16:20

AutorestCI mentioned this pull request Mar 11, 2019

[AutoPR containerservice/resource-manager] [AKS] fix regression in new 2019-02-01 spec Azure/azure-sdk-for-go#4250

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 11, 2019

.NET SDK Resource Provider:'ContainerService'

6b9bbb7

REST Spec PR 'Azure/azure-rest-api-specs#5357' REST Spec PR Author 'mboersma' REST Spec PR Last commit

mboersma mentioned this pull request Mar 11, 2019

[AutoPR containerservice/resource-manager] [Hub Generated] Review request for Microsoft.ContainerService to add version 2019-02-01 Azure/azure-sdk-for-python#4516

Merged

xizha162 self-requested a review March 11, 2019 18:53

xizha162 approved these changes Mar 11, 2019

View reviewed changes

xizha162 closed this Mar 12, 2019

xizha162 reopened this Mar 15, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 15, 2019

.NET SDK Resource Provider:'ContainerService'

273dca6

REST Spec PR 'Azure/azure-rest-api-specs#5357' REST Spec PR Author 'mboersma' REST Spec PR Last commit

xizha162 changed the title ~~[AKS] fix regression in new 2019-02-01 spec~~ [AKS Do Not Merge] fix regression in new 2019-02-01 spec Mar 15, 2019

Azure deleted a comment from adxsdknet Mar 18, 2019

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 18, 2019

.NET SDK Resource Provider:'ContainerService'

69d37e6

REST Spec PR 'Azure/azure-rest-api-specs#5357' REST Spec PR Author 'mboersma' REST Spec PR Last commit

xizha162 closed this Mar 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AKS Do Not Merge] fix regression in new 2019-02-01 spec #5357

[AKS Do Not Merge] fix regression in new 2019-02-01 spec #5357

mboersma commented Mar 11, 2019

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

azuresdkci commented Mar 11, 2019

AutorestCI commented Mar 11, 2019 •

edited

Loading

xizha162 commented Mar 11, 2019

xizha162 commented Mar 12, 2019 •

edited

Loading

dsgouda commented Mar 18, 2019

adxsdknet commented Mar 18, 2019

xizha162 commented Mar 19, 2019 •

edited

Loading

[AKS Do Not Merge] fix regression in new 2019-02-01 spec #5357

[AKS Do Not Merge] fix regression in new 2019-02-01 spec #5357

Conversation

mboersma commented Mar 11, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Mar 11, 2019 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Mar 11, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Mar 11, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Mar 11, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Mar 11, 2019 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Mar 11, 2019

AutorestCI commented Mar 11, 2019 • edited Loading

Automation for azure-sdk-for-go

xizha162 commented Mar 11, 2019

xizha162 commented Mar 12, 2019 • edited Loading

dsgouda commented Mar 18, 2019

adxsdknet commented Mar 18, 2019

Automation for azure-sdk-for-net

xizha162 commented Mar 19, 2019 • edited Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

AutorestCI commented Mar 11, 2019 •

edited

Loading

xizha162 commented Mar 12, 2019 •

edited

Loading

xizha162 commented Mar 19, 2019 •

edited

Loading