[DO NOT MERGE] Add WAF as a top level resource #5185

meetug · 2019-02-11T19:44:04Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-02-11T19:45:15Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c9e4ead5e1c0247a08e7343926dc0d8af246c8db
  stderr: 'fatal: reference is not a tree: c9e4ead5e1c0247a08e7343926dc0d8af246c8db'

AutorestCI · 2019-02-11T19:45:17Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c9e4ead5e1c0247a08e7343926dc0d8af246c8db
  stderr: 'fatal: reference is not a tree: c9e4ead5e1c0247a08e7343926dc0d8af246c8db'

azuresdkci · 2019-02-11T19:45:28Z

Can one of the admins verify this patch?

AutorestCI · 2019-02-11T19:45:38Z

Automation for azure-sdk-for-ruby

Encountered an unknown error: (azure-sdk-for-ruby)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c9e4ead5e1c0247a08e7343926dc0d8af246c8db
  stderr: 'fatal: reference is not a tree: c9e4ead5e1c0247a08e7343926dc0d8af246c8db'

AutorestCI · 2019-02-11T19:47:20Z

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c9e4ead5e1c0247a08e7343926dc0d8af246c8db
  stderr: 'fatal: reference is not a tree: c9e4ead5e1c0247a08e7343926dc0d8af246c8db'

AutorestCI · 2019-02-11T19:48:09Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c9e4ead5e1c0247a08e7343926dc0d8af246c8db
  stderr: 'fatal: reference is not a tree: c9e4ead5e1c0247a08e7343926dc0d8af246c8db'

AutorestCI · 2019-02-11T19:53:36Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout c9e4ead5e1c0247a08e7343926dc0d8af246c8db
  stderr: 'fatal: reference is not a tree: c9e4ead5e1c0247a08e7343926dc0d8af246c8db'

...ion/network/resource-manager/Microsoft.Network/stable/2018-12-01/webapplicationfirewall.json

anton-evseev · 2019-02-15T06:55:38Z

network-january-branch has been merged into master. I'm not sure if we should retarget this PR to master too or wait for the next release branch. @MikhailTryakhov to clarify

MikhailTryakhov · 2019-02-20T23:11:32Z

Closing due to branch is released

MikhailTryakhov · 2019-02-20T23:16:08Z

retargeted on february branch

anton-evseev · 2019-02-22T12:27:16Z

Please add the new JSON file to input files of package-2018-12 and package-2018-12-only in readme.md

Also I think webapplicationfirewall.json should be renamed to webApplicationFirewall.json to keep consistency with other other spec files that are named in camelCase

salameer · 2019-02-25T23:18:04Z

Alright Guys, let us know we changes are done so that @jianghaolu can wrap this on up. @meetug remove the Don't Merge from the Title if this is ready for release, or keep it there if not

...ion/network/resource-manager/Microsoft.Network/stable/2018-12-01/webapplicationfirewall.json

Add WAF as a top level resource

b2b0ab3

meetug requested a review from MikhailTryakhov as a code owner February 11, 2019 19:44

azuresdkci assigned jianghaolu Feb 11, 2019

azuresdkci requested a review from jianghaolu February 11, 2019 19:45

Fix merge

663b70e

jianghaolu suggested changes Feb 12, 2019

View reviewed changes

...ion/network/resource-manager/Microsoft.Network/stable/2018-12-01/webapplicationfirewall.json Show resolved Hide resolved

...ion/network/resource-manager/Microsoft.Network/stable/2018-12-01/webapplicationfirewall.json Outdated Show resolved Hide resolved

nschonni reviewed Feb 12, 2019

View reviewed changes

Addressed comments

0b2c263

anton-evseev suggested changes Feb 13, 2019

View reviewed changes

Addressed comments

92d6cac

anton-evseev suggested changes Feb 13, 2019

View reviewed changes

...ion/network/resource-manager/Microsoft.Network/stable/2018-12-01/webapplicationfirewall.json Outdated Show resolved Hide resolved

jianghaolu suggested changes Feb 13, 2019

View reviewed changes

...ion/network/resource-manager/Microsoft.Network/stable/2018-12-01/webapplicationfirewall.json Outdated Show resolved Hide resolved

Code review comments

79354d5

MikhailTryakhov closed this Feb 20, 2019

MikhailTryakhov changed the base branch from network-january-release to network-february-release February 20, 2019 23:15

MikhailTryakhov reopened this Feb 20, 2019

anton-evseev suggested changes Feb 26, 2019

View reviewed changes

meetug closed this Feb 27, 2019

azhao155 mentioned this pull request Mar 7, 2019

Add WAF as a top level resource #5341

Merged

5 tasks

vladbarosan deleted the waf-network-january-release branch March 28, 2019 22:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO NOT MERGE] Add WAF as a top level resource #5185

[DO NOT MERGE] Add WAF as a top level resource #5185

meetug commented Feb 11, 2019

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

azuresdkci commented Feb 11, 2019

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

anton-evseev commented Feb 15, 2019

MikhailTryakhov commented Feb 20, 2019

MikhailTryakhov commented Feb 20, 2019

anton-evseev commented Feb 22, 2019

salameer commented Feb 25, 2019

[DO NOT MERGE] Add WAF as a top level resource #5185

[DO NOT MERGE] Add WAF as a top level resource #5185

Conversation

meetug commented Feb 11, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

AutorestCI commented Feb 11, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Feb 11, 2019 • edited Loading

Automation for azure-sdk-for-js

azuresdkci commented Feb 11, 2019

AutorestCI commented Feb 11, 2019 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Feb 11, 2019 • edited Loading

Automation for azure-sdk-for-node

AutorestCI commented Feb 11, 2019 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Feb 11, 2019 • edited Loading

Automation for azure-sdk-for-java

anton-evseev commented Feb 15, 2019

MikhailTryakhov commented Feb 20, 2019

MikhailTryakhov commented Feb 20, 2019

anton-evseev commented Feb 22, 2019

salameer commented Feb 25, 2019

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading

AutorestCI commented Feb 11, 2019 •

edited

Loading