Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate KC/KS SKUs #5162

Merged
merged 2 commits into from
Feb 6, 2019
Merged

Deprecate KC/KS SKUs #5162

merged 2 commits into from
Feb 6, 2019

Conversation

radennis
Copy link
Contributor

@radennis radennis commented Feb 6, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@radennis radennis changed the title Ga kc 1 Deprecate KC/KS SKUs Feb 6, 2019
@AutorestCI
Copy link

AutorestCI commented Feb 6, 2019

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Feb 6, 2019

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Feb 6, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#4303

@AutorestCI
Copy link

AutorestCI commented Feb 6, 2019

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Feb 6, 2019

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2911

@AutorestCI
Copy link

AutorestCI commented Feb 6, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4036

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@praries880 praries880 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required potential-sdk-breaking-change labels Feb 6, 2019
@radennis
Copy link
Contributor Author

radennis commented Feb 6, 2019

The change deprecates old sku names before out GA tomorrow.
The kusto.json of the GA version file was only added two days ago. The libraries weren't generated with it yet and need to be generated today. We would really appreciate if the libraries can include this cahnge and the change submitted quickly for that.

@praries880 praries880 requested a review from anuchandy February 6, 2019 17:55
@praries880
Copy link

Adding @anuchandy as he has history on this.

@praries880 praries880 removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants