Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR - Introduce new API version (2019-01-01) with new (Export-related APIs) introduced #5127

Merged
merged 20 commits into from
Feb 4, 2019
Merged

PR - Introduce new API version (2019-01-01) with new (Export-related APIs) introduced #5127

merged 20 commits into from
Feb 4, 2019

Conversation

shbha
Copy link
Contributor

@shbha shbha commented Jan 31, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Jan 31, 2019 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Jan 31, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2924

@AutorestCI
Copy link

AutorestCI commented Jan 31, 2019 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jan 31, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jan 31, 2019 •
edited
Loading

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI AutorestCI mentioned this pull request Jan 31, 2019
Merged
@AutorestCI
Copy link

AutorestCI commented Jan 31, 2019 •
edited
Loading

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4013

@praries880 praries880 added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 31, 2019
@praries880
Copy link

@shbha Is the new stable version based directly on a preview version (like 2018-12-01 for example)?

Also have these changes been through an Azure API review?

@shbha
Copy link
Contributor Author

shbha commented Jan 31, 2019

The changes here are related to PR - #5020 which has already been signed off by ARM.

@shbha shbha changed the title Export2 PR - Introduce new API version (2019-01-01) with new (Export-related APIs) introduced Jan 31, 2019
@shbha
Copy link
Contributor Author

shbha commented Feb 1, 2019

@praries880 - would you be able to assist with the failing build? It started to fail after the readme files were updated. Am I not supported to update these files?

@AutorestCI AutorestCI mentioned this pull request Feb 1, 2019
Merged
@praries880
Copy link

@shbha There is a large delta (~1300 lines) between the swagger in the stable version and the one you got reviewed by ARM for the preview version. I will wait for ARM to review this.
Thanks for understanding :)

@ravbhatnagar ravbhatnagar added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 1, 2019
@ravbhatnagar
Copy link
Contributor

As discussed over IM, can you abstract out the scope into a param called scope? That way you will reduce the number of APis you have to define. Right now each API is defined for every supported scopes (5 scopes I think). and scope can be an enum with a defined set of values. This will simplify generated SDKs and allow you to easily expand to new scopes in future if needed.
@sanjaiganesh - other than this, it looks good.

@shbha
Copy link
Contributor Author

shbha commented Feb 2, 2019

As discussed over IM, can you abstract out the scope into a param called scope? That way you will reduce the number of APis you have to define. Right now each API is defined for every supported scopes (5 scopes I think). and scope can be an enum with a defined set of values. This will simplify generated SDKs and allow you to easily expand to new scopes in future if needed.
@sanjaiganesh - other than this, it looks good.

@sanjaiganesh @ravbhatnagar - The recommended changes have been incorporated. All API paths are now using scope.

@sanjaiganesh sanjaiganesh added ARMReviewInProgress ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReviewInProgress labels Feb 2, 2019
@sanjaiganesh
Copy link
Contributor

Please add scopes enum as @ravbhatnagar suggested and also fix to remove tab chars (use 4 spaces for encoding tab)

sanjaiganesh
sanjaiganesh approved these changes Feb 2, 2019
View reviewed changes
Copy link
Contributor

@sanjaiganesh sanjaiganesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sanjaiganesh sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Feb 2, 2019
@praries880 praries880 removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 4, 2019
@praries880 praries880 merged commit 279463b into Azure:master Feb 4, 2019
mccleanp pushed a commit that referenced this pull request Mar 23, 2022
@martincyruswolfenbarger
Add log analytics profile to clusterprofile. (#5127)
56ac087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@sanjaiganesh sanjaiganesh sanjaiganesh approved these changes

@praries880 praries880 praries880 approved these changes

Assignees

@praries880 praries880

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@shbha @AutorestCI @azuresdkci @praries880 @ravbhatnagar @sanjaiganesh @nschonni @shbhamsft