Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Helm Events to ACR Schema for Event Grid #5109

Merged
merged 3 commits into from
Jan 31, 2019
Merged

Add Helm Events to ACR Schema for Event Grid #5109

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fe28cd
update ACR spec for Event Grid
jaysterp Jan 29, 2019
b71f718
format fix
jaysterp Jan 29, 2019
c262b34
edit artifact descriptions
jaysterp Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 74 additions & 0 deletions ...eventgrid/data-plane/Microsoft.ContainerRegistry/stable/2018-01-01/ContainerRegistry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,24 @@
],
"properties": {}
},
"ContainerRegistryChartPushedEventData": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chart [](start = 26, length = 5)

referring to the other comment.. should this also be renamed to Artifact ?

Copy link
Member

@djyou djyou Jan 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chart is one type of Artifact and there will be other event types for other artifact types that inherit the same ContainerRegistryArtifactEventData

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good.

In reply to: 252465044 [](ancestors = 252465044)

"description": "Schema of the Data property of an EventGridEvent for a Microsoft.ContainerRegistry.ChartPushed event.",
"allOf": [
{
"$ref": "#/definitions/ContainerRegistryArtifactEventData"
}
],
"properties": {}
},
"ContainerRegistryChartDeletedEventData": {
"description": "Schema of the Data property of an EventGridEvent for a Microsoft.ContainerRegistry.ChartDeleted event.",
"allOf": [
{
"$ref": "#/definitions/ContainerRegistryArtifactEventData"
}
],
"properties": {}
},
"ContainerRegistryEventData": {
"description": "The content of the event request message.",
"properties": {
Expand Down Expand Up @@ -59,6 +77,28 @@
}
}
},
"ContainerRegistryArtifactEventData": {
"description": "The content of the event request message.",
"properties": {
"id": {
"description": "The event ID.",
"type": "string"
},
"timestamp": {
"format": "date-time",
"description": "The time at which the event occurred.",
"type": "string"
},
"action": {
"description": "The action that encompasses the provided event.",
"type": "string"
},
"target": {
"$ref": "#/definitions/ContainerRegistryArtifactEventTarget",
"description": "The target of the event."
}
}
},
"ContainerRegistryEventTarget": {
"description": "The target of the event.",
"properties": {
Expand Down Expand Up @@ -94,6 +134,40 @@
}
}
},
"ContainerRegistryArtifactEventTarget": {
"description": "The target of the event.",
"properties": {
"mediaType": {
"description": "The MIME type of the referenced object.",
"type": "string"
},
"size": {
"format": "int64",
"description": "The number of bytes of the content.",
"type": "integer"
},
"digest": {
"description": "The digest of the helm chart.",
jaysterp marked this conversation as resolved.
Show resolved Hide resolved
"type": "string"
},
"repository": {
"description": "The repository name.",
"type": "string"
},
"tag": {
"description": "The tag name.",
"type": "string"
},
"name": {
"description": "The name of the helm chart.",
"type": "string"
},
"version": {
"description": "The version of the helm chart.",
"type": "string"
}
}
},
"ContainerRegistryEventRequest": {
"description": "The request that generated the event.",
"properties": {
Expand Down