Dev adhybridhealthservice microsoft.ad hybrid health service 2014 01 01 binilkk #5042
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3258,6 +3258,76 @@ | |
| } | ||
| } | ||
| } | ||
| }, | ||
| "/providers/Microsoft.ADHybridHealthService/services/{serviceName}/reports/riskyIp/blobUris": { | ||
| "get": { | ||
| "tags": [ "Reports" ], | ||
| "description": "Gets all Risky IP report URIs for the last 7 days.", | ||
| "x-ms-examples": { | ||
| "services_listAllRiskyIpDownloadReport": { | ||
| "$ref": "./examples/RiskyIpDownload.json" | ||
| } | ||
| }, | ||
| "operationId": "services_listAllRiskyIpDownloadReport", | ||
| "parameters": [ | ||
| { | ||
| "name": "serviceName", | ||
| "in": "path", | ||
| "description": "The name of the service.", | ||
| "required": true, | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/apiVersionParameter" | ||
| } | ||
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "Risky IP report URIs for the last 7 days.", | ||
| "schema": { | ||
| "$ref": "#/definitions/RiskyIPBlobUris" | ||
| } | ||
| } | ||
| }, | ||
| "x-ms-pageable": { | ||
| "nextLinkName": null | ||
| } | ||
| } | ||
| }, | ||
| "/providers/Microsoft.ADHybridHealthService/services/{serviceName}/reports/riskyIp/generateBlobUri": { | ||
| "post": { | ||
| "tags": [ "Reports" ], | ||
| "description": "Initiate the generation of a new Risky IP report. Returns the URI for the new one.", | ||
binilkk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "x-ms-examples": { | ||
| "services_listCurrentRiskyIpDownloadReport": { | ||
| "$ref": "./examples/RiskyIpDownload.json" | ||
| } | ||
| }, | ||
| "operationId": "services_listCurrentRiskyIpDownloadReport", | ||
|
There was a problem hiding this comment. operationId should not be camel-cased. There was a problem hiding this comment. I'll make the change. It seems I'll have to fix it for the whole document though. Is there any implication to the spec for changing it everywhere? There was a problem hiding this comment. I'd leave it as-is then for consistency with the rest of the docs. It's highly likely that there's zero impact to codegen as most generators probably fix the casing. There was a problem hiding this comment. Great. So are we good to go with this PR? There was a problem hiding this comment. Once @KrisBash signs off from ARM side I will complete my review. There was a problem hiding this comment. @KrisBash, could you please take a look? |
||
| "parameters": [ | ||
| { | ||
| "name": "serviceName", | ||
| "in": "path", | ||
| "description": "The name of the service.", | ||
| "required": true, | ||
| "type": "string" | ||
| }, | ||
| { | ||
| "$ref": "#/parameters/apiVersionParameter" | ||
| } | ||
| ], | ||
| "responses": { | ||
| "200": { | ||
| "description": "The URI of the Risky IP report that was requested.", | ||
| "schema": { | ||
| "$ref": "#/definitions/RiskyIPBlobUris" | ||
| } | ||
| } | ||
| }, | ||
| "x-ms-pageable": { | ||
| "nextLinkName": null | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "definitions": { | ||
|
|
@@ -5721,6 +5791,51 @@ | |
| } | ||
| } | ||
| }, | ||
| "RiskyIPBlobUri": { | ||
| "description": "The blob uri pointing to Risky IP Report.", | ||
| "type": "object", | ||
| "properties": { | ||
| "tenantId": { | ||
| "description": "The tenant id for whom the report belongs to.", | ||
| "type": "string" | ||
| }, | ||
| "serviceId": { | ||
| "description": "The service id for whom the report belongs to.", | ||
| "type": "string" | ||
| }, | ||
| "resultSasUri": { | ||
| "description": "The blob uri for the report.", | ||
| "type": "string" | ||
| }, | ||
| "blobCreateDateTime": { | ||
| "description": "Time at which the the new Risky IP report was requested.", | ||
| "type": "string", | ||
| "format": "date-time" | ||
| }, | ||
| "jobCompletionTime": { | ||
| "description": "Time at which the blob creation job for the new Risky IP report was completed.", | ||
| "type": "string", | ||
| "format": "date-time" | ||
| }, | ||
| "status": { | ||
| "description": "Status of the Risky IP report generation.", | ||
| "type": "string" | ||
| } | ||
| } | ||
| }, | ||
| "RiskyIPBlobUris": { | ||
| "description": "The list containing blob uris.", | ||
| "type": "object", | ||
| "properties": { | ||
| "value": { | ||
| "description": "The list of blob uris.", | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/definitions/RiskyIPBlobUri" | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "RuleErrorInfo": { | ||
| "description": "The error details in legacy rule processing.", | ||
| "type": "object", | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "parameters": { | ||
| "serviceName": "sampleServiceName", | ||
| "api-version": "2014-01-01" | ||
| }, | ||
| "responses": { | ||
| "200": { | ||
| "body": { | ||
| "value": [ | ||
| { | ||
| "tenantId": "TenantId of the tenant.", | ||
| "serviceId": "ServiceId of the tenant.", | ||
| "resultSasUri": "SAS Uri of the blob.", | ||
| "blobCreateDateTime": "2019-01-07T20:32:02+00:00", | ||
| "jobCompletionTime": "2019-01-07T20:32:05+00:00", | ||
| "status": "status of the task." | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
operationId should not be camel-cased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Joel, Gaurav from ARM team has signed off, could you please sign off so that I can merge? I don't have permissions to merge, am I correct in guessing that your signoff will cause merge to happen?