Security: 2017-08-01-preview - Introduce IoT security groups resource #4968

galmicrosoft · 2018-12-30T15:15:56Z

Add the relevant resource definitions
Add get, put, delete, list operations

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

* Add the relevant resource definitions * Add get, put, delete, list operations

openapi-portal-comment · 2018-12-30T15:15:57Z

If you're a MSFT employee, click this link
to view this PR's validation status on our new OpenAPI Hub spec management tool.

AutorestCI · 2018-12-30T15:16:20Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2018-12-30T15:16:49Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3782

AutorestCI · 2018-12-30T15:16:51Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1765

AutorestCI · 2018-12-30T15:16:55Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

azuresdkci · 2018-12-30T15:16:57Z

Hello!!

The Rest API Specs team wishes everyone a happy holiday and would like to kindly inform you that responses and review to Pull request will be delayed during the holiday period (now -> 2nds of January) to allow for Awesome reviewers to have an awesome time with their families during the holidays!

Thanks and Have a WONDERFUL HOLIDAY

azuresdkci · 2018-12-30T15:17:52Z

Can one of the admins verify this patch?

AutorestCI · 2018-12-30T15:18:18Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#4436

AutorestCI · 2018-12-30T15:19:45Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#5044

galmicrosoft · 2018-12-30T15:22:45Z

How can I add reviewer and labels (DoNotMerge)?

nschonni · 2018-12-31T02:32:21Z

Should it be camel cased to "AllowList" and "DenyList"?

hovsepm · 2018-12-31T19:06:19Z

@galmicrosoft who do you want to add as reviewer?

galmicrosoft · 2018-12-31T19:08:30Z

@galmicrosoft who do you want to add as reviewer?

chlahav
Thank!

KrisBash

Changes look good, thanks

jhendrixMSFT · 2019-01-15T18:06:39Z

@galmicrosoft there is still a DoNotMerge label on the PR, is it safe to remove?

jhendrixMSFT · 2019-01-15T18:06:50Z

@AutorestCI regenerate azure-sdk-for-go

galmicrosoft · 2019-01-15T22:22:49Z

@galmicrosoft there is still a DoNotMerge label on the PR, is it safe to remove?

@jhendrixMSFT no, we want to check that everything works with feature flag (requiredFeatures in the manifest)

jhendrixMSFT · 2019-02-01T17:35:44Z

@galmicrosoft hello any update?

galmicrosoft · 2019-02-01T17:49:38Z

@galmicrosoft hello any update?

Hey @jhendrixMSFT, we're still testing out the new feature so we should keep the DoNotMerge label for now. I'll update when we can continue.

jhendrixMSFT · 2019-02-28T18:06:52Z

@galmicrosoft hello any update? Also there's a merge conflict that needs to be resolved.

jhendrixMSFT · 2019-03-19T17:12:35Z

@galmicrosoft ping

REST Spec PR 'Azure/azure-rest-api-specs#4968' REST Spec PR Author 'galmicrosoft' REST Spec PR Last commit

adxsdknet · 2019-03-24T19:26:35Z

Automation for azure-sdk-for-net

A PR has been created for you:
Azure/azure-sdk-for-net#5564
.NET SDK Commits:
adxsdknet/azure-sdk-for-net@f9b170f
adxsdknet/azure-sdk-for-net@02e1e76

REST Spec PR 'Azure/azure-rest-api-specs#4968' REST Spec PR Author 'galmicrosoft' REST Spec PR Last commit

galmicrosoft · 2019-03-24T20:06:38Z

@galmicrosoft ping

Hi,

I updated the PR (sync from master)
The avocado test is failing with error:
/home/vsts/work/1/s/specification/security/resource-manager
code: UNREFERENCED_OPEN_API_FILE
message: The OpenAPI file is not referenced from the readme file.
readMeUrl: /home/vsts/work/1/s/specification/security/resource-manager/readme.md
openApiUrl: >-
/home/vsts/work/1/s/specification/security/resource-manager/Microsoft.Security/preview/2015-06-01-preview/examples/JitNetworkAccessPolicies/InvokeJitNetworkAccessPolicy_example.json

But I didn't touch this file or any files related to this resource...
We can remove the DoNotMerge label and merge when possible

* .NET SDK Resource Provider:'SecurityCenter' REST Spec PR 'Azure/azure-rest-api-specs#4968' REST Spec PR Author 'galmicrosoft' REST Spec PR Last commit * .NET SDK Resource Provider:'SecurityCenter' REST Spec PR 'Azure/azure-rest-api-specs#4968' REST Spec PR Author 'galmicrosoft' REST Spec PR Last commit

jhendrixMSFT · 2019-03-29T17:10:05Z

@AutorestCI regenerate azure-sdk-for-go

* .NET SDK Resource Provider:'SecurityCenter' REST Spec PR 'Azure/azure-rest-api-specs#4968' REST Spec PR Author 'galmicrosoft' REST Spec PR Last commit * .NET SDK Resource Provider:'SecurityCenter' REST Spec PR 'Azure/azure-rest-api-specs#4968' REST Spec PR Author 'galmicrosoft' REST Spec PR Last commit

galmicrosoft added 3 commits December 30, 2018 15:54

Security: 2017-08-01-preview - Introduce IoT security groups resource

fbc7bdd

* Add the relevant resource definitions * Add get, put, delete, list operations

Merge remote-tracking branch 'upstream/master'

3411db5

Some fixes after validation

c55343d

kpajdzik added the review label Dec 30, 2018

AutorestCI mentioned this pull request Dec 30, 2018

[AutoPR security/resource-manager] Security: 2017-08-01-preview - Introduce IoT security groups resource Azure/azure-sdk-for-python#4112

Merged

AutorestCI mentioned this pull request Dec 30, 2018

[AutoPR security/resource-manager] Security: 2017-08-01-preview - Introduce IoT security groups resource Azure/azure-sdk-for-js#881

Closed

azuresdkci assigned hovsepm Dec 30, 2018

azuresdkci requested a review from hovsepm December 30, 2018 15:17

AutorestCI mentioned this pull request Dec 30, 2018

[AutoPR security/resource-manager] Security: 2017-08-01-preview - Introduce IoT security groups resource Azure/azure-sdk-for-go#3783

Closed

AutorestCI mentioned this pull request Dec 30, 2018

[AutoPR security/resource-manager] Security: 2017-08-01-preview - Introduce IoT security groups resource Azure/azure-sdk-for-node#4494

Closed

hovsepm added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Dec 31, 2018

hovsepm requested a review from chlahav December 31, 2018 20:51

hovsepm added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 3, 2019

hovsepm removed their assignment Jan 10, 2019

hovsepm added the Reassign label Jan 10, 2019

azuresdkci removed the Reassign label Jan 10, 2019

azuresdkci assigned jhendrixMSFT Jan 10, 2019

KrisBash approved these changes Jan 15, 2019

View reviewed changes

KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 15, 2019

AutorestCI mentioned this pull request Jan 15, 2019

[AutoPR security/resource-manager] Security: 2017-08-01-preview - Introduce IoT security groups resource Azure/azure-sdk-for-go#3877

Closed

Merge from upstream/master

c805b34

Sync with master (split files by resource type), add value type

0cfbd83

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 24, 2019

.NET SDK Resource Provider:'SecurityCenter'

f9b170f

REST Spec PR 'Azure/azure-rest-api-specs#4968' REST Spec PR Author 'galmicrosoft' REST Spec PR Last commit

Fix readme file

45af2dd

AutorestCI mentioned this pull request Mar 24, 2019

[AutoPR security/resource-manager] Security: 2017-08-01-preview - Introduce IoT security groups resource Azure/azure-sdk-for-go#4373

Closed

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 24, 2019

.NET SDK Resource Provider:'SecurityCenter'

02e1e76

REST Spec PR 'Azure/azure-rest-api-specs#4968' REST Spec PR Author 'galmicrosoft' REST Spec PR Last commit

delete unreferenced example file

67d905e

jhendrixMSFT approved these changes Mar 25, 2019

View reviewed changes

jhendrixMSFT removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 25, 2019

jhendrixMSFT merged commit 1bcf1cd into Azure:master Mar 25, 2019

AutorestCI mentioned this pull request Mar 29, 2019

[AutoPR security/resource-manager] Security: 2017-08-01-preview - Introduce IoT security groups resource Azure/azure-sdk-for-go#4434

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Security: 2017-08-01-preview - Introduce IoT security groups resource #4968

Security: 2017-08-01-preview - Introduce IoT security groups resource #4968

galmicrosoft commented Dec 30, 2018 •

edited

Loading

openapi-portal-comment bot commented Dec 30, 2018

AutorestCI commented Dec 30, 2018 •

edited

Loading

AutorestCI commented Dec 30, 2018 •

edited

Loading

AutorestCI commented Dec 30, 2018 •

edited

Loading

AutorestCI commented Dec 30, 2018 •

edited

Loading

azuresdkci commented Dec 30, 2018

azuresdkci commented Dec 30, 2018

AutorestCI commented Dec 30, 2018 •

edited

Loading

AutorestCI commented Dec 30, 2018 •

edited

Loading

galmicrosoft commented Dec 30, 2018 •

edited

Loading

nschonni commented Dec 31, 2018

hovsepm commented Dec 31, 2018

galmicrosoft commented Dec 31, 2018

KrisBash left a comment

jhendrixMSFT commented Jan 15, 2019

jhendrixMSFT commented Jan 15, 2019

galmicrosoft commented Jan 15, 2019

jhendrixMSFT commented Feb 1, 2019

galmicrosoft commented Feb 1, 2019

jhendrixMSFT commented Feb 28, 2019

jhendrixMSFT commented Mar 19, 2019

adxsdknet commented Mar 24, 2019 •

edited

Loading

galmicrosoft commented Mar 24, 2019

jhendrixMSFT commented Mar 29, 2019

Security: 2017-08-01-preview - Introduce IoT security groups resource #4968

Security: 2017-08-01-preview - Introduce IoT security groups resource #4968

Conversation

galmicrosoft commented Dec 30, 2018 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-portal-comment bot commented Dec 30, 2018

AutorestCI commented Dec 30, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Dec 30, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Dec 30, 2018 • edited Loading

Automation for azure-sdk-for-js

AutorestCI commented Dec 30, 2018 • edited Loading

Automation for azure-sdk-for-java

azuresdkci commented Dec 30, 2018

azuresdkci commented Dec 30, 2018

AutorestCI commented Dec 30, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Dec 30, 2018 • edited Loading

Automation for azure-sdk-for-node

galmicrosoft commented Dec 30, 2018 • edited Loading

nschonni commented Dec 31, 2018

hovsepm commented Dec 31, 2018

galmicrosoft commented Dec 31, 2018

KrisBash left a comment

Choose a reason for hiding this comment

jhendrixMSFT commented Jan 15, 2019

jhendrixMSFT commented Jan 15, 2019

galmicrosoft commented Jan 15, 2019

jhendrixMSFT commented Feb 1, 2019

galmicrosoft commented Feb 1, 2019

jhendrixMSFT commented Feb 28, 2019

jhendrixMSFT commented Mar 19, 2019

adxsdknet commented Mar 24, 2019 • edited Loading

Automation for azure-sdk-for-net

galmicrosoft commented Mar 24, 2019

jhendrixMSFT commented Mar 29, 2019

galmicrosoft commented Dec 30, 2018 •

edited

Loading

AutorestCI commented Dec 30, 2018 •

edited

Loading

AutorestCI commented Dec 30, 2018 •

edited

Loading

AutorestCI commented Dec 30, 2018 •

edited

Loading

AutorestCI commented Dec 30, 2018 •

edited

Loading

AutorestCI commented Dec 30, 2018 •

edited

Loading

AutorestCI commented Dec 30, 2018 •

edited

Loading

galmicrosoft commented Dec 30, 2018 •

edited

Loading

adxsdknet commented Mar 24, 2019 •

edited

Loading