Skip to content

Add post calls for auth key of authorization objects for expressrouteciruits and expressrouteports - #45679

Merged
santoshgh317 merged 9 commits into
Azure:release-microsoft-network-2026-01-01from
mshrimankar10:postauthkeyforexpressroute
Aug 31, 2026
Merged

santoshgh317 merged 9 commits into
Azure:release-microsoft-network-2026-01-01from
mshrimankar10:postauthkeyforexpressroute

Conversation

@mshrimankar10

Copy link
Copy Markdown
Contributor

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • X ] A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions

github-actions Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds POST actions for retrieving authorization keys from ExpressRoute circuit and port authorization resources.

Changes:

  • Adds listKeys TypeSpec operations and response model.
  • Generates corresponding OpenAPI endpoints and examples.
  • Adds scoped resource-name validation suppressions.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
stable/2025-09-01/expressRoute.json Adds both generated key-retrieval endpoints.
stable/2025-09-01/common.json Adds the authorization-key response schema.
stable/2025-09-01/examples/ExpressRoutePortAuthorizationListKeys.json Adds the port example.
stable/2025-09-01/examples/ExpressRouteCircuitAuthorizationListKeys.json Adds the circuit example.
stable/2025-09-01/examples/ExpressRouteCircuitAuthorizationListKey.json Adds an unreferenced circuit example.
readme.md Adds resource-name suppressions.
Network/models.tsp Defines the secret response model.
Network/ExpressRoutePortAuthorization.tsp Defines the port action.
Network/ExpressRouteCircuitAuthorization.tsp Defines the circuit action.
Network/examples/2025-09-01/ExpressRoutePortAuthorizationListKeys.json Adds the source port example.
Network/examples/2025-09-01/ExpressRouteCircuitAuthorizationListKeys.json Adds the source circuit example.
Suppressed comments (3)

specification/network/resource-manager/Microsoft.Network/Network/Network/ExpressRouteCircuitAuthorization.tsp:90

  • This action does not isolate the credential from normal resource reads. AuthorizationPropertiesFormat.authorizationKey remains in the circuit resource schema (models.tsp:10913-10918, emitted at expressRoute.json:5703-5710), so GET/list and write responses can still expose the same key. SEC-SECRET-DETECT requires retrievable secrets to be returned only through a list* POST action. In the new API version, remove/hide the key from the resource representation and expose it only through this operation.
  listKeys is ArmResourceActionSync<
    ExpressRouteCircuitAuthorization,
    void,
    ArmResponse<ExpressRouteAuthorizationKey>,
    Error = CloudError

specification/network/resource-manager/Microsoft.Network/Network/Network/ExpressRoutePortAuthorization.tsp:120

  • This action does not isolate the credential from normal resource reads. ExpressRoutePortAuthorizationPropertiesFormat.authorizationKey remains read-visible (models.tsp:12177-12183, emitted at expressRoute.json:7475-7484), so GET/list responses still expose the key. SEC-SECRET-DETECT requires retrievable secrets to be returned only through a list* POST action. In the new API version, remove/hide the key from the resource representation and expose it only through this operation.
  listKeys is ExpressRoutePortAuthorizationOps.ActionSync<
    ExpressRoutePortAuthorization,
    void,
    ArmResponse<ExpressRouteAuthorizationKey>,
    OverrideErrorType = CloudError

specification/network/resource-manager/Microsoft.Network/Network/Network/ExpressRouteCircuitAuthorization.tsp:85

  • listkeys permanently publishes a two-word action segment as all lowercase, while the operation itself is listKeys and existing actions in this project use camelCase segments such as listSharedKey, listIdpsSignatures, and listDeploymentStatus. Use the camelCase action path before this API is published, then regenerate the OpenAPI and update the suppression path.
  @action("listkeys")

/**
* Gets the authorization key associated with the specified express route circuit authorization.
*/
@added(Versions.v2025_09_01)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runtime-masking explanation may justify retaining non-secret schema semantics, but the placeholder reasons should be replaced with that concrete rationale. No Approved-TypeSpecSuppression label is present. Please note that this may become a breaking change requirement eventually while merging to main.

@github-actions github-actions Bot added ARMReview resource-manager SuppressionReviewRequired TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 20, 2026
@github-actions

github-actions Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Microsoft.Network
Go sdk/resourcemanager/network/armnetwork
JavaScript @azure/arm-network
Java com.azure.resourcemanager:azure-resourcemanager-network
Python azure-mgmt-network

Comment generated by After APIView workflow run.

@github-actions

Copy link
Copy Markdown

ARM API Review Summary — PR #45679

Verification status: Independent review completed against head commit 93deb289dd5366bb336a8351d856a59a4931fce3 (base release-microsoft-network-2026-01-01). Iteration: 1. Critic review (Step 5.6) was attempted 3 times and could not be completed — the runtime Critic agent reports the required binding protocol files (arm-api-review-critic.agent.md, protocols/arm-api-review-critic.protocol.md, protocols/arm-api-review-critic-inputs.template.md) are absent from this environment. Per the fallback rule, no findings below are Blocking, so no downgrade was necessary; this run proceeds with critic: unknown, disclosed here.

Approval labels observed: none (no BreakingChange-Approved-*, Versioning-Approved-*, Approved-Suppression, or Approved-TypeSpecSuppression).

Scope: 10 changed files, all under specification/network/resource-manager/Microsoft.Network/Network/ — full review performed (no size-cap scoping needed).

# Finding Classification Severity Status
1 @action("listkeys") in ExpressRouteCircuitAuthorization.tsp (L85) and ExpressRoutePortAuthorization.tsp (L115) emits an all-lowercase listkeys URL segment. Per Azure API Guidelines — URLs, action segments should use camelCase (e.g. listKeys, matching precedent such as Microsoft.Storage's /listKeys). NEW Warning Already flagged as an active, unresolved inline comment by the prior automated review pass — not reposted here to avoid duplication.
2 New model ExpressRouteAuthorizationKey (models.tsp L10938-10948): both the model-level doc and its sole authorizationKey property repeat the identical text "The authorization key." with no distinguishing detail. NEW Warning Already flagged as an active, unresolved inline comment by the prior automated review pass — not reposted here.
3 Three prior bot-review threads referencing stable/2025-09-01/... paths (@added(v2025_09_01) mismatch, missing x-ms-secret/format:password, orphaned singular example file) are marked outdated by GitHub and do not correspond to any file in this PR's diff (which only touches stable/2026-01-01/...). Verified: stable/2026-01-01/common.json already declares x-ms-secret: true and format: password on ExpressRouteAuthorizationKey.authorizationKey, and only the plural ...ListKeys.json example files exist in the current diff (no orphan). Resolved-by-supersession — Treated as SKIP-COVERED; no action taken on these bot-authored, GitHub-flagged-outdated threads.
4 readme.md (L335-340) adds a ResourceNameRestriction suppression for the two new listkeys paths with a substantive, non-placeholder justification (references pre-existing path parameters and breaking-change rationale). NEW — Compliant; no finding.
5 authorizationKey on the pre-existing AuthorizationPropertiesFormat / ExpressRoutePortAuthorizationPropertiesFormat models carries a pre-existing #suppress ... "FIXME: Update justification..." annotation that predates this PR. EXISTING Informational Not attributed to this PR's author; noted for awareness only, not posted as a blocking/inline finding.

Findings on unchanged files: None.

posted-by: arm-api-reviewer-agent | rule: summary | severity: warning | classification: new | critic: unknown | head-sha: 93deb28

🔍 ARM API review by ARM API Review: Automated Workflow

@github-actions

github-actions Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

TypeSpec suppressions requiring review (testing, non-blocking)

Status: ❌ Approval required (currently under testing, review NOT enforced) — 4 suppressions

⚠️ This check is currently in testing mode and is non-blocking — it will not prevent this PR from merging. This PR adds or updates the TypeSpec suppressions listed below. Suppressions are strongly discouraged — they bypass linter rules that protect API quality and consistency. Authors should avoid adding new suppressions and prefer fixing the underlying issue; reviewers should approve only when there is a clear, compelling justification and no reasonable alternative. Review each linked rule and source location, then apply Approved-TypeSpecSuppression only if every justification is acceptable. The Status column shows ✅ once the label is applied and ❌ while approval is pending.

Changed suppressions (4)

StatusRuleSourcePrevious justificationNew justification
❌@azure-tools/typespec-azure-resource-manager/secret-prop
RPC-v1-13: Check that property with names indicating sensitive information(e.g. contains auth, password, token, secret, etc.) are marked with Madara (@secret) decorator.
models.tsp#L11359FIXME: Update justification, follow aka.ms/tsp/conversion-fix for detailsPre-existing GA property; changing its schema (e.g. adding format: password / x-ms-secret) would be a breaking change. Whether GET/LIST returns this authorization key unmasked or masked is enforced at runtime by the backend based on the caller's privileges, not by the API schema, so Madara (@secret) is intentionally not applied. The dedicated listKeys POST action returns the unmasked key via the Madara (@secret) ExpressRouteAuthorizationKey response model.
❌@azure-tools/typespec-azure-resource-manager/secret-prop
RPC-v1-13: Check that property with names indicating sensitive information(e.g. contains auth, password, token, secret, etc.) are marked with Madara (@secret) decorator.
models.tsp#L12826FIXME: Update justification, follow aka.ms/tsp/conversion-fix for detailsPre-existing GA property; changing its schema (e.g. adding format: password / x-ms-secret) would be a breaking change. Whether GET/LIST returns this authorization key unmasked or masked is enforced at runtime by the backend based on the caller's privileges, not by the API schema, so Madara (@secret) is intentionally not applied. The dedicated listKeys POST action returns the unmasked key via the Madara (@secret) ExpressRouteAuthorizationKey response model.
❌@azure-tools/typespec-azure-resource-manager/secret-prop
RPC-v1-13: Check that property with names indicating sensitive information(e.g. contains auth, password, token, secret, etc.) are marked with Madara (@secret) decorator.
models.tsp#L11359FIXME: Update justification, follow aka.ms/tsp/conversion-fix for detailsPre-existing GA property; changing its schema (e.g. adding format: password / x-ms-secret) would be a breaking change. Whether GET/LIST returns this authorization key unmasked or masked is enforced at runtime by the backend based on the caller's privileges, not by the API schema, so Madara (@secret) is intentionally not applied. The dedicated listKeys POST action returns the unmasked key via the Madara (@secret) ExpressRouteAuthorizationKey response model.
❌@azure-tools/typespec-azure-resource-manager/secret-prop
RPC-v1-13: Check that property with names indicating sensitive information(e.g. contains auth, password, token, secret, etc.) are marked with Madara (@secret) decorator.
models.tsp#L12826FIXME: Update justification, follow aka.ms/tsp/conversion-fix for detailsPre-existing GA property; changing its schema (e.g. adding format: password / x-ms-secret) would be a breaking change. Whether GET/LIST returns this authorization key unmasked or masked is enforced at runtime by the backend based on the caller's privileges, not by the API schema, so Madara (@secret) is intentionally not applied. The dedicated listKeys POST action returns the unmasked key via the Madara (@secret) ExpressRouteAuthorizationKey response model.

For an overview of TypeSpec linting rules click here.
For a mapping from ARM lintdiff rules to corresponding TypeSpec linting rules click here.

💬 Have feedback on the TypeSpec suppression flow? Let us know.

@github-actions

Copy link
Copy Markdown

ARM API Review Summary

Reviewed PR #45679 at head SHA 535d98d88b0afb3f694f455ff1b112578ac69c8b | Triggered by: workflow_run

Approval labels observed: none.

Category Count
🔴 Blocking 0
🟠 Warning 0
🔵 Suggestion 0

Reconciliation against all existing discussion surfaces (inline review threads, top-level comments, and review bodies) found no new, uncovered findings for the current head SHA. The one still-active inline thread (duplicate/uninformative "The authorization key." description on ExpressRouteAuthorizationKey and its authorizationKey property in models.tsp) remains open and unresolved — no new duplicate finding was posted (SKIP-COVERED). Four other bot-authored threads referencing the prior stable/2025-09-01 version-folder path, an @added version mismatch, missing secret markers, and an orphaned example file are GitHub-marked outdated and superseded by the current push to stable/2026-01-01 (verified: x-ms-secret: true/format: password are present on the new ExpressRouteAuthorizationKey.authorizationKey schema in stable/2026-01-01/common.json, and only the plural ...ListKeys.json example files exist in the current diff), so no action was taken on them. The previously flagged listkeys lowercase action-segment issue has been fixed in the current push (both TypeSpec files now use @action("listKeys")).

Note: The Mandatory Critic Review (Step 5.6) subagent reported that its required binding protocol files are unavailable in this environment and returned a FAIL/no-verdict response after being dispatched. Since no Blocking findings were candidates for posting in this run, no downgrade was necessary; critic: unknown is disclosed here per the fallback rule.

posted-by: arm-api-reviewer-agent | rule: summary | severity: suggestion | classification: existing | critic: unknown | head-sha: 535d98d

🔍 ARM API review by ARM API Review: Automated Workflow

@sandipsh

Copy link
Copy Markdown
Contributor

Correction to the earlier conclusions in #45679 (comment): the ResourceNameRestriction suppression was described as compliant, and the two secret-prop suppressions as informational only. Those conclusions are superseded by the current evidence at 535d98d88b0afb3f694f455ff1b112578ac69c8b.

The two new readme.md suppressions at lines 5170-5175 are file-wide because they omit where:. Please remove each broad entry, rerun LintDiff, and, if suppression remains justified, scope it to the exact jsonpath reported by that run. Otherwise future violations anywhere in expressRoute.json can be hidden. No Approved-Suppression label is currently present.

The authorizationKey properties at models.tsp lines 10917 and 12181 also still suppress secret-prop. Because these are credential signals, please use @secret on both, regenerate, and confirm GET/LIST never returns an unmasked key; otherwise SDK and logging tooling treat them as ordinary strings. No Approved-TypeSpecSuppression label is currently present.

If an approval label covers either exact finding, please apply it and resolve the corresponding concern; otherwise address or obtain approval for it.

@sandipsh Sandip Shahane (sandipsh) added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 25, 2026
Meera Shrimankar added 2 commits August 25, 2026 07:58
@mshrimankar10

mshrimankar10 commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor Author
  1. Scoped the suppressions (readme.md)
    The two LintDiff suppressions are no longer file-wide — each now carries a where: targeting only the two new /listKeys paths, so they can't mask violations anywhere else in expressRoute.json:

ResourceNameRestriction (error) — scoped to:
…/expressRouteCircuits/{circuitName}/authorizations/{authorizationName}/listKeys
…/expressRoutePorts/{expressRoutePortName}/authorizations/{authorizationName}/listKeys
LatestVersionOfCommonTypesMustBeUsed (warning) — scoped to the same two paths.
circuitName, authorizationName, and expressRoutePortName are existing parent/resource path parameters that shipped in prior GA versions without a pattern restriction; adding one now would be a breaking change, and they're referenced by all existing ExpressRoute circuit/port authorization APIs. (These will need the Approved-Suppression label.)

  1. secret applied where the real key is exposed

The unmasked authorization key is returned only by the new listKeys POST actions. Its response model is marked secret, so the generated swagger emits format: password + x-ms-secret: true:

Confirming GET/LIST never return an unmasked key: the existing authorizationKey on AuthorizationPropertiesFormat (circuit) and ExpressRoutePortAuthorizationPropertiesFormat (port) always returns a masked value at runtime. I will take care the changes in this APIs as part of separate PRs if needed

@mshrimankar10 mshrimankar10 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Aug 25, 2026
@github-actions

Copy link
Copy Markdown

ARM API Review Summary

Reviewed PR #45679 at head SHA 9a3d7ad323fa39b0abecfd67d391ade0ad809cf8 | Triggered by: pull_request_target

Approval labels observed: none.

Category Count
🔴 Blocking 0
🟠 Warning 0
🔵 Suggestion 0

Prior findings (lowercase listkeys action segment, terse property description, unscoped readme.md suppressions) have all been fixed in the latest push. The only outstanding item is the Approved-Suppression label requirement for the two scoped readme.md suppressions (ResourceNameRestriction, LatestVersionOfCommonTypesMustBeUsed); the pre-existing secret-prop suppression on legacy authorizationKey fields is noted for future follow-up but is out of scope for this PR.

posted-by: arm-api-reviewer-agent | rule: summary | severity: warning | classification: existing | critic: unknown | head-sha: 9a3d7ad

🔍 ARM API review by ARM API Review: Automated Workflow

@github-actions

Copy link
Copy Markdown

Following up on #45679 (comment) and the author's response above: at head commit 9a3d7ad323fa39b0abecfd67d391ade0ad809cf8 both readme.md suppressions (ResourceNameRestriction, LatestVersionOfCommonTypesMustBeUsed) now carry a where: clause scoped to only the two new /listKeys paths, resolving the file-wide-suppression concern. The new ExpressRouteAuthorizationKey.authorizationKey property (common.json) correctly emits format: password and x-ms-secret: true, so the retrievable secret is isolated to the dedicated listKeys POST action.

Approval context: These two suppressions still require the Approved-Suppression label; no matching label was observed on the PR at this session SHA. If suppression approval has been granted, please apply Approved-Suppression and resolve this conversation; otherwise obtain approval before merge.

The pre-existing secret-prop suppression on AuthorizationPropertiesFormat.authorizationKey / ExpressRoutePortAuthorizationPropertiesFormat.authorizationKey (models.tsp) predates this PR and is out of scope for this change per the author's plan to address it separately; noted for awareness only, not a blocking finding here.

posted-by: arm-api-reviewer-agent | rule: SEC-SECRET-DETECT | severity: warning | classification: existing | critic: unknown | head-sha: 9a3d7ad

🔍 ARM API review by ARM API Review: Automated Workflow

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM API Review

Posting findings from the ARM API Reviewer agent (Critic unavailable; reviewer self-check only, 1 iteration(s), no new blocking findings) against commit 9a3d7ad323fa39b0abecfd67d391ade0ad809cf8. All findings are reported in the summary comment.

Approval labels observed: none.

🔍 ARM API review by ARM API Review: Automated Workflow

@mshrimankar10

Copy link
Copy Markdown
Contributor Author

Added suppression reasons

@github-actions

Copy link
Copy Markdown

Following up on the prior clarification: at head commit 316cf77621c91adafdf12ad3aa57c8aefdba51c7 both secret-prop suppression reasons on AuthorizationPropertiesFormat.authorizationKey (models.tsp L10917) and ExpressRoutePortAuthorizationPropertiesFormat.authorizationKey (models.tsp L12181) have been replaced with a concrete, factual rationale — the placeholder FIXME: Update justification text is gone. No further action needed on this item.

The scoped ResourceNameRestriction suppression on the two new /listKeys paths (readme.md, with a where: clause limiting it to those paths) remains in place and continues to look reasonable for peer approval. It still requires the Approved-Suppression label before merge — no matching label is observed on the PR at this session SHA (Approved-Avocado is present but is a different approval category and does not satisfy Approved-Suppression).

Approval context: No Approved-Suppression label is present at the current head. If suppression approval has been granted, please apply the label and resolve this conversation; otherwise obtain approval before merge.

posted-by: arm-api-reviewer-agent | reconciliation: clarification | critic: unknown | head-sha: 316cf77

🔍 ARM API review by ARM API Review: Automated Workflow

@github-actions

Copy link
Copy Markdown

ARM API Review Summary

Reviewed PR #45679 at head SHA 316cf77621c91adafdf12ad3aa57c8aefdba51c7 | Triggered by: pull_request_target

Approval labels observed: none (Approved-Avocado is present but is not Approved-Suppression, Approved-TypeSpecSuppression, BreakingChange-Approved-*, or Versioning-Approved-*).

Category Count
🔴 Blocking 0
🟠 Warning 0
🔵 Suggestion 0

Reconciliation against all existing discussion surfaces (inline review threads, top-level comments, review bodies) found no new, uncovered findings at this head SHA. The most recent author push (Added suppression reasons) replaced the placeholder FIXME: Update justification text on both secret-prop suppressions in models.tsp (L10917, L12181) with a concrete, factual rationale, resolving that outstanding clarification (clarified above, SKIP-COVERED/resolved-by-fix). The scoped ResourceNameRestriction suppression on the two new listKeys paths (readme.md) remains and still needs the Approved-Suppression label. The pre-existing Section 11.1 Swagger Avocado MULTIPLE_API_VERSION finding on stable/2018-10-01/vmssNetwork.json remains open and unaddressed at this head SHA; it is pre-existing (also present at the PR's base SHA) and is not reposted here to avoid duplication.

Note: The Mandatory Critic Review (Step 5.6) subagent's required binding protocol files were unavailable in this environment across prior runs; consistent with that history, no Blocking findings are candidates for posting in this run, so no downgrade was necessary. critic: unknown is disclosed here per the fallback rule.

posted-by: arm-api-reviewer-agent | rule: summary | severity: suggestion | classification: existing | critic: unknown | head-sha: 316cf77

🔍 ARM API review by ARM API Review: Automated Workflow

@github-actions

Copy link
Copy Markdown

ARM API Review Summary

Reviewed PR #45679 at head SHA 4ecc638d9a15fc1c434088e741832a324ccaadc5 | Triggered by: labeled/comment

Approval labels observed: none.

Category Count
🔴 Blocking 0
🟠 Warning 0
🔵 Suggestion 1

This PR adds listKeys POST actions for ExpressRoute circuit and port authorizations, following ARM secret-handling conventions correctly: the new ExpressRouteAuthorizationKey response model is annotated with @secret (TypeSpec) / x-ms-secret: true + format: password (swagger) 7.2, both actions are named with the list prefix per 12.1, return synchronous 200 with a response schema per 12.1, and are correctly versioned via @added(Versions.v2026_01_01) per 11.2. The pre-existing unannotated authorizationKey property retains its existing suppression with an updated, clearer justification — this is an [EXISTING] item, not a new violation. The new ResourceNameRestriction suppression in readme.md is scoped to the two new paths and justified by pre-existing unpatterned path parameters.

🔵 Suggestion: Consider whether the pre-existing authorizationKey field returned unmasked/masked by caller privilege (rather than API contract) could eventually be deprecated/nulled in favor of the new listKeys action exclusively, per 7.1 long-term guidance — not required for this PR since it would be a breaking change to the existing GA contract.

No blocking or warning issues found. The BreakingChange-Go-Sdk/BreakingChange-JavaScript-Sdk labels present on the PR appear unrelated to the additive changes reviewed here (new operations/models only); no approval label was required or observed for this review's findings.

posted-by: arm-api-reviewer-agent | rule: summary | severity: suggestion | classification: new | critic: unknown | head-sha: 4ecc638

🔍 ARM API review by ARM API Review: Automated Workflow

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM API Review

Posting findings from the ARM API Reviewer agent (Critic unavailable; reviewer self-check only, 1 iteration(s), no blocking findings) against commit 4ecc638d9a15fc1c434088e741832a324ccaadc5. All findings are reported in the summary comment.

Approval labels observed: none.

🔍 ARM API review by ARM API Review: Automated Workflow

@sandipsh Sandip Shahane (sandipsh) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM API Review

Posting findings from the ARM API Reviewer agent (critic-verified, 2 iteration(s), converged) against commit 4ecc638. See inline comments for findings 2-3.

Approval labels observed: none.

"responses": {
"200": {
"body": {
"authorizationKey": "authkey"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NEW] 🟠 Warning [EX-SECRET-PLACEHOLDER] specification/network/resource-manager/Microsoft.Network/Network/Network/examples/2026-01-01/ExpressRouteCircuitAuthorizationListKeys.json - line 12 - authkey is ambiguous for a credential example and can be mistaken for a usable value in generated docs or samples.

Classification reasoning: Introduced in this PR; this example does not exist at base SHA 7148691c2f2ae4ca4252dda9f6c2d1ec57e7c917.

Suggested fix: Use an unmistakably fake placeholder such as "{api-key}" or "********", then regenerate the emitted example.

"responses": {
"200": {
"body": {
"authorizationKey": "authkey"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NEW] 🟠 Warning [EX-SECRET-PLACEHOLDER] specification/network/resource-manager/Microsoft.Network/Network/Network/examples/2026-01-01/ExpressRoutePortAuthorizationListKeys.json - line 12 - authkey is ambiguous for a credential example and can be mistaken for a usable value in generated docs or samples.

Classification reasoning: Introduced in this PR; this example does not exist at base SHA 7148691c2f2ae4ca4252dda9f6c2d1ec57e7c917.

Suggested fix: Use an unmistakably fake placeholder such as "{api-key}" or "********", then regenerate the emitted example.

@sandipsh Sandip Shahane (sandipsh) added Approved-Suppression ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 27, 2026
@github-actions github-actions Bot added ARMAutoSignedOff-IncrementalTSP ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested labels Aug 27, 2026
@github-actions github-actions Bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMAutoSignedOff-IncrementalTSP ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMAutoSignedOff-IncrementalTSP ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Go-Sdk BreakingChange-JavaScript-Sdk WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 28, 2026
@santoshgh317
santoshgh317 self-requested a review August 31, 2026 05:32
@santoshgh317
santoshgh317 merged commit bf19160 into Azure:release-microsoft-network-2026-01-01 Aug 31, 2026
50 of 51 checks passed
@santoshgh317 santoshgh317 mentioned this pull request Sep 3, 2026
5 of 9 tasks
santoshgh317 added a commit that referenced this pull request Sep 15, 2026
* Add API version 2026-01-01 for Microsoft.Network (#45569)

Co-authored-by: Santosh Lokarapu <v-slokar@microsoft.com>

* Add Enum values for VPN migrationType (#45647)

Co-authored-by: Akshat Kale <akale@microsoft.com>

* Fix Bug 38477992: type computedDisabledRules.rules as integers (2026-01-01) (#45621)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: yaarark <178404435+yaarark@users.noreply.github.com>
Copilot-Session: 29f2cbb3-29c5-444f-837b-9f5efa9782a3

* [Network] Add WAF rule paranoiaLevel and rule set displayName to 2026-01-01 (#45625)

* Add WAF rule paranoiaLevel and rule set displayName to 2026-01-01

Ports the change from azure-rest-api-specs-pr PR 29807 onto the public
2026-01-01 release branch.

Adds three read-only properties that NRP surfaces from api-version
2026-01-01 for Application Gateway WAF:

- paranoiaLevel on ApplicationGatewayFirewallRule
- displayName on ApplicationGatewayFirewallRuleSetPropertiesFormat
- displayName on ApplicationGatewayFirewallManifestRuleSet
- displayName on DefaultRuleSetPropertyFormat

paranoiaLevel uses a new extensible enum ApplicationGatewayWafRuleParanoiaLevel
with values PL1 to PL4.

All new members are annotated with @added(Versions.v2026_01_01). The change is
additive and all new properties are optional.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Retrigger CI

The SDK Validation - Rust build failed on a transient GitHub timeout
while installing the Azure SDK Tools CLI. Nothing in the spec changed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Shai Goldbourt <shgoldbourt@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Centurion WAF: add WAF policy tier + Basic_v2/Basic_WAF_v2 SKUs (2026-01-01) (#45766)

* Add Centurion WAF updates for 2026-01-01

Update WAF policy tier and reserved capacity support.

Add Basic_v2 and Basic_WAF_v2 SKUs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add Basic v2 application gateway tiers

WebApplicationFirewallPolicyTier ordering aligns Standard=0 and Basic=1.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add Basic WAF and application gateway examples

Add Basic WAF policy create/get examples and Basic-tier coverage.

Add Basic_v2 and Basic_WAF_v2 application gateway create/get examples, including reservedCapacity and WAF policy association.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add AuthenticationPolicy resource and Application Gateway authConfigs binding for 2026-01-01 (#45764)

* Add AuthenticationPolicy support for 2026-01-01

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8c9963e3-6d51-4873-bdf8-95fb546098c3

* Align AuthenticationPolicy contract with service behavior

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8c9963e3-6d51-4873-bdf8-95fb546098c3

* Enforce AuthenticationPolicy name and binding constraints

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8c9963e3-6d51-4873-bdf8-95fb546098c3

* Add authentication policy tags update

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8c9963e3-6d51-4873-bdf8-95fb546098c3

---------

Copilot-Session: 8c9963e3-6d51-4873-bdf8-95fb546098c3

* Add minAllocationSize and maxAllocationSize to IpamPool for 2026-01-01 (#45650)

* Add minAllocationSize and maxAllocationSize to IpamPool for 2026-01-01

Adds optional min/max allocation-size bounds to the Microsoft.Network
IpamPool resource in api-version 2026-01-01:

- IpamPoolProperties (PUT/GET): minAllocationSize, maxAllocationSize
- IpamPoolUpdateProperties (PATCH): minAllocationSize, maxAllocationSize
  marked x-nullable so an explicit null clears the bound while an absent
  bound is preserved, per ARM merge-patch semantics.

Both properties are gated with @added(Versions.v2026_01_01) so earlier
api-versions are unchanged. Regenerated virtualNetwork.json and updated
the 2026-01-01 IpamPools Create/Get/List/Update examples.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Move min/max allocation size into dedicated IpamPool examples

The allocation-size bounds are optional, so the baseline IpamPools
examples should not imply they are always supplied. Restores
IpamPools_Create/Get/List/Update to their original content and adds
dedicated examples that exercise the feature:

- IpamPools_CreateWithAllocationBounds.json: PUT setting both bounds.
- IpamPools_UpdateAllocationBounds.json: PATCH setting both bounds.
- IpamPools_UpdateClearAllocationBounds.json: PATCH clearing both
  bounds with an explicit null, per ARM merge-patch semantics.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Address ARM review: drop nullable union on new min/max update properties

New properties must not use a nullable union, since backward
compatibility does not apply to additions. The RP already treats an
empty string as a clear on PATCH, so the explicit null is unnecessary.

- IpamPoolUpdateProperties min/maxAllocationSize: string | null -> string,
  removing the no-nullable suppressions and x-nullable from the swagger.
- Document clearing via an empty string.
- IpamPools_UpdateClearAllocationBounds example now clears with "".

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Add Swagger Avocado suppression for frozen 2018-10-01 VMSS surface

Per ARM reviewer guidance on PR #45650: the package-2026-01-01 default
tag intentionally retains stable/2018-10-01/vmssNetwork.json for
backward compatibility, which trips Avocado's MULTIPLE_API_VERSION rule.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Fix Avocado suppression tool name to SwaggerAvocado

Per ARM reviewer bot feedback on PR #45650: the suppression tool name
has no space.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Add approvalReference to private endpoint connection in 2026-01-01 (#45604)

* Add approvalReference (create-only) to private endpoint connection in 2026-01-01

Adds optional approvalReference.privateEndpointId to PrivateLinkServiceConnectionProperties, gated @added(v2026_01_01) with @visibility(Lifecycle.Read, Lifecycle.Create) so it is create-only (emits x-ms-mutability: [read, create]) and is not resupplied on update.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8a51a230-76ca-454e-a1d9-4bd6b37f202a

* Regenerate vmssNetwork.json for approvalReference (Vmss project)

The Vmss TypeSpec project shares PrivateLinkServiceConnectionProperties and emits stable/2018-10-01/vmssNetwork.json, which must be regenerated so approvalReference/ApprovalReference are included. Fixes TypeSpec Validation (Vmss).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8a51a230-76ca-454e-a1d9-4bd6b37f202a

* Remove x-ms-mutability (create-only) from approvalReference

Per internal discussion, drop the create-only mutability restriction on
approvalReference. Removes the @visibility(Lifecycle.Read, Lifecycle.Create)
decorator in Common/main.tsp and regenerates the Network and Vmss project
swaggers so x-ms-mutability is no longer emitted. The approvalReference
property and ApprovalReference model are retained.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8a51a230-76ca-454e-a1d9-4bd6b37f202a

* Type approvalReference.privateEndpointId as armResourceIdentifier

Address ARM review finding [TSP-ARM-RESOURCE-ID]: privateEndpointId references an existing private endpoint, so type it as Azure.Core.armResourceIdentifier<Microsoft.Network/privateEndpoints> instead of plain string. Regenerated swagger emits format: arm-id and x-ms-arm-id-details.allowedResources.

---------

Co-authored-by: Ajoy Duwary (from Dev Box) <ajoyduwary@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8a51a230-76ca-454e-a1d9-4bd6b37f202a

* Add ExpressRoutCircuit on ExpressRouteLag (#45689)

* Add ExpressRoutCircuit on ExpressRouteLag

* Fix ExpressRouteLag examples: sync circuits to output copies and remove invalid circuit properties

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* Align ExpressRouteCircuitCreateOnExpressRouteLag responses with request (EX-PARAM-CONSISTENCY)

Fix response bodies to match request: LAG reference lagName (was test),
enableDirectPortRateLimit true, and SKU Premium_MeteredData in the 200 response.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Meera Shrimankar <mshrimankar@microsoft.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

* Add AppGw Advanced Routing Rule in NRR API 2026-01-01 (#45844)

* Add advanced routing features to Application Gateway for API version 2026-01-01

* buid artifacts after changes to models.tsp

* added examples

* fix merge conflict

---------

Co-authored-by: Paawan Kohli <paawankohli@microsoft.com>

* Modify sdk-suppressions.yaml for breaking changes (#45914)

Updated breaking changes for Azure SDK suppressions in network resource manager.

* [Microsoft.Network] Add provider-led ExpressRoute circuit migration APIs (#45905)

* Add ExpressRoute circuit migration APIs

Add TypeSpec operations and models for provider-led ExpressRoute circuit migration, generated 2026-01-01 Swagger, examples, and the scoped brownfield resource-name suppression.

* Fix Network specification validation

Use valid UUID subscription IDs, add required TypeSpec example metadata, regenerate migration LRO metadata, and suppress the intentional mixed-version VMSS surface in the combined Network package.

* Fix Network Avocado suppression

Move the mixed API-version exception from an unsupported AutoRest directive to the Network SwaggerAvocado path-suppression file, scoped to the default-tag readme.

* Fix Network validation suppressions

* Correct Avocado suppression identifier

* Geo-Ip filter changes (#45631)

* Geo Ip Filter Changes

* Document GeoIP filter format (ISO 3166-1 alpha-2) and fix WAF scrubbing-rule model

* Fixing Swagger ModelValidation Filure related errors

* Dummy Push to reinitate build

* Type Spec validation failure fix

* Remove duplicate GeoIP filter properties

---------

Co-authored-by: Kshitiz Mathur <kshmathur@microsoft.com>

* Add NeuroShield API for 2026-01-01 (#45722)

* Add NeuroShield API for 2026-01-01

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add NeuroShield API for 2026-01-01

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 0f50978e-4a9f-439e-bdb8-4a0e00eb02ac

* Align NeuroShield contract with service behavior

Require customer-facing configuration, align mitigation responses with the safe service projection, make cancellation synchronous, and correct protected-resource delete polling.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 0f50978e-4a9f-439e-bdb8-4a0e00eb02ac

* Refine NeuroShield 2026-01-01 contract

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 0f50978e-4a9f-439e-bdb8-4a0e00eb02ac

* Fix NeuroShield validation regressions

* Address ARM review feedback for NeuroShield

Use supported ARM resource templates, scope Swagger suppressions to exact operations, and isolate inherited Network validation debt.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0f50978e-4a9f-439e-bdb8-4a0e00eb02ac

* Fix NeuroShield LintDiff suppressions

* Use standard ARM entity tag property

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 0f50978e-4a9f-439e-bdb8-4a0e00eb02ac

* Add post calls for auth key of authorization objects for expressrouteciruits and expressrouteports (#45679)

* Added post calls for expressroute auth key

* Added the objects in 2026-01-01 version

* addressed ai comments

* Addressed comments

* fixed

* removed suppression

* fixed suppressions

---------

Co-authored-by: Meera Shrimankar <mshrimankar@microsoft.com>
Co-authored-by: ZiWei Chen <98569699+kazrael2119@users.noreply.github.com>

* Fix Hub virtual network IPv6 peering contract (#45637)

* Fix IPv6 peering contract for Network 2026-01-01
* Correct IPv6 peering contract in Network 2025-09-01
* Update client.tsp

* Update sdk-suppressions.yaml

---------

Co-authored-by: Caren Lim <carenlim@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>

* Correct AuthenticationPolicy contract for 2026-01-01 (#45892)

* Correct authentication policy contract

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8c9963e3-6d51-4873-bdf8-95fb546098c3

* Keep provider type extensible

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8c9963e3-6d51-4873-bdf8-95fb546098c3

* Document authentication policy constraints

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8c9963e3-6d51-4873-bdf8-95fb546098c3

* Align authentication examples with service

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8c9963e3-6d51-4873-bdf8-95fb546098c3

* Restore authentication policy tags update

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8c9963e3-6d51-4873-bdf8-95fb546098c3

* Suppress PatchIdentityProperty for AuthenticationPolicies_UpdateTags

The tags-only PATCH takes the shared Network RP TagsObject body, matching
ApplicationGateways_UpdateTags. The service only updates tags on this
operation, so identity does not belong in the request body.

* Complete authentication policy constraints

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8c9963e3-6d51-4873-bdf8-95fb546098c3

* Correct Basic v2 authentication example

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 8c9963e3-6d51-4873-bdf8-95fb546098c3

* Address ARM review feedback on AuthenticationPolicy 2026-01-01

- Make the arm-resource-invalid-envelope-property suppression reason self-contained by stating why the user-assigned identity belongs in the resource envelope.
- Scope the PatchIdentityProperty suppression with a where: clause targeting the AuthenticationPolicies_UpdateTags PATCH operation.
- Type issuer as url and require an https scheme, consistent with jwksUri and clientSecret.
- Document the sessionTimeout string syntax and units, and constrain it with a base-10 integer pattern and max length.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Also scope PatchIdentityProperty suppression to the PATCH body parameter path

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Remove AuthenticationPolicy PATCH operation

The service supports only GET, PUT, and DELETE for authenticationPolicies,
matching ApplicationGatewayWebApplicationFirewallPolicies, which also ships
without a PATCH. Removing the tags-only PATCH also resolves the
PatchIdentityProperty finding at its source: that rule fires only on an
existing PATCH, so with no PATCH the identity envelope property no longer
needs a suppression.

- Remove AuthenticationPolicies_UpdateTags and its source and generated examples.
- Drop the PatchIdentityProperty suppression.
- Restore the TrackedResourcePatchOperation no-PATCH suppression.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Drop stale PATCH path from ProvisioningStateMustBeReadOnly suppression

The AuthenticationPolicy PATCH operation was removed, so the patch response
entry in the where: list no longer matches anything.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Restore AuthenticationPolicy PATCH with a resource-specific update model

AuthenticationPolicy is a tracked resource: it extends the Network RP
Resource base type, which supplies location, tags and x-ms-azure-resource.
ARM requires resource providers to support PATCH for updating tags on a
tracked resource, so removing the operation was incorrect.

Restore PATCH using a resource-specific AuthenticationPolicyUpdateParameters
model carrying both tags and identity, rather than the shared TagsObject.
This satisfies the tracked-resource tags requirement and the MSI onboarding
requirement that the control plane accept identity updates on PATCH, which
means PatchIdentityProperty is now satisfied at the source and needs no
suppression.

- Add AuthenticationPolicyUpdateParameters (tags, identity).
- Add AuthenticationPolicies_Update, replacing the former tags-only
  AuthenticationPolicies_UpdateTags.
- Add an example exercising both tags and identity updates.
- Drop the TrackedResourcePatchOperation suppression, no longer applicable.
- Scope ProvisioningStateMustBeReadOnly to the new PATCH 200 response schema.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8c9963e3-6d51-4873-bdf8-95fb546098c3

* Add bastion session recording configuration and identity properties (#45630)

* Add bastion session recording configuration property

* Fix the patch body for identity support

* Update examples

* Fix prettier violation

* Revert documentation changes

* Add BastionHostUpdate model instead of anonymous type

* Add tpye constraint for userAssignedIdentityId

* Fix invalid arm id for public ip in example

* Fix wrong name in 200 responses in new examples

* Fix documentation for BastionHostUpdate

* Preserve existing updateTags operation

* Update suppression justification

* Revert previous changes which maintained the old operation

* Update suppression justification for update operation

---------

Co-authored-by: Matthew Lee <matthelee@microsoft.com>

* Add azureFirewall enableAiAddOn (#45976)

* Add azureFirewall enableAiAddOn

* Enable aiSecurityAddOn in Azure Firewall configuration

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* copilot messed up, fix typescript

* fix fields in exampels

* fix fields in examples

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Revert "Add NeuroShield API for 2026-01-01 (#45722)" (#46208)

This reverts commit efb6f29.

* Address swagger review findings on AuthenticationPolicy for 2026-01-01 (#46260)

* Address swagger review findings on AuthenticationPolicy

Resolves five of the review findings at the source rather than by
suppression, removing four AuthenticationPolicy suppressions.

RequiredReadOnlySystemData: declare systemData explicitly on
AuthenticationPolicy, following the existing Network RP pattern used by
AdminRuleCollection, BaseAdminRule and Commit. It is emitted read-only.

RPC-Delete-V1-01: drop the ArmDeletedNoContentResponse override so the
sync DELETE emits 200, 204 and default. AuthenticationPolicy was the only
resource in this project overriding the delete response; every sibling
uses the default. Removes the DeleteResponseCodes and
DeleteOperationResponses suppressions.

SEC-SECRET-DETECT: remove the secret-prop suppression. The rule only
fires on properties typed as the builtin string, and clientSecret is
typed url, so the suppression had no effect. The property holds only a
Key Vault reference, which the documentation now states explicitly. The
XMSSecretInResponse suppression is also removed, as nothing in the
generated file is marked x-ms-secret.

RPC-SUPPRESS-SCOPE: scope RequiredPropertiesMissingInResourceModel to
$.definitions.AuthenticationPolicy, and explain why
LatestVersionOfCommonTypesMustBeUsed stays file-level: the common-types
version is pinned package-wide by arm-types-dir, so the finding applies
to every common-types reference in the file rather than to any single
definition.

Section 4.1: document the authenticationPolicy Features member instead of
suppressing documentation-required, and replace the placeholder FIXME
justification on WebApplicationFirewallPolicyTier with a real one.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Fix LintDiff and ModelValidation failures on AuthenticationPolicy 2026-01-01

Three CI failures introduced by the previous review-feedback commit:

1. LintDiff RequiredPropertiesMissingInResourceModel: the where: scope added
   for this rule only covered $.definitions.AuthenticationPolicy, but the rule
   also fires on AuthenticationPolicyListResult. Added that definition to the
   scope and extended the reason to explain that the list result is a paged
   envelope rather than a resource.

2. LintDiff XMSSecretInResponse on clientSecret: removing the TypeSpec
   secret-prop suppression did not clear this because the swagger rule matches
   purely on the property name ending in a sensitive keyword. The property only
   ever carries an absolute HTTPS Key Vault reference URL, never secret
   material, so annotating it with x-ms-secret would be incorrect - it would
   stop the service returning the reference in GET. Renamed the property to
   clientSecretUrl, which both clears the rule without any suppression and
   describes the value accurately. 2026-01-01 is not yet published, so the
   rename carries no breaking-change cost.

3. ModelValidation RESPONSE_STATUS_CODE_NOT_IN_EXAMPLE: the delete operation
   now declares a 200 response, so AuthenticationPolicyDelete.json needs a
   matching (bodyless) 200 entry alongside the existing 204.

Swagger Avocado remains failing with MULTIPLE_API_VERSION on the
package-2026-01-01 tag. That failure reproduces on the base release branch PR
(#46086) and is unrelated to this change.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Rename clientSecretUrl to clientSecretUri

TypeSpec Validation compiles client.tsp with --warn-as-error, which surfaces
@azure-tools/typespec-client-generator-core/csharp-no-url-suffix: properties
ending in 'Url' must use the 'Uri' suffix so the generated C# surface is
idiomatic. The local emit-only compile of the Network project does not run
client.tsp, so this was missed.

clientSecretUri still avoids the LintDiff XMSSecretInResponse keyword match,
which only fires on names ending in a sensitive keyword.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Revert clientSecret rename and suppress XMSSecretInResponse instead

The rename to clientSecretUrl/clientSecretUri was wrong. The property name is
part of the contract already implemented by the Network resource provider, so
the spec has to match NRP rather than pick a name that happens to dodge the
linter's keyword match. Reverted to clientSecret.

To keep LintDiff green, XMSSecretInResponse is suppressed instead, scoped to
$.definitions.AuthenticationProviderProperties.properties.clientSecret. The
justification is substantive rather than a waiver: the property carries only an
absolute HTTPS Key Vault secret URL, never secret material - the secret value is
read from Key Vault at runtime using the resource's user-assigned identity and
is never accepted or returned by this API. Annotating it with x-ms-secret would
be actively incorrect, because that would stop the service returning the Key
Vault reference on GET, which callers need in order to see how a policy is
configured.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Santosh Lokarapu <v-slokar@microsoft.com>
Co-authored-by: Akshat Kale <kaleakshat@gmail.com>
Co-authored-by: Akshat Kale <akale@microsoft.com>
Co-authored-by: yaarark <yaararonenkr@gmail.com>
Co-authored-by: yaarark <178404435+yaarark@users.noreply.github.com>
Co-authored-by: Shaigoldbourt22 <118125561+Shaigoldbourt22@users.noreply.github.com>
Co-authored-by: Shai Goldbourt <shgoldbourt@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: baoqihuang0326 <119557638+baoqihuang0326@users.noreply.github.com>
Co-authored-by: Arjun Patel <94936045+arjun-d-patel@users.noreply.github.com>
Co-authored-by: ajoyduwary <ajoyduwary@gmail.com>
Co-authored-by: Ajoy Duwary (from Dev Box) <ajoyduwary@microsoft.com>
Co-authored-by: mshrimankar10 <66165250+mshrimankar10@users.noreply.github.com>
Co-authored-by: Meera Shrimankar <mshrimankar@microsoft.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: paawankohli <44478509+paawankohli@users.noreply.github.com>
Co-authored-by: Paawan Kohli <paawankohli@microsoft.com>
Co-authored-by: ZiWei Chen <98569699+kazrael2119@users.noreply.github.com>
Co-authored-by: gurram-amulya <111553857+gurram-amulya@users.noreply.github.com>
Co-authored-by: kshitizmathur-max <kshitiz.mathur@gmail.com>
Co-authored-by: Kshitiz Mathur <kshmathur@microsoft.com>
Co-authored-by: Satya-Kotha1008 <sathi.kotha1008@gmail.com>
Co-authored-by: carenlim20 <carenlim+github@microsoft.com>
Co-authored-by: Caren Lim <carenlim@microsoft.com>
Co-authored-by: Matthew Lee <mwlee29@gmail.com>
Co-authored-by: Matthew Lee <matthelee@microsoft.com>
Co-authored-by: Ben Eshed <105308016+bewatersmsft@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot-Session: 29f2cbb3-29c5-444f-837b-9f5efa9782a3
Copilot-Session: 8c9963e3-6d51-4873-bdf8-95fb546098c3
Copilot-Session: 8a51a230-76ca-454e-a1d9-4bd6b37f202a
Copilot-Session: 0f50978e-4a9f-439e-bdb8-4a0e00eb02ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants