Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventGrid: Update README files to include the current new preview api… #4235

Merged
merged 6 commits into from
Oct 18, 2018
Merged

Conversation

ahamad-MS
Copy link
Contributor

… version 2018-09-preview

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Oct 15, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2902

@AutorestCI
Copy link

AutorestCI commented Oct 15, 2018

Automation for azure-sdk-for-js

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-js#225

@AutorestCI
Copy link

AutorestCI commented Oct 15, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#3067

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Oct 15, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3895

- tag: package-2018-05-preview
- tag: package-2018-01
- tag: package-2017-09-preview
- tag: package-2017-06-preview
```

### Tag: package-2018-09-preview and go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the latest readme.me in the master, it looks like the Go configuration has been branched out to a separate file. It looks like you need to sync those changes in your branch and this change needs to happen in the GO specific readme file.

@kalyanaj
Copy link
Contributor

The linter error is a known issue in the ARM validation: Azure/azure-openapi-arm-validator#10.

@praries880
Copy link

@azuresdkci add to whitelist

Copy link
Contributor

@kalyanaj kalyanaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kalyanaj
Copy link
Contributor

@praries880, the "Automation for azure-sdk-for-go" CI step seems to be failing, however reviewing the readme.go.md file, the keys seem to be unique and we can't find what the issue is. Can you please help us with this issue?

@praries880
Copy link

praries880 commented Oct 16, 2018

@ahamad-MS you need to fix the ARM validation error : https://github.com/Azure/azure-rest-api-specs/pull/4235/checks?check_run_id=23938472 to get green on the CI

Heres the error :

  R3026 - TrackedResourcePatchOperation 2018-09-15-preview/​EventGrid.json:2134 Tracked resource 'Domain' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well.

@veronicagg Do you know why was the linter error in the json not caught earlier?

@kalyanaj
Copy link
Contributor

@praries880, please see my earlier comment above: the linter error is a known issue in the ARM validation: Azure/azure-openapi-arm-validator#10 and is being tracked by the ARM team.

@praries880
Copy link

@jhendrixMSFT Can you help merge the PR in? I seem to lack the required permissions.

@jhendrixMSFT jhendrixMSFT merged commit fab522f into Azure:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants