Use namespace varible for package folder instead of hardcoding it #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladbarosan
requested review from
hitenjava,
MikhailTryakhov,
kay-owolabi,
schaabs and
yangyuan
as code owners
Automation for azure-sdk-for-pythonThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
vladbarosan
force-pushed
the
useNamespaceForGo
branch
from
e3083b9 to
3c0faf6
Compare
| @@ -114,7 +114,7 @@ Please also specify `--go-sdk-folder=<path to the root directory of your azure-s | |||
|
|
|||
| ``` yaml $(tag)=='package-skus-2017-09' && $(go) | |||
| namespace: skus | |||
| output-folder: $(go-sdk-folder)/services/compute/mgmt/2017-09-01/skus | |||
| output-folder: $(go-sdk-folder)/services/$(namespace)/mgmt/2017-09-01/skus | |||
There was a problem hiding this comment.
This one is wrong. #Resolved
| @@ -22,5 +22,5 @@ These settings apply only when `--tag=package-2018-03-preview --go` is specified | |||
| Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`. | |||
|
|
|||
| ``` yaml $(tag)=='package-2018-03-preview' && $(go) | |||
| output-folder: $(go-sdk-folder)/services/preview/machinelearning/mgmt/2018-03-01-preview/services | |||
| output-folder: $(go-sdk-folder)/$(namespace)/preview/machinelearning/mgmt/2018-03-01-preview/$(namespace) | |||
There was a problem hiding this comment.
While the path is technically correct the /services/ should remain hard-coded. #Resolved
| @@ -25,7 +25,7 @@ These settings apply only when `--tag=package-2015-10 --go` is specified on the | |||
| Please also specify the `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`. | |||
|
|
|||
| ``` yaml $(tag) == 'package-2015-10' && $(go) | |||
| output-folder: $(go-sdk-folder)/services/mediaservices/mgmt/2015-10-01/media | |||
| output-folder: $(go-sdk-folder)/services/$(namespace)services/mgmt/2015-10-01/$(namespace) | |||
There was a problem hiding this comment.
Another "kinda right", applied to entire file. #Resolved
Automation for azure-sdk-for-jsThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
|
Can one of the admins verify this patch? |
vladbarosan
commented
Oct 10, 2018
| @@ -22,5 +22,5 @@ These settings apply only when `--tag=package-2017-06 --go` is specified on the | |||
| Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`. | |||
|
|
|||
| ``` yaml $(tag) == 'package-2017-06' && $(go) | |||
| output-folder: $(go-sdk-folder)/services/storsimple8000series/mgmt/2017-06-01/storsimple | |||
| output-folder: $(go-sdk-folder)/services/$(namespace)8000series/mgmt/2017-06-01/$(namespace) | |||
There was a problem hiding this comment.
8000series [](start = 53, length = 10)
here also
| @@ -22,5 +22,5 @@ These settings apply only when `--tag=package-2016-10 --go` is specified on the | |||
| Please also specify `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`. | |||
|
|
|||
| ``` yaml $(tag) == 'package-2016-10' && $(go) | |||
| output-folder: $(go-sdk-folder)/services/storsimple1200series/mgmt/2016-10-01/storsimple | |||
| output-folder: $(go-sdk-folder)/services/$(namespace)1200series/mgmt/2016-10-01/$(namespace) | |||
| ``` yaml $(tag) == 'package-2016-10' && $(go) | ||
| output-folder: $(go-sdk-folder)/services/$(namespace)1200series/mgmt/2016-10-01/$(namespace) | ||
| ```yaml $(tag) == 'package-2016-10' && $(go) | ||
| output-folder: $(go-sdk-folder)/services/$storsimple1200series/mgmt/2016-10-01/$(namespace) |
Automation for azure-sdk-for-rubyThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-nodeThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-javaThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
vladbarosan
force-pushed
the
useNamespaceForGo
branch
from
f459952 to
c5b903c
Compare
jhendrixMSFT
approved these changes
Oct 10, 2018
|
@fearthecowboy can you merge? the tools choke on the large number of commits :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.