Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding version 2018-07-01 for Microsoft.Media #3980

Merged
merged 2 commits into from
Sep 27, 2018
Merged

Adding version 2018-07-01 for Microsoft.Media #3980

merged 2 commits into from
Sep 27, 2018

Conversation

quintinb
Copy link
Contributor

I had a merge issue with the branch for my previous pull request (#3831). Thus, I am copying my changes from that branch into this fork and submitting a new pull request to just pick up my changes and not the result of the bad merge. My previous pull request was already reviewed before the bad merge and is ready to be merged into master.

Please let me know if you have any questions or concerns.

@AutorestCI
Copy link

AutorestCI commented Sep 21, 2018

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link

AutorestCI commented Sep 21, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3446

@AutorestCI
Copy link

AutorestCI commented Sep 21, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1687

@AutorestCI
Copy link

AutorestCI commented Sep 21, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3715

@AutorestCI
Copy link

AutorestCI commented Sep 21, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2848

@AutorestCI
Copy link

AutorestCI commented Sep 21, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2200

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@anuchandy anuchandy self-assigned this Sep 21, 2018
@anuchandy
Copy link
Member

Both SDK and ARM approval is already received for same changes in the PR

Please also specify the `--go-sdk-folder=<path to the root directory of your azure-sdk-for-go clone>`.

``` yaml $(tag) == 'package-2018-07' && $(go)
output-folder: $(go-sdk-folder)/services/preview/mediaservices/mgmt/2018-07-01/media
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to release this as a preview package? All of the swaggers are in the stable directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this should be a stable package. If there is anything I need to do in the md files please let me know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Go simply remove the preview/ part from the output-folder. Not sure about the other languages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@anuchandy anuchandy merged commit 0d91b8f into Azure:master Sep 27, 2018
@jhendrixMSFT
Copy link
Member

@AutorestCI regenerate azure-sdk-for-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants