You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer. This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback). To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review For details of the ARM review, see aka.ms/azsdk/pr-arm-review
❌ The required check named SDK Validation Status has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide
I will close/reopen to try another run of JS/Python. Copilot suggests saying: ""My changes only touched CloudFrontDistribution.Management's main.ts and cloudfrontdistribution.json. The awsconnector failures are unrelated and pre-existing or environmental. Please re-run CI or address those broken builds outside the context of this link remediation PR."
@timotheeguerin@mumian@Kiranchandratrey - The build issues appear to be failures to generate readme code for Python and JS, which is not part of my changes. (I also don't have the required permissions to be able to apply the label PublishToCustomers.) Let me know how I can help follow the correct process to get this PR merged, plus several hundred other broken link corrections for awsconnector and several thousand in other APIs. Thanks!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
ARMReview
WaitForARMFeedback
This PR contains fixes to 5 broken links in 1 article. # of links fixed: 15
For request details, see 540734
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.
Click here to open a PR for only SDK configuration.