-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Restructure copilot instructions to move typespec and sdk generation to sub instruction files #39171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Restructure copilot instructions to move typespec and sdk generation to sub instruction files #39171
Conversation
…instructions to sub file
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
ronniegeraghty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. My comments are mainly nits or nice to haves.
| 4. Inform the user to follow the instructions on spec PR to get approval from API reviewers and merge the spec PR. | ||
| **Success Criteria**: Specification pull request exists | ||
|
|
||
| Follow the steps in [typespec to sdk](../../eng/common/instructions/azsdk-tools/typespec-to-sdk.instructions.md) to generate the SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we plan to merge this PR to main currently? I don't see the instructions in the linked file mentioning that the release intent scenario would use the pipeline for generation. update-version MCP tool isn't fully ready for release scenario yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't worry too too much as we state our MCP is in public preview, so there are things that are not fully supported.
This PR contains the copilot instruction restructuring to move typespec and sdk generation instructions to sub files.