Skip to content

Conversation

@praveenkuttappan
Copy link
Member

This PR contains the copilot instruction restructuring to move typespec and sdk generation instructions to sub files.

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

Copy link
Member

@ronniegeraghty ronniegeraghty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My comments are mainly nits or nice to haves.

4. Inform the user to follow the instructions on spec PR to get approval from API reviewers and merge the spec PR.
**Success Criteria**: Specification pull request exists

Follow the steps in [typespec to sdk](../../eng/common/instructions/azsdk-tools/typespec-to-sdk.instructions.md) to generate the SDK.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to merge this PR to main currently? I don't see the instructions in the linked file mentioning that the release intent scenario would use the pipeline for generation. update-version MCP tool isn't fully ready for release scenario yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't worry too too much as we state our MCP is in public preview, so there are things that are not fully supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants