Remove package-version from readme.nodejs.md and other small changes #3778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
August 28, 2018 13:45
…ServicesWebSearch
ghost
self-assigned this
ghost
requested review from
hitenjava,
MikhailTryakhov,
kay-owolabi,
schaabs and
yangyuan
as code owners
|
Can one of the admins verify this patch? |
RikkiGibson
approved these changes
Aug 30, 2018
Automation for azure-sdk-for-pythonThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-rubyThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-goThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-nodeThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-javaThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
|
@lmazuel Can you look at what is wrong with the python SDK generation? I haven't modified anything related to python in this PR, so I'm not sure why that would be causing a problem here. |
lmazuel
approved these changes
Aug 31, 2018
|
@lmazuel I appreciate the approval, but I still can't merge my PR. Do you know how to fix the check or how to override the requirement? |
|
@lmazuel Also, why does the push build pass but the pr build fail? |
|
@daschult Timeout, you don't care in this context :) |
|
@lmazuel The only reason I care is because it's blocking me from merging this PR. |
|
@daschult Sorry, I thought you had admin right for force merge a PR, didn't realize this was blocking :(. Should read more closely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger