Skip to content

[WIP][Appconfiguration] tsp migration #36878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Aug 22, 2025

This PR migrates your latest version (identified by the tag in your readme.md) of swagger to TypeSpec. We already tried our best to make sure the TypeSpec represents same as previous swagger. Since we lack the business knowledge, please validate this PR again to make sure it's functional equivalent as before. The local validation step is at Getting started | TypeSpec Azure

Besides, TypeSpec encourages to follow ARM guidelines. Therefore, some representations in your previous swagger will be fixed to follow these guidelines. When you see differences in your local validation, please keep this note in mind. This is the list you need to pay attention:

Please reach out to TypeSpec Discussions Channel if there is any help needed.


guidance

https://azure.github.io/typespec-azure/docs/migrate-swagger/01-get-started/#review-and-adjust-the-typespec

compile

cd /workspaces/azure-rest-api-specs/specification/appconfiguration/AppConfiguration.Management && npx tsv . && tsp compile .

generate normalized swagger

cd /workspaces/azure-rest-api-specs && pwsh eng/tools/typespec-migration-validation/scripts/download-main.ps1  specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/preview/2025-02-01-preview/appconfiguration.json

compare

npx tsmv /workspaces/azure-rest-api-specs/sparse-spec/specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/preview/2025-02-01-preview/ /workspaces/azure-rest-api-specs/specification/appconfiguration/resource-manager/Microsoft.AppConfiguration/preview/2025-02-01-preview/appconfiguration.json --outputFolder specification/appconfiguration-compare

Summary

issue format

@msyyc msyyc changed the title [Appconfiguration] tsp migration [WIP][Appconfiguration] tsp migration Aug 22, 2025
Copy link

github-actions bot commented Aug 22, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named Swagger PrettierCheck has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide
  • ❌ The required check named Swagger Avocado has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added resource-manager TypeSpec Authored with TypeSpec labels Aug 22, 2025
Copy link

github-actions bot commented Aug 22, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.AppConfiguration
TypeSpec Microsoft.AppConfiguration
Java com.azure.resourcemanager:azure-resourcemanager-appconfiguration
JavaScript @azure/arm-appconfiguration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resource-manager TypeSpec Authored with TypeSpec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant