Skip to content

[Compute] 2025-04-01 release #36781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

[Compute] 2025-04-01 release #36781

wants to merge 17 commits into from
+106,816 −32

Conversation

haagha
Copy link
Member

@haagha haagha commented Aug 19, 2025 •
edited by audreyttt
Loading

This is the Final TypeSpec PR for Compute 2025-04-01 release:

Still waiting for the following PR's to be approved:
#36515
#36121
#35914

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2025 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added resource-manager TypeSpec Authored with TypeSpec labels Aug 19, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2025 •
edited
Loading

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.Compute
Go sdk/resourcemanager/compute/armcompute
Java com.azure.resourcemanager:azure-resourcemanager-compute-generated
JavaScript @azure/arm-compute

@haagha haagha added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 19, 2025
@haagha haagha marked this pull request as ready for review August 19, 2025 16:25
@github-actions github-actions bot added ARMReview new-api-version WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 20, 2025
haagha and others added 3 commits August 20, 2025 21:35
@haagha
Merge branch 'main' into feature/cplat-2025-04-01-tsp
71c5420
@grizzlytheodore @haagha
Add ScaleOut API (#35914)
52de329 
* update

* suppress lintDiff

* fix parameter name

* unflatten property bag

---------

Co-authored-by: Haider Agha <64601174+haagha@users.noreply.github.com>
@sabanermsft @haagha
Adding Placement, MaxZoneCount and MaxInstancePercent for VMSS (#36121)
c027fc1 
* Adding Placement, MaxZoneCount and MaxInstancePercent

* Adding examples

* Restricting placement property to version 2025-04-01+

* Update field for maxInstancePercentPerZonePolicy

* Suppress BodyTopLevelProperties for VirtualMachineScaleSet to accommodate Placement

* Moving examples to tsp folder

* Adding reason in readme.md for BodyTopLevelProperty suppression

* Add upgradePolicy to example templates

* Update documentation of the Placement property

* Update documentation for Placement

---------

Co-authored-by: Haider Agha <64601174+haagha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkulkarni-ms dkulkarni-ms Awaiting requested review from dkulkarni-ms dkulkarni-ms is a code owner

@MS-syh2qs MS-syh2qs Awaiting requested review from MS-syh2qs MS-syh2qs is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Approved-Avocado ARMReview Compute DoNotMerge <valid label in PR review process> use to hold merge after approval new-api-version resource-manager SuppressionReviewRequired TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@haagha @qiaozha @xinzewang233 @grizzlytheodore @payalguptapg @sgovindaraju-github @sabanermsft