Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

Azure / azure-rest-api-specs Public

Notifications You must be signed in to change notification settings
Fork 5.2k
Star 2.8k

Code
Issues 1.8k
Pull requests 863
Discussions
Actions
Projects
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OAV error log #3421

Merged

sergey-shandar merged 2 commits into Azure:master from unknown repository

Jul 17, 2018

Merged

Fix OAV error log #3421

sergey-shandar merged 2 commits into Azure:master from unknown repository

Jul 17, 2018

Conversation 8 Commits 2 Checks 0 Files changed

Conversation

Copy link

Contributor

sergey-shandar commented Jul 16, 2018 •

edited by azuresdkci

Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Sorry, something went wrong.

All reactions


          Fix OAV error log

4e31a9d

sergey-shandar added the DoNotMerge <valid label in PR review process> use to hold merge after approval label

Copy link

AutorestCI commented Jul 16, 2018 •

edited

Loading

Automation for azure-sdk-for-ruby

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

Copy link

AutorestCI commented Jul 16, 2018 •

edited

Loading

Automation for azure-sdk-for-python

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

Copy link

AutorestCI commented Jul 16, 2018 •

edited

Loading

Automation for azure-sdk-for-java

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

Copy link

AutorestCI commented Jul 16, 2018 •

edited

Loading

Automation for azure-sdk-for-go

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

Copy link

AutorestCI commented Jul 16, 2018 •

edited

Loading

Automation for azure-sdk-for-node

Unable to detect any generation context from this PR.

All reactions

Sorry, something went wrong.

azuresdkci assigned marstr

azuresdkci requested a review from marstr

July 16, 2018 20:56

sergey-shandar removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label

sergey-shandar changed the title ~~[Don't merge yet] Fix OAV error log~~ Fix OAV error log

marstr reviewed

View reviewed changes

Copy link

Member

marstr left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm an outsider on this one, but it seems to me that scripts/modelValidation.json and test/model.json are largely the same. Why do we need both?

Sorry, something went wrong.

All reactions


          remove test/model.js

b8d1446

Copy link

Contributor Author

sergey-shandar commented Jul 16, 2018

@marstr thanks for the comment, I removed the old test file. Please check the model validator build for new style for errors https://travis-ci.org/Azure/azure-rest-api-specs/jobs/404635481

All reactions

Sorry, something went wrong.

sergey-shandar requested review from vladbarosan, veronicagg and amarzavery

July 16, 2018 22:05

amarzavery approved these changes

View reviewed changes

sergey-shandar merged commit d068d86 into Azure:master

sergey-shandar deleted the sergey-oav branch

July 17, 2018 03:12

Copy link

Contributor

veronicagg commented Jul 17, 2018

@sergey-shandar looks good. What's "!tag:yaml.org,2002:js/undefined '' appearing for most "innerErrors"? Thanks!

All reactions

Sorry, something went wrong.

mccleanp pushed a commit that referenced this pull request


          Added CheckNameAvailability, used ErrorResponse v2 in DeviceUpdate (#…

…3421)

* Update deviceupdate.json

* Add files via upload

* Update deviceupdate.json

* checknameavailability

* format

* Update CheckNameAvailability_AlreadyExists.json

* Update CheckNameAvailability_Available.json

* Update Instances_Create.json

* Update Accounts_Create.json

* Update CheckNameAvailability_AlreadyExists.json

* Update CheckNameAvailability_Available.json

* Update CheckNameAvailability_AlreadyExists.json

* Update CheckNameAvailability_Available.json

* Update CheckNameAvailability_AlreadyExists.json

* Update CheckNameAvailability_Available.json

* Update deviceupdate.json

* Update deviceupdate.json

* Update deviceupdate.json

* Update deviceupdate.json

* Update Accounts_Delete.json

* Update Instances_Delete.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

marstr marstr left review comments

amarzavery amarzavery approved these changes

vladbarosan Awaiting requested review from vladbarosan

veronicagg Awaiting requested review from veronicagg

Assignees

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.