Add server level policy for vulnerability assessment #3392

talhers · 2018-07-11T07:00:36Z

As part of the ATP concept, we would like to add a new API to manage vulnerability assessment policy at server level, for servers and managed instances.

These APIs are similar to the regular Vulnerability Assessment APIs on a database, with the difference that they don't contain "/databases/{database name}/"

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

AutorestCI · 2018-07-11T07:02:15Z

Automation for azure-sdk-for-python

Encountered an unknown error: (azure-sdk-for-python)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 16d21b042518e16bd0c6b09658fdd957eddd20ed
  stderr: 'fatal: reference is not a tree: 16d21b042518e16bd0c6b09658fdd957eddd20ed'

AutorestCI · 2018-07-11T07:02:44Z

Automation for azure-sdk-for-ruby

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-ruby#1419

AutorestCI · 2018-07-11T07:03:45Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-07-11T07:05:47Z

Automation for azure-sdk-for-go

Encountered an unknown error: (azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 16d21b042518e16bd0c6b09658fdd957eddd20ed
  stderr: 'fatal: reference is not a tree: 16d21b042518e16bd0c6b09658fdd957eddd20ed'

AutorestCI · 2018-07-11T07:13:55Z

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 16d21b042518e16bd0c6b09658fdd957eddd20ed
  stderr: 'fatal: reference is not a tree: 16d21b042518e16bd0c6b09658fdd957eddd20ed'

talhers · 2018-07-12T07:23:46Z

@yaakoviyun , @yoavfr , @ggildin

yaakoviyun · 2018-07-12T13:12:57Z

...anager/Microsoft.Sql/preview/2018-06-01-preview/ManagedInstanceVulnerabilityAssessments.json

+          ]
+        },
+        "storageAccountAccessKey": {
+          "description": "Specifies the identifier key of the vulnerability assessment storage account. If 'StorageContainerSasKey' isn't specified, storageAccountAccessKey is required.",


seems confusing.
there is no "vulnerability assessment storage account".

Maybe use: "storage account for vulnerability assessment scan results"?

yaakoviyun · 2018-07-16T07:24:48Z

@jianghaolu , @ravbhatnagar - can you please review?

yaakoviyun · 2018-07-28T17:09:11Z

@ravbhatnagar - can you please review?

azuresdkci · 2018-08-02T15:30:40Z

Can one of the admins verify this patch?

jhendrixMSFT · 2018-08-07T19:08:16Z

@AutorestCI regenerate azure-sdk-for-go

talhers · 2018-10-16T07:54:15Z

@jianghaolu Please merge
Thanks!

talhers · 2018-10-16T08:14:10Z

There is a newer version already merged, this PR can be closed

AutorestCI · 2018-10-22T19:43:39Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 254, in generate_sdk_from_git_object
    with manage_git_folder(gh_token, Path(temp_dir) / Path("rest"), branched_rest_api_id, pr_number=pr_number) as restapi_git_folder, \
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 272, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 212, in clone_to_path
    repo.git.checkout(branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git checkout 16d21b042518e16bd0c6b09658fdd957eddd20ed
  stderr: 'fatal: reference is not a tree: 16d21b042518e16bd0c6b09658fdd957eddd20ed'

Add server level policy for vulnerability assessment

f7d9ef9

azuresdkci assigned jianghaolu Jul 11, 2018

azuresdkci requested a review from jianghaolu July 11, 2018 07:01

AutorestCI mentioned this pull request Jul 11, 2018

[AutoPR sql/resource-manager] [DO NOT MERGE] Add server level policy for vulnerability assessment Azure/azure-sdk-for-python#2909

Closed

AutorestCI mentioned this pull request Jul 11, 2018

[AutoPR sql/resource-manager] [DO NOT MERGE] Add server level policy for vulnerability assessment Azure/azure-sdk-for-ruby#1468

Closed

AutorestCI mentioned this pull request Jul 11, 2018

[AutoPR sql/resource-manager] [DO NOT MERGE] Add server level policy for vulnerability assessment Azure/azure-sdk-for-go#2211

Closed

AutorestCI mentioned this pull request Jul 11, 2018

[AutoPR sql/resource-manager] [DO NOT MERGE] Add server level policy for vulnerability assessment Azure/azure-sdk-for-node#3155

Closed

yaakoviyun reviewed Jul 12, 2018

View reviewed changes

jianghaolu approved these changes Jul 16, 2018

View reviewed changes

jianghaolu added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 16, 2018

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 31, 2018

AutorestCI mentioned this pull request Aug 7, 2018

[AutoPR sql/resource-manager] [DO NOT MERGE] Add server level policy for vulnerability assessment Azure/azure-sdk-for-go#2413

Closed

talhers changed the title ~~[DO NOT MERGE] Add server level policy for vulnerability assessment~~ Add server level policy for vulnerability assessment Oct 16, 2018

jianghaolu closed this Oct 22, 2018

XiaofeiCao pushed a commit to XiaofeiCao/azure-rest-api-specs that referenced this pull request Jul 5, 2024

Update specificationRepositoryConfiguration.json (Azure#3392)

9c88613

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add server level policy for vulnerability assessment #3392

Add server level policy for vulnerability assessment #3392

talhers commented Jul 11, 2018 •

edited

Loading

AutorestCI commented Jul 11, 2018 •

edited

Loading

AutorestCI commented Jul 11, 2018 •

edited

Loading

AutorestCI commented Jul 11, 2018 •

edited

Loading

AutorestCI commented Jul 11, 2018 •

edited

Loading

AutorestCI commented Jul 11, 2018 •

edited

Loading

talhers commented Jul 12, 2018

yaakoviyun Jul 12, 2018

yaakoviyun commented Jul 16, 2018

yaakoviyun commented Jul 28, 2018

azuresdkci commented Aug 2, 2018

jhendrixMSFT commented Aug 7, 2018

talhers commented Oct 16, 2018

talhers commented Oct 16, 2018

AutorestCI commented Oct 22, 2018 •

edited

Loading

Add server level policy for vulnerability assessment #3392

Add server level policy for vulnerability assessment #3392

Conversation

talhers commented Jul 11, 2018 • edited Loading

PR information

Quality of Swagger

AutorestCI commented Jul 11, 2018 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Jul 11, 2018 • edited Loading

Automation for azure-sdk-for-ruby

AutorestCI commented Jul 11, 2018 • edited Loading

Automation for azure-sdk-for-java

AutorestCI commented Jul 11, 2018 • edited Loading

Automation for azure-sdk-for-go

AutorestCI commented Jul 11, 2018 • edited Loading

Automation for azure-sdk-for-node

talhers commented Jul 12, 2018

yaakoviyun Jul 12, 2018

Choose a reason for hiding this comment

yaakoviyun commented Jul 16, 2018

yaakoviyun commented Jul 28, 2018

azuresdkci commented Aug 2, 2018

jhendrixMSFT commented Aug 7, 2018

talhers commented Oct 16, 2018

talhers commented Oct 16, 2018

AutorestCI commented Oct 22, 2018 • edited Loading

Automation for azure-sdk-for-js

talhers commented Jul 11, 2018 •

edited

Loading

AutorestCI commented Jul 11, 2018 •

edited

Loading

AutorestCI commented Jul 11, 2018 •

edited

Loading

AutorestCI commented Jul 11, 2018 •

edited

Loading

AutorestCI commented Jul 11, 2018 •

edited

Loading

AutorestCI commented Jul 11, 2018 •

edited

Loading

AutorestCI commented Oct 22, 2018 •

edited

Loading