Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationInsights: Uses plural for operation group name #3324

Merged
merged 2 commits into from
Jul 2, 2018
Merged

ApplicationInsights: Uses plural for operation group name #3324

merged 2 commits into from
Jul 2, 2018

Conversation

anuchandy
Copy link
Member

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@anuchandy anuchandy changed the title Java tags1 ApplicationInsights: Uses plural for operation group name Jun 28, 2018
@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2022

@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2691

@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2171

@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#2166

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine on the Python side, package is still in preview and allow breaking change. I will just mention it in the ChangeLog

@fearthecowboy
Copy link
Member

@ericc1103 -- Operation IDs are intended to be <plural-noun>_<verb> -- this corrects a glitch in the spec. Please review and approve.

@amarzavery @vladbarosan @dsgouda @shahabhijeet -- FYI - this is technically a breaking change, but necessary to correct a bad API.

Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vladbarosan
Copy link

@fearthecowboy are we good to merge here ?

@vladbarosan vladbarosan merged commit ac0155f into Azure:master Jul 2, 2018
@anuchandy anuchandy deleted the java-tags1 branch July 2, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants