Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress RequiredPropertiesMissingInResourceModel for AzureFirewall #3323

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Suppress RequiredPropertiesMissingInResourceModel for AzureFirewall #3323

merged 1 commit into from
Jul 2, 2018

Conversation

joannakleong
Copy link
Contributor

@joannakleong joannakleong commented Jun 28, 2018 •
edited by azuresdkci
Loading

Suppress RequiredPropertiesMissingInResourceModel for AzureFirewall

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI AutorestCI mentioned this pull request Jun 28, 2018
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2610

@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2135

This was referenced Jun 28, 2018
Merged
Merged
@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2376

@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

@joannakleong
Copy link
Contributor Author

hi @ravbhatnagar could you please help take a look at this PR?

@ravbhatnagar ravbhatnagar added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 29, 2018
@ravbhatnagar
Copy link
Contributor

Same NRP suppression and current design limitation around not being able to make id read only.

@annatisch annatisch merged commit b7b93e2 into Azure:master Jul 2, 2018
@samuelkuangms samuelkuangms mentioned this pull request May 12, 2021
Merged
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikhailTryakhov MikhailTryakhov MikhailTryakhov approved these changes

@annatisch annatisch annatisch approved these changes

@ravbhatnagar ravbhatnagar Awaiting requested review from ravbhatnagar

@DeepakRajendranMsft DeepakRajendranMsft Awaiting requested review from DeepakRajendranMsft

Assignees

@annatisch annatisch

Labels
ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joannakleong @AutorestCI @ravbhatnagar @MikhailTryakhov @annatisch