Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate values in Monitor Spec #3322

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Conversation

sarangan12
Copy link
Member

@sarangan12 sarangan12 commented Jun 28, 2018

Issue

Sarangans-MacBook-Pro:azure-sdk-for-ruby saranganrajamanickam$ autorest --package-name=azure_mgmt_monitor  /Users/saranganrajamanickam/Projects/azure-rest-api-specs/specification/monitor/resource-manager/readme.md --namespace=Azure::Monitor::Mgmt::V2016_09_01 --title=MonitorClient --tag=package-2016-09-01-only --package-version=0.16.1 --output-folder=/Users/saranganrajamanickam/Projects/azure-sdk-for-ruby/management/azure_mgmt_monitor/lib/ --ruby --azure-arm
AutoRest code generation utility [version: 2.0.4280; node: v8.6.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/Users/saranganrajamanickam/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.ruby' (~3.1.26->3.1.38)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.1.22->2.1.22)

ERROR (Fatal/DuplicateParameterCollision): Duplicated global non-identical parameter definitions
    - file:///Users/saranganrajamanickam/Projects/azure-rest-api-specs/specification/monitor/resource-manager/microsoft.insights/stable/2016-09-01/serviceDiagnosticsSettings_API.json:395:4 ($.parameters.ResourceUriParameter)
    - file:///Users/saranganrajamanickam/Projects/azure-rest-api-specs/specification/monitor/resource-manager/microsoft.insights/stable/2016-09-01/metrics_API.json:269:4 ($.parameters.ResourceUriParameter)
Process() cancelled due to exception : Cancellation requested.
  Cancellation requested.

Root Cause
ResourceUriParameter parameter is repeated in both files which should not happen.

Fix
Remove one of them and reference it in the other.

Post Fix

Sarangans-MacBook-Pro:azure-sdk-for-ruby saranganrajamanickam$ autorest --package-name=azure_mgmt_monitor  /Users/saranganrajamanickam/Projects/azure-rest-api-specs/specification/monitor/resource-manager/readme.md --namespace=Azure::Monitor::Mgmt::V2016_09_01 --title=MonitorClient --tag=package-2016-09-01-only --package-version=0.16.1 --output-folder=/Users/saranganrajamanickam/Projects/azure-sdk-for-ruby/management/azure_mgmt_monitor/lib/ --ruby --azure-arm
AutoRest code generation utility [version: 2.0.4280; node: v8.6.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/Users/saranganrajamanickam/.autorest/@microsoft.azure_autorest-core@2.0.4280/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4280)
   Loading AutoRest extension '@microsoft.azure/autorest.ruby' (~3.1.26->3.1.38)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.1.22->2.1.22)
Sarangans-MacBook-Pro:azure-sdk-for-ruby saranganrajamanickam$ git status
On branch master
Your branch is up-to-date with 'origin/master'.

nothing to commit, working tree clean
Sarangans-MacBook-Pro:azure-sdk-for-ruby saranganrajamanickam$

@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018

Automation for azure-sdk-for-python

Nothing to generate for azure-sdk-for-python

@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Jun 28, 2018

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1435

@hovsepm hovsepm merged commit d54f5c2 into Azure:master Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants