Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new version 2018-04-02 for Microsoft.StorageSync Resource Provider #3238

Merged
merged 4 commits into from
Jun 18, 2018
Merged

Add new version 2018-04-02 for Microsoft.StorageSync Resource Provider #3238

merged 4 commits into from
Jun 18, 2018

Conversation

ankushbindlish2
Copy link
Member

@ankushbindlish2 ankushbindlish2 commented Jun 14, 2018

Copy Preview folder to new api version

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

Copy Preview folder to new api version
@AutorestCI
Copy link

AutorestCI commented Jun 14, 2018

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Jun 14, 2018

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#2734

@AutorestCI
Copy link

AutorestCI commented Jun 14, 2018

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

New Api version changes 2018-04-02
@AutorestCI
Copy link

AutorestCI commented Jun 14, 2018

Automation for azure-libraries-for-java

Encountered an unknown error: (azure-libraries-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 32, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 169, in rest_handle_action
    return rest_pull_sync(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 197, in rest_pull_sync
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 246, in generate_sdk_from_git_object
    manage_git_folder(gh_token, clone_dir, branched_sdk_git_id) as sdk_folder:
  File "/usr/lib/python3.6/contextlib.py", line 81, in __enter__
    return next(self.gen)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 266, in manage_git_folder
    clone_to_path(gh_token, temp_dir, split_git_id[0], branch_or_commit=branch, pr_number=pr_number)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 197, in clone_to_path
    _git_clone_to_path(https_authenticated_url, folder, branch_or_commit)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/git_tools.py", line 76, in clone_to_path
    repo = Repo.clone_from(https_authenticated_url, str(folder))
  File "/usr/local/lib/python3.6/dist-packages/git/repo/base.py", line 982, in clone_from
    return cls._clone(git, url, to_path, GitCmdObjectDB, progress, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/repo/base.py", line 933, in _clone
    finalize_process(proc, stderr=stderr)
  File "/usr/local/lib/python3.6/dist-packages/git/util.py", line 333, in finalize_process
    proc.wait(**kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 417, in wait
    raise GitCommandError(self.args, status, errstr)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git clone -v https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/AutorestCI/azure-libraries-for-java.git /tmp/tmp4wuperch/sdk
  stderr: 'Cloning into '/tmp/tmp4wuperch/sdk'...
fatal: unable to access 'https://AutorestCI:58ab395c311d1bd75b3e1db1cc8adaf9acc42afe@github.com/AutorestCI/azure-libraries-for-java.git/': SSL connection timeout
'

@AutorestCI
Copy link

AutorestCI commented Jun 14, 2018

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2985

Address comma comment
@annatisch
Copy link
Member

Hi @marstr - for some context, this PR has had some prior reviews:

Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankushbindlish2, it looks like a bunch of your examples don't line up with the Swaggers. You can see details here:
https://travis-ci.org/Azure/azure-rest-api-specs/jobs/392147635#L772

@marstr
Copy link
Member

marstr commented Jun 18, 2018

Seeing as this is just a copy of an existing API Version, with a small operation added I do not believe ARM review is warranted. Let me know when you're ready for me to merge, @ankushbindlish2.

@ankushbindlish2
Copy link
Member Author

Please merge

@marstr marstr merged commit 58ba132 into Azure:master Jun 18, 2018
@AutorestCI
Copy link

AutorestCI commented Jun 19, 2018

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 32, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 167, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 182, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 237, in generate_sdk_from_git_object
    raise ValueError("Unable to locate configuration in {}".format(branch_list))
ValueError: Unable to locate configuration in ['restapi_auto_storagesync/resource-manager', 'restapi_auto_3238', 'master']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants