Java multi api #3221
Merged
Java multi api #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use common Resource & Sku definitions in all Sql specs (Azure#3134) * Use common Resource & Sku definitions * Don't use common Sku definition * Just use common SQL definitions * Fixed syntax error * Fixed another syntax error * Fixed sku ref error * Fixed syntax error in example * Fix Python conf of servermanager (Azure#3140) * Fix ServerManager Py Conf (Azure#3141) * Plug SwaggerToSdk to LogAnalyticsMgmt (Azure#3142) * [Storage] Support Management policy on new api version 2018-03-01-preview (Azure#3137) * [Storage] Add new API version 2018-03-01-preview * [Storage] Update rest version 2018-03-01-preview * [Storage] Support Management Policy * [Storage] Update since code review comments * Add Python conf * [Storage] Add managment policy doc link to policy description. * [Storage] modify as review comments * RSA key size examples, ECC descriptions (Azure#3136) * RSA key size examples, ECC descriptions * remove preview changes for now * Added GroupType property in HybridWorkerGroup (Azure#3132) * Watcher resource swagger specs. For more details on the Usage of the resource: https://docs.microsoft.com/en-us/azure/automation/automation-watchers-tutorial (Azure#3102) * Watcher specs * using the same model for get/put input and output. * Fix storage Python conf (Azure#3148) * Fix for Azure Networking swagger 2018-04-01 version (Azure#3146)
…into javamultiapi
* Change all existing ##Java sections * Add java multi api sections
jianghaolu
requested review from
DeepakRajendranMsft,
hitenjava,
MikhailTryakhov and
kay-owolabi
as code owners
Automation for azure-libraries-for-javaThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-nodeThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-pythonThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
Automation for azure-sdk-for-rubyThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
|
@jianghaolu just talked to @lmazuel regarding the python failures, he will be taking a look and suggested to hold on this PR. |
Automation for azure-sdk-for-goThis PR contains more than 3 context, SDK generation is not enabled. Contexts found:
|
|
@lmazuel investigated this and the issue here is - service fabric specs contains more than one model with the same name but with different model schema. In past we communicated this issue to service teams and it seems service fabric didn't fix it. We will communicate this to all swagger reviewer so all know whats the issue when we see the error |
anuchandy
approved these changes
Jun 12, 2018
lmazuel
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger