-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alecb typespecmigration 20240808-preview #31722
Open
alec-baird
wants to merge
177
commits into
Azure:main
Choose a base branch
from
AVD-RDDAM:alecb-typespecmigration-20240910
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Alecb typespecmigration 20240808-preview #31722
alec-baird
wants to merge
177
commits into
Azure:main
from
AVD-RDDAM:alecb-typespecmigration-20240910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from stable/2024-04-03 to stable/2024-09-10.
…e PL. 150+ warnings (mostly for docs) needed
…into alecb-typespecmigration-20240910
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
API change check APIView has identified API level changes in this PR and created following API reviews. Microsoft.DesktopVirtualization |
This was referenced Feb 21, 2025
markcowl
reviewed
Feb 22, 2025
specification/desktopvirtualization/DesktopVirtualization.Management/SessionHost.tsp
Show resolved
Hide resolved
...ation/desktopvirtualization/DesktopVirtualization.Management/ScalingPlanPersonalSchedule.tsp
Outdated
Show resolved
Hide resolved
...ication/desktopvirtualization/DesktopVirtualization.Management/ScalingPlanPooledSchedule.tsp
Outdated
Show resolved
Hide resolved
markcowl
reviewed
Feb 22, 2025
...fication/desktopvirtualization/DesktopVirtualization.Management/SessionHostConfiguration.tsp
Outdated
Show resolved
Hide resolved
specification/desktopvirtualization/DesktopVirtualization.Management/HostPool.tsp
Outdated
Show resolved
Hide resolved
specification/desktopvirtualization/DesktopVirtualization.Management/HostPool.tsp
Outdated
Show resolved
Hide resolved
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved-Suppression
ARMReview
ARMSignedOff
<valid label in PR review process>add this label when ARM approve updates after review
BreakingChange-Python-Sdk
BreakingChange-Python-Sdk-Approved
ReadyForApiTest
<valid label in PR review process>add this label when swagger and service APIs are ready for test
resource-manager
TypeSpec
Authored with TypeSpec
Versioning-Approved-BugFix
https://github.com/Azure/azure-sdk-tools/issues/6374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.