Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @typespec/streams as direct dependency #31447

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

mikeharder
Copy link
Member

  • Intention is to pin all TSP packages, not just leaf nodes
  • Ensures branch "tsp-next" resolves the correct packages

- Intention is to pin all TSP packages, not just leaf nodes
- Ensures branch "tsp-next" resolves the correct packages
Copy link

openapi-pipeline-app bot commented Nov 6, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ The required check named Protected Files has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

Copy link

openapi-pipeline-app bot commented Nov 6, 2024

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@chrisradek
Copy link
Member

Should we include @typespec/xml as well? It is used by @typespec/openapi3 as an optional peer just like streams:
https://github.com/microsoft/typespec/blob/72e5c09a306da55a7e19a248beef6413687d25e1/packages/openapi3/package.json#L70-L74

@timotheeguerin
Copy link
Member

Should we include @typespec/xml as well? It is used by @typespec/openapi3 as an optional peer just like streams: https://github.com/microsoft/typespec/blob/72e5c09a306da55a7e19a248beef6413687d25e1/packages/openapi3/package.json#L70-L74

ah good point not sure why tis not failing there too

@mikeharder
Copy link
Member Author

mikeharder commented Nov 6, 2024

Should we include @typespec/xml as well? It is used by @typespec/openapi3 as an optional peer just like streams: https://github.com/microsoft/typespec/blob/72e5c09a306da55a7e19a248beef6413687d25e1/packages/openapi3/package.json#L70-L74

@chrisradek: That's actually not a valid optional peer dep. It needs to be listed under peerDependencies in addition to peerDependenciesMeta. If you fix this bug, then yes we will need to add @typespec/xml.

@timotheeguerin

@mikeharder mikeharder merged commit 901bdbf into Azure:main Nov 6, 2024
22 of 39 checks passed
@mikeharder mikeharder deleted the typespec-streams branch November 6, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants