Kamboj prjwl/release network microsoft.network 2024 05 01 #31095

kamboj-prjwl · 2024-10-18T06:01:48Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.

Updated the API version from stable/2024-03-01 to stable/2024-05-01.

…rk-2024-05-01

* Add IPAM, VNV, update Security Admin and Vnet specs * adminrule error * adding suppressions * suppression spacing * space issue * another space update * the issue was 2024-03 readme and not 2024-05 * adding suppressions * removing location headers * reverting location header changes for delete * Update sdk-suppressions.yaml * mark networkManagerScopeAccess as an optional property * update go breaking suppressions --------- Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com> Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Swagger changes for expressroute site failover simulation * Fixing some checks * Correcting parameter name in stop json * Changing error schema * Adding arm id format for uris * Adding suppressions

* Added location headers to 202 responses for ipGroups and virtualRouters. * Added location header to vr peering delete examples * Ran prettier on 2024-05-01 examples

…workInterface (#30692) * [Network] - Adding DefaultOutboundConnectivityEnabled property in networkInterface * address prettier check

* add private only feature to azure bastion service * fix Swagger PrettierCheck * fix the swagger PrettierCheck * modify the api version * modify file name --------- Co-authored-by: Leo Liu (from Dev Box) <leoliu2@microsoft.com>

…rk-2024-05-01

openapi-pipeline-app · 2024-10-18T06:01:51Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ This is the public specs repo main branch which is not intended for iterative development.
You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
If this is what you intend, add PublishToCustomers label to your PR.
Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
For details of the ARM review, see aka.ms/azsdk/pr-arm-review
❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
To unblock this PR, follow the process at aka.ms/brch.
❌ The required check named Swagger ModelValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

openapi-pipeline-app · 2024-10-18T06:01:52Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/network/armnetwork	https://apiview.dev/Assemblies/Review/1b263a329090477991c0a7b7b0ae21d7?revisionId=72c9059049cf40d1b7f71e90bc234c0b
JavaScript	@azure/arm-network	https://apiview.dev/Assemblies/Review/c13fd66ecbcc4c2a9995c8a1f4187240?revisionId=16554f27256a45a7ad0bb910b53c01bd
Swagger	Microsoft.Network	https://apiview.dev/Assemblies/Review/9a91f46aa0a846acaae91aba821517fb?revisionId=e4904e7b26fd4aa6b388e62799eb8b04

…rk-2024-05-01

* resolving/removing resource name formatting * Revert "resolving/removing resource name formatting" This reverts commit b7a079b. * using confirmed resource name regex for AVNM, IPAM, and VNV. Which is more restrictive than ARM. * updaing vnv swagger * adding line at end of file to resolve prettier

Changes for Swagger for Health API.

Made changes to pass validations.

Made some fixes for pipeline checks.

Changes to fix pipeline errors.

…rk-2024-05-01

* Suppress Lint Diff * Prettier Check Fix for Virtual Network * Add Path in Lint Suppression * Revert changes for path * Applied path level suppression * Applied path level suppression

…rk-2024-05-01

microsoft-github-policy-service · 2024-10-25T17:44:43Z

@kamboj-prjwl please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

microsoft-github-policy-service · 2024-10-25T17:44:44Z

@kamboj-prjwl please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

kamboj-prjwl and others added 12 commits September 10, 2024 16:08

Copy files from stable/2024-03-01

6062cf2

Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.

Update version to stable/2024-05-01

7420546

Updated the API version from stable/2024-03-01 to stable/2024-05-01.

Added tag for 2024-05-01 in readme file

2d61498

change other Route files

0bd42f9

add header to routeTableDelete examples

fb9e6d0

Merge branch 'main' into kamboj-prjwl/release-network-Microsoft.Netwo…

f4d3ecc

…rk-2024-05-01

Swagger changes for expressroute site failover simulation (#30731)

98000aa

* Swagger changes for expressroute site failover simulation * Fixing some checks * Correcting parameter name in stop json * Changing error schema * Adding arm id format for uris * Adding suppressions

Fixing virtualRouters and ipGroups 202 response examples (#30871)

7e5c142

* Added location headers to 202 responses for ipGroups and virtualRouters. * Added location header to vr peering delete examples * Ran prettier on 2024-05-01 examples

[Network] - Adding DefaultOutboundConnectivityEnabled property in net…

1111acd

…workInterface (#30692) * [Network] - Adding DefaultOutboundConnectivityEnabled property in networkInterface * address prettier check

Merge branch 'main' into kamboj-prjwl/release-network-Microsoft.Netwo…

68ce771

…rk-2024-05-01

openapi-pipeline-app bot added BreakingChange-Go-Sdk-Suppression BreakingChange-JavaScript-Sdk-Suppression labels Oct 18, 2024

microsoft-github-policy-service bot added the Network label Oct 18, 2024

AzureRestAPISpecReview added ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version NotReadyForARMReview resource-manager SuppressionReviewRequired labels Oct 18, 2024

azure-sdk mentioned this pull request Oct 18, 2024

[AutoPR @azure/arm-network] Kamboj prjwl/release network microsoft.network 2024 05 01 azure-sdk/azure-sdk-for-js#12477

Draft

Merge branch 'main' into kamboj-prjwl/release-network-Microsoft.Netwo…

299e8af

…rk-2024-05-01

This was referenced Oct 18, 2024

[AutoPR Azure.ResourceManager.Network] Kamboj prjwl/release network microsoft.network 2024 05 01 azure-sdk/azure-sdk-for-net#9547

Draft

[AutoPR azure-mgmt-network] Kamboj prjwl/release network microsoft.network 2024 05 01 azure-sdk/azure-sdk-for-python#9140

Draft

Fix Prettier Check

24a689f

kamboj-prjwl and others added 13 commits October 18, 2024 18:45

Merge branch 'main' into kamboj-prjwl/release-network-Microsoft.Netwo…

3da3f1c

…rk-2024-05-01

Removing minLength from IPAM

ca9a39e

Merge branch 'main' into kamboj-prjwl/release-network-Microsoft.Netwo…

898c49a

…rk-2024-05-01

Merge branch 'main' into kamboj-prjwl/release-network-Microsoft.Netwo…

f7ecedb

…rk-2024-05-01

Merge branch 'main' into kamboj-prjwl/release-network-Microsoft.Netwo…

fedac2e

…rk-2024-05-01

Health API changes

37049a6

Changes for Swagger for Health API.

Prettier and spelling checks

b8c5869

Made changes to pass validations.

Fixes

b5b9c82

Made some fixes for pipeline checks.

More changes

367e7e7

Changes to fix pipeline errors.

Prettier check

a4260aa

Merge branch 'main' into kamboj-prjwl/release-network-Microsoft.Netwo…

0d54d82

…rk-2024-05-01

Merge branch 'main' into kamboj-prjwl/release-network-Microsoft.Netwo…

a0ee11a

…rk-2024-05-01

mikeharder mentioned this pull request Oct 23, 2024

[CrossVersionBreakingChange] Paths for one error in a spec are empty Azure/openapi-diff#346

Open

kamboj-prjwl added 4 commits October 24, 2024 21:04

Lint Diff Suppression Swagger API Version 2024-05-01 (#31119)

1533845

* Suppress Lint Diff * Prettier Check Fix for Virtual Network * Add Path in Lint Suppression * Revert changes for path * Applied path level suppression * Applied path level suppression

Merge branch 'main' into kamboj-prjwl/release-network-Microsoft.Netwo…

49d3bdb

…rk-2024-05-01

Merge branch 'main' into kamboj-prjwl/release-network-Microsoft.Netwo…

4faa9b6

…rk-2024-05-01

Merge branch 'main' into kamboj-prjwl/release-network-Microsoft.Netwo…

dc4c893

…rk-2024-05-01

openapi-pipeline-app bot added PipelineBotTrigger and removed PipelineBotTrigger labels Oct 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kamboj prjwl/release network microsoft.network 2024 05 01 #31095

Kamboj prjwl/release network microsoft.network 2024 05 01 #31095

kamboj-prjwl commented Oct 18, 2024

openapi-pipeline-app bot commented Oct 18, 2024 •

edited

Loading

openapi-pipeline-app bot commented Oct 18, 2024 •

edited

Loading

microsoft-github-policy-service bot commented Oct 25, 2024

Contribution License Agreement

microsoft-github-policy-service bot commented Oct 25, 2024

Contribution License Agreement

Kamboj prjwl/release network microsoft.network 2024 05 01 #31095

Are you sure you want to change the base?

Kamboj prjwl/release network microsoft.network 2024 05 01 #31095

Conversation

kamboj-prjwl commented Oct 18, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented Oct 18, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented Oct 18, 2024 • edited Loading

Generated ApiView

microsoft-github-policy-service bot commented Oct 25, 2024

Contribution License Agreement

microsoft-github-policy-service bot commented Oct 25, 2024

Contribution License Agreement

openapi-pipeline-app bot commented Oct 18, 2024 •

edited

Loading

openapi-pipeline-app bot commented Oct 18, 2024 •

edited

Loading