-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding API for notification rules in loadtesting #31078
Open
radhikajain99
wants to merge
4
commits into
Azure:main
Choose a base branch
from
radhikajain99:users/radhikajain/loadtesting-notifications
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding API for notification rules in loadtesting #31078
radhikajain99
wants to merge
4
commits into
Azure:main
from
radhikajain99:users/radhikajain/loadtesting-notifications
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
microsoft-github-policy-service
bot
added
the
Load Test Service
Azure Load Test Service
label
Oct 17, 2024
AzureRestAPISpecReview
added
data-plane
TypeSpec
Authored with TypeSpec
VersioningReviewRequired
<valid label in PR review process>add this label when versioning review is required
labels
Oct 17, 2024
radhikajain99
requested review from
scgbear and
MushMal
and removed request for
a team
October 17, 2024 08:16
AzureRestAPISpecReview
added
new-api-version
and removed
VersioningReviewRequired
<valid label in PR review process>add this label when versioning review is required
labels
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
data-plane
Load Test Service
Azure Load Test Service
new-api-version
TypeSpec
Authored with TypeSpec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API Specification Update Pull Request
Added new API for
notification-rules
to the service to enable Notifications for various events in Azure Load Testing. This will allow the user to create aNotificationRule
where they will specify when and how to receive notifications. They can specify thescope
at which they want to receive notifications. Currently we will supportTests
scope which can be expanded in the future to support more scopes likeResource
,Trigger
, etc. Based on the scope selected, the user can provide further filtering. ForTests
scope, the user can provide a list oftestIds
for which they want to receive notifications. The user will also provide a list ofevents
they want to be notified for. It can include various events likeTestRunEnded
,TestRunStarted
,TriggerEnded
, etc. and the user can further filter by specifyingcondition
inside the event. They will provide a list ofactionGroupIds
which will have the action group resource id which will be used to send the notification.This API is added to an existing preview version
2024-07-01-preview
and there are no changes in any of the existing paths that version.Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
notification-rules
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.fix #31079