Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SystemMetadata property for ModelVersion #30937

Open
wants to merge 3 commits into
base: release-machinelearningservices-Microsoft.MachineLearningServices-2024-10-01-preview
Choose a base branch
from
Open

Added SystemMetadata property for ModelVersion #30937

wants to merge 3 commits into from

Conversation

adyada
Copy link
Contributor

@adyada adyada commented Oct 9, 2024

Added SystemMetadata property for ModelVersion

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@adyada
Added SystemMetadata property for ModelVersion
1cba32f 
Added SystemMetadata property for ModelVersion
@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 9, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
    When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
    Automation should then add WaitForARMFeedback label.
    ❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 9, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/machinelearning/armmachinelearning https://apiview.dev/Assemblies/Review/c19328b4fc084461adfa498aa764be2f?revisionId=9fb1ee1ed94845fa8892552cb24917dd
JavaScript @azure/arm-machinelearning https://apiview.dev/Assemblies/Review/4b0822cc790d43b3b46bc9b075044246?revisionId=2d3ab7d329414868b759c85cf1a453c8
.Net Azure.ResourceManager.MachineLearning There is no API change compared with the previous version
Java azure-resourcemanager-machinelearning https://apiview.dev/Assemblies/Review/e1c428cb12c840a2b15ad2ba61d138e7?revisionId=7e07924d19694eb2a315c815d8ae7326
Swagger Microsoft.MachineLearningServices https://apiview.dev/Assemblies/Review/af9cc69e6ae94f27ab2ca41fddf6ba46?revisionId=ab62e8d00b18436cb3a8aae1beedbb4d

This was referenced Oct 9, 2024
Draft
Draft
Draft
Draft
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 9, 2024
This was referenced Oct 9, 2024
Draft
Draft
@raosuhas
Copy link

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@adyada
Copy link
Contributor Author

adyada commented Oct 14, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 30937 in repo Azure/azure-rest-api-specs

mentat9
mentat9 reviewed Oct 15, 2024
View reviewed changes
...vices/resource-manager/Microsoft.MachineLearningServices/preview/2024-10-01-preview/mfe.json
@@ -21972,6 +21972,15 @@
"description": "Stage in the model lifecycle assigned to this model",
"type": "string",
"x-nullable": true
},
"systemMetadata": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

systemMetadata

Empty/unschematized object is not allowed. Please schematize this object.

@mentat9 mentat9 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 15, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mentat9 mentat9 mentat9 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview resource-manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adyada @raosuhas @mentat9 @AzureRestAPISpecReview