-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging new apiversion 2023-05-01-preview Changes to main #30870
base: main
Are you sure you want to change the base?
Merging new apiversion 2023-05-01-preview Changes to main #30870
Conversation
Merging new apiversion 2023-05-01-preview Changes to main
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
adding custom word to resolve spellcheck
Fixing LintDiff
fixing schemantic errors
reverting the read-only property in Provisioning State enum as typespec is giving error
Fixing Lint Errors
…sion_2023-05-01-preview_to_main
As per API spec review the swagger ModelValidations are known.looking sugestion from apireview team for workaround or fixes. |
Fixing swagger schemantic errors
…5-01-preview_to_main' of https://github.com/Azure/azure-rest-api-specs into Bharam-Microsoft.ConnectedCache-merge_apiversion_2023-05-01-preview_to_main
…sion_2023-05-01-preview_to_main
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
…sion_2023-05-01-preview_to_main
Can you please take a look at the warnings in the lintdiff and fix as appropriate : https://github.com/Azure/azure-rest-api-specs/pull/30870/checks?check_run_id=31199438783 [bharathi] this got fixed after the branch is updated with latest changes. |
Is this an RPaaS rp and has this PR already been reviewed in the private repo ? yes this was approved deployed and tested in private repo. |
here is the private repro approved changes : https://github.com/Azure/azure-rest-api-specs-pr/pull/19106 This PR is first attempt to move the changes to main branch for next steps. |
…sion_2023-05-01-preview_to_main
…ectedCache-merge_apiversion_2023-05-01-preview_to_main
[bharathi] also at this point we are not planning on changing boolean to enum as these need lot of changes in our userrp as it supports multiple flavors . we already considered this for new properties added recently. but will need to keep all old properties as is. |
…sion_2023-05-01-preview_to_main
@Bharam-Msft - Signing off for ARM, based on the signoff from the private repo. Can you confirm whether the suppressions are still required and remove them if not needed? |
…sion_2023-05-01-preview_to_main
PublishToCustomers |
…sion_2023-05-01-preview_to_main
i have removed supression link and i see the next comment as suppression added for autorest config. we are working on SDK generation and that the reason we need to be in main to work on generating SDks. our api verison has preview in it, may be for this supression is required? |
…sion_2023-05-01-preview_to_main
…sion_2023-05-01-preview_to_main
Merging new apiversion 2023-05-01-preview Changes to main
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.