Merging new apiversion 2023-05-01-preview Changes to main

[Bharam-Msft]

Merging new apiversion 2023-05-01-preview Changes to main

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

• New resource provider.
• New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
• Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
• Update existing version to fix OpenAPI spec quality issues in S360.
• Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
• Other, please clarify:
  • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

• I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
• I have reviewed following Resource Provider guidelines, including
  ARM resource provider contract and
  REST guidelines (estimated time: 4 hours).
  I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

• First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
• If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
• To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
• For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
  and https://aka.ms/ci-fix.
• For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
• If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
  This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
• If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

[openapi-pipeline-app]

Next Steps to Merge

Next steps that must be taken to merge this PR:

• ❌ The suppressions added to the AutoRest config files (README.mds) require review. Refer to step 1 in the PR workflow diagram, or to step 3, depending on the kind of suppression you did.
• ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

[openapi-pipeline-app]

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/connectedcache/armconnectedcache	https://apiview.dev/Assemblies/Review/475d61f32a4e4236b3ff3ffa1105edc2?revisionId=ae59094ec4f547618de2c9db180261d4
Swagger	Microsoft.ConnectedCache	https://apiview.dev/Assemblies/Review/c193e39454f04a65819821e70619a467?revisionId=6056c4a9deb24e1891f24500420bc730

[Bharam-Msft]

As per API spec review the swagger ModelValidations are known.looking sugestion from apireview team for workaround or fixes.

[Bharam-Msft]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[raosuhas]

Can you please take a look at the warnings in the lintdiff and fix as appropriate : https://github.com/Azure/azure-rest-api-specs/pull/30870/checks?check_run_id=31199438783

[bharathi] this got fixed after the branch is updated with latest changes.

[raosuhas]

Is this an RPaaS rp and has this PR already been reviewed in the private repo ?

yes this was approved deployed and tested in private repo.

[Bharam-Msft]

here is the private repro approved changes : https://github.com/Azure/azure-rest-api-specs-pr/pull/19106

This PR is first attempt to move the changes to main branch for next steps.

[Bharam-Msft]

Can you please take a look at the warnings in the lintdiff and fix as appropriate : https://github.com/Azure/azure-rest-api-specs/pull/30870/checks?check_run_id=31199438783

[bharathi] this got fixed after the branch is updated with latest changes.

[bharathi] also at this point we are not planning on changing boolean to enum as these need lot of changes in our userrp as it supports multiple flavors . we already considered this for new properties added recently. but will need to keep all old properties as is.

[mentat9]

@Bharam-Msft - Signing off for ARM, based on the signoff from the private repo. Can you confirm whether the suppressions are still required and remove them if not needed?

[Bharam-Msft]

PublishToCustomers

[Bharam-Msft]

@Bharam-Msft - Signing off for ARM, based on the signoff from the private repo. Can you confirm whether the suppressions are still required and remove them if not needed?

i have removed supression link and i see the next comment as suppression added for autorest config. we are working on SDK generation and that the reason we need to be in main to work on generating SDks. our api verison has preview in it, may be for this supression is required?