Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review request for Microsoft.DBforPostgreSQL to add version preview/2024-11-01-preview #30718

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

nasc17
Copy link
Member

@nasc17 nasc17 commented Sep 25, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • [ X] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • [X ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • [ X] I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes
  • Index tuning
  • Added source types for migration
  • PG 17 support
  • UltraSSD_LRS storage type support
  • System assign identity
  • Citus on Flex cluster support
Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Sep 25, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

Copy link

openapi-pipeline-app bot commented Sep 25, 2024

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/postgresql/armpostgresql There is no API change compared with the previous version
Go sdk/resourcemanager/postgresql/armpostgresqlflexibleservers https://apiview.dev/Assemblies/Review/af578fe7418c4c5b9155096b33a0d480?revisionId=e98f3e876dad42898b68da915f76adaf
Java azure-resourcemanager-postgresqlflexibleserver https://apiview.dev/Assemblies/Review/21a61d731117447dbd7223467d7cfa42?revisionId=ee2c8227da004eb8ade68608b6ad9ab4
Swagger Microsoft.DBforPostgreSQL https://apiview.dev/Assemblies/Review/71938ae007224d959161caa6cdd98d3d?revisionId=7a5fb2d9128e4fa79d06b766c14f2e6d

@nasc17 nasc17 marked this pull request as ready for review October 5, 2024 03:19
@nasc17 nasc17 requested a review from a team as a code owner October 5, 2024 03:19
@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 21, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 21, 2024
@nasc17 nasc17 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 22, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 22, 2024
@nasc17
Copy link
Member Author

nasc17 commented Oct 22, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@ramoka178
Copy link
Contributor

Please look at the open comments and address them

@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 22, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 22, 2024
@nasc17
Copy link
Member Author

nasc17 commented Oct 23, 2024

Please look at the open comments and address them

All have been addressed

@nasc17 nasc17 requested a review from ramoka178 October 23, 2024 18:09
@nasc17 nasc17 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 24, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024
@nasc17
Copy link
Member Author

nasc17 commented Oct 24, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@ramoka178
Copy link
Contributor

ramoka178 commented Oct 24, 2024

Bumped the comment that got resolved but is not implemented. Could you check that and Also fix the Swagger Avocado error

@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 24, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024
@nasc17
Copy link
Member Author

nasc17 commented Oct 24, 2024

Bumped the comment that got resolved but is not implemented. Could you check that and Also fix the Swagger Avocado error

@ramoka178 The swagger avocado error we have been given exceptions for approval in previous request: https://github.com/Azure/azure-rest-api-specs/pull/30737/checks?check_run_id=30717134193

@nasc17 nasc17 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 24, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024
@ramoka178 ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 24, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024
@nasc17 nasc17 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 25, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 25, 2024
@nasc17
Copy link
Member Author

nasc17 commented Oct 25, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview BreakingChange-Go-Sdk new-api-version PostgreSQL PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager SuppressionReviewRequired WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants