-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review request for Microsoft.DBforPostgreSQL to add version preview/2024-11-01-preview #30718
base: main
Are you sure you want to change the base?
Review request for Microsoft.DBforPostgreSQL to add version preview/2024-11-01-preview #30718
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
…ql-Microsoft.DBforPostgreSQL-V20241101-preview
...sql/resource-manager/Microsoft.DBforPostgreSQL/preview/2024-11-01-preview/TuningOptions.json
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Please look at the open comments and address them |
All have been addressed |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Bumped the comment that got resolved but is not implemented. Could you check that and Also fix the Swagger Avocado error |
@ramoka178 The swagger avocado error we have been given exceptions for approval in previous request: https://github.com/Azure/azure-rest-api-specs/pull/30737/checks?check_run_id=30717134193 |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.