Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network 2018 05 01 #3068

Merged
merged 7 commits into from
May 14, 2018
Merged

Network 2018 05 01 #3068

merged 7 commits into from
May 14, 2018

Conversation

sayghosh
Copy link
Contributor

@sayghosh sayghosh commented May 14, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️1 new Warnings.(96 total)
Code Id Source Message
EnumInsteadOfBoolean R3018 Link Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
❌0 new Errors.(74 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️2 new Warnings.(112 total)
Code Id Source Message
DescriptionAndTitleMissing R4000 Link 'flowAnalyticsConfiguration' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'networkWatcherFlowAnalyticsConfiguration' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

MikhailTryakhov
MikhailTryakhov approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@MikhailTryakhov MikhailTryakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted changes in April branch from PR #3023

Moved changes to the May folder. LGTM

@MikhailTryakhov
Copy link
Contributor

Hi @sergey-shandar @dsgouda can you please help to escalate merging process. it contains a fix for a PR with a mistake I missed...

@azuresdkciprbot
Copy link

AutoRest linter results for SDK Related Validation Errors/Warnings

These errors are reported by the SDK team's validation tools, reachout to ADX Swagger Reviewers directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️2 new Warnings.(112 total)
Code Id Source Message
DescriptionAndTitleMissing R4000 Link 'flowAnalyticsConfiguration' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
DescriptionAndTitleMissing R4000 Link 'networkWatcherFlowAnalyticsConfiguration' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
❌0 new Errors.(0 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

AutoRest linter results for ARM Related Validation Errors/Warnings

These errors are reported by the ARM team's validation tools, reachout to ARM RP API Review directly for any questions or concerns.

File: specification/network/resource-manager/readme.md

⚠️1 new Warnings.(96 total)
Code Id Source Message
EnumInsteadOfBoolean R3018 Link Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: enabled
❌0 new Errors.(74 total)

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

dsgouda
dsgouda approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM subject to CIs passing

@MikhailTryakhov
Copy link
Contributor

@dsgouda ready to merge :)

@dsgouda dsgouda merged commit a8d6f8b into Azure:Network-2018-05-01 May 14, 2018
dsgouda pushed a commit that referenced this pull request May 17, 2018
@MikhailTryakhov @dsgouda
Network-2018-05-01 to master (#3089)
b6ca4df 
* Added 2018-05-01 version. Common fixes (#3025)

* Created May folder. Updated version for exampls, commands

* Updated package to May version

* Returned NW examples

* Fixed API version; Fixed NetworkWatcher examples

* Fixed VPN Gateway/Connection examples

* Add changes from PR#2975
https://github.com/Azure/azure-rest-api-specs/pull/2975/files

* Adding optional traffic analytics config fields to network watcher config object for enhancing the Network Watcher cmdlets (#3023)

* Adding optional traffic analytics parameters with existing network watched flowlog configuration

* Updating the version

* Updating latest versoin in readme.md

* #AppGw Fundamentals Clean Up (#3046)

* Network 2018 05 01 (#3068)

* Adding optional traffic analytics parameters with existing network watched flowlog configuration

* Updating the version

* Updating latest versoin in readme.md

* Adding optional traffic analytics parameters with flowlog parameters

* Reverting old chnages

* Expose new SKUs for VMSS VPN and ER gateways (#3069)

Expose new SKUs for VMSS VPN and ER gateways

* Initial network error fixes and suppressions (#3051)

* Initial network error fixes and suppressions

* reworked exception to specified code blocks only

* Added express route fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikhailTryakhov MikhailTryakhov MikhailTryakhov approved these changes

@dsgouda dsgouda dsgouda approved these changes

@DeepakRajendranMsft DeepakRajendranMsft Awaiting requested review from DeepakRajendranMsft

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

Assignees

@jianghaolu jianghaolu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sayghosh @azuresdkciprbot @MikhailTryakhov @dsgouda @jianghaolu