Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preview version with site certs #30638

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Add preview version with site certs #30638

wants to merge 14 commits into from

Conversation

joerob-msft
Copy link
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 18, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes in the generated SDK for Go (label: BreakingChange-Go-Sdk). Refer to step 3 in the PR workflow diagram.
  • ❌ The required check named Swagger SemanticValidation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 18, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/appservice/armappservice https://apiview.dev/Assemblies/Review/c727c406be7543caa08a79ce56dda352?revisionId=1e0f253041054b5db0329deb076c78cd
Java azure-resourcemanager-appservice-generated https://apiview.dev/Assemblies/Review/a2b80e4fbd144844bca0c504ef8c3337?revisionId=ffe552709ee0483aa4be8aeb5671007a
JavaScript @azure/arm-appservice There is no API change compared with the previous version
.Net Azure.ResourceManager.AppService https://apiview.dev/Assemblies/Review/130e1fafd480482f83e1bdc3f68649a0?revisionId=599433eebb104ca991162714a1cae1bc

@joerob-msft joerob-msft changed the base branch from master to main September 18, 2024 22:42
@azure-sdk azure-sdk mentioned this pull request Sep 18, 2024
Draft
This was referenced Sep 18, 2024
Draft
Draft
Draft
@azure-sdk azure-sdk mentioned this pull request Sep 18, 2024
Draft
@joerob-msft joerob-msft added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadelesh tadelesh Awaiting requested review from tadelesh tadelesh will be requested when the pull request is marked ready for review tadelesh is a code owner

@naveedaz naveedaz Awaiting requested review from naveedaz naveedaz will be requested when the pull request is marked ready for review naveedaz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
BreakingChange-Go-Sdk PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager Web Apps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joerob-msft @azure-sdk @AzureRestAPISpecReview @tadelesh