Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job router azure review comments #30608

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Job router azure review comments #30608

wants to merge 4 commits into from

Conversation

v-vdharmaraj
Copy link

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 17, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR has breaking changes in the generated SDK for Python (label: BreakingChange-Python-Sdk). Refer to step 3 in the PR workflow diagram.
  • ❌ The required check named TypeSpec Validation has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 17, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
JavaScript @azure-rest/communication-job-router https://apiview.dev/Assemblies/Review/c803413a44f94ac19c189b18293736c8?revisionId=d4468d80e9cd4ab49eeaf513b951fed7
Python azure-communication-jobrouter https://apiview.dev/Assemblies/Review/a0a3b623cd52438c8400f0748195e0bc?revisionId=97f56896f08b4623bcfc8ab2334a8e53
.Net Azure.Communication.JobRouter https://apiview.dev/Assemblies/Review/641328140bc74137a39399a3cbfb484c?revisionId=6d7279bae40f4561b01ca39072cb6242
TypeSpec Communication.JobRouter https://apiview.dev/Assemblies/Review/1b7d23f22666411187e8591316a4569c?revisionId=c95a4bf6b99446c38d78dd4828d324be

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required TypeSpec Authored with TypeSpec labels Sep 17, 2024
@azure-sdk azure-sdk mentioned this pull request Sep 17, 2024
Draft
@AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Sep 17, 2024
This was referenced Sep 17, 2024
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BreakingChange-Python-Sdk TypeSpec Authored with TypeSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v-vdharmaraj @azure-sdk @AzureRestAPISpecReview